Re: [dts] [PATCH V1] fix vlan filter off in invalid

["Liu, Yong" <yong.liu@intel.com>]

Hi Gang,
This action is pretty weird, please also note in the code. It will be better if there's additional information like JIRA bug ID.

Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,gang
> Sent: Tuesday, June 05, 2018 5:59 PM
> To: dts@dpdk.org
> Cc: Xu, GangX <gangx.xu@intel.com>
> Subject: [dts] [PATCH V1] fix vlan filter off in invalid
> 
> Before the dpdk commit 8b9bd0efe0b6920a08e28eebacf2bb916bdf5653
> VLAN filter and VLAN strip are enabled in testpmd by default.
> But since this commit ,they are disabled by default.
> so "vlam set filter off 0" can't be expected,
> need "vlan set filter on 0" first
> 
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
>  tests/TestSuite_generic_filter.py | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tests/TestSuite_generic_filter.py
> b/tests/TestSuite_generic_filter.py
> index e69246b..cc7934b 100644
> --- a/tests/TestSuite_generic_filter.py
> +++ b/tests/TestSuite_generic_filter.py
> @@ -103,8 +103,12 @@ class TestGeneric_filter(TestCase):
>              self.dut.send_expect(
>                  "vlan set strip off %s" % valports[1], "testpmd> ")
>              self.dut.send_expect(
> +                "vlan set filter on %s" % valports[0], "testpmd> ")
> +            self.dut.send_expect(
>                  "vlan set filter off %s" % valports[0], "testpmd> ")
>              self.dut.send_expect(
> +                "vlan set filter on %s" % valports[1], "testpmd> ")
> +            self.dut.send_expect(
>                  "vlan set filter off %s" % valports[1], "testpmd> ")
> 
>          self.dut.send_expect("set flush_rx on", "testpmd> ")
> --
> 1.9.3