From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 5AD001D42F for ; Mon, 11 Jun 2018 07:54:35 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jun 2018 22:54:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,500,1520924400"; d="scan'208";a="48875694" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga006.jf.intel.com with ESMTP; 10 Jun 2018 22:54:32 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 10 Jun 2018 22:54:14 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.51]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.87]) with mapi id 14.03.0319.002; Mon, 11 Jun 2018 13:54:11 +0800 From: "Liu, Yong" To: "Xu, GangX" , "dts@dpdk.org" CC: "Xu, GangX" Thread-Topic: [dts] [PATCH V1] fix vlan filter off in invalid Thread-Index: AQHT/LOtsuM4sPMBpkeAtqlIpMCXH6Ral39w Date: Mon, 11 Jun 2018 05:54:11 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E630C1831@SHSMSX103.ccr.corp.intel.com> References: <1528192737-44719-1-git-send-email-gangx.xu@intel.com> In-Reply-To: <1528192737-44719-1-git-send-email-gangx.xu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjM5MjgyYjMtYTY2ZS00YTdmLTkxMmUtOGI4ZDg1Y2EyYTEzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMGNOM25VQ2JIM0VpU0dtTnhaSFBMdVRsenJJbWtFWkhRTlJMUVVCOW0rMGdUU0JIYkphUHNQWERGRXdBdHkxRyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] fix vlan filter off in invalid X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jun 2018 05:54:35 -0000 Hi Gang, This action is pretty weird, please also note in the code. It will be bette= r if there's additional information like JIRA bug ID. Thanks, Marvin > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,gang > Sent: Tuesday, June 05, 2018 5:59 PM > To: dts@dpdk.org > Cc: Xu, GangX > Subject: [dts] [PATCH V1] fix vlan filter off in invalid >=20 > Before the dpdk commit 8b9bd0efe0b6920a08e28eebacf2bb916bdf5653 > VLAN filter and VLAN strip are enabled in testpmd by default. > But since this commit ,they are disabled by default. > so "vlam set filter off 0" can't be expected, > need "vlan set filter on 0" first >=20 > Signed-off-by: xu,gang > --- > tests/TestSuite_generic_filter.py | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/tests/TestSuite_generic_filter.py > b/tests/TestSuite_generic_filter.py > index e69246b..cc7934b 100644 > --- a/tests/TestSuite_generic_filter.py > +++ b/tests/TestSuite_generic_filter.py > @@ -103,8 +103,12 @@ class TestGeneric_filter(TestCase): > self.dut.send_expect( > "vlan set strip off %s" % valports[1], "testpmd> ") > self.dut.send_expect( > + "vlan set filter on %s" % valports[0], "testpmd> ") > + self.dut.send_expect( > "vlan set filter off %s" % valports[0], "testpmd> ") > self.dut.send_expect( > + "vlan set filter on %s" % valports[1], "testpmd> ") > + self.dut.send_expect( > "vlan set filter off %s" % valports[1], "testpmd> ") >=20 > self.dut.send_expect("set flush_rx on", "testpmd> ") > -- > 1.9.3