Re: [dts] [PATCH V2] tests/unit_tests_pmd_perf: fix the ports and cores were from different sockets

["Liu, Yong" <yong.liu@intel.com>]

Peipei,
More comments are inline.

Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lu,peipei
> Sent: Tuesday, June 12, 2018 2:29 PM
> To: dts@dpdk.org
> Cc: Lu, PeipeiX <peipeix.lu@intel.com>
> Subject: [dts] [PATCH V2] tests/unit_tests_pmd_perf: fix the ports and
> cores were from different sockets
> 
> the cases need ports and cores from the same socket.
> 
> Signed-off-by: lu,peipei <peipeix.lu@intel.com>
> ---
>  tests/TestSuite_unit_tests_pmd_perf.py | 24 ++++++++++++++++++++----
>  1 file changed, 20 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/TestSuite_unit_tests_pmd_perf.py
> b/tests/TestSuite_unit_tests_pmd_perf.py
> index 7fc200e..ab67b5d 100644
> --- a/tests/TestSuite_unit_tests_pmd_perf.py
> +++ b/tests/TestSuite_unit_tests_pmd_perf.py
> @@ -85,12 +85,27 @@ class TestUnitTestsPmdPerf(TestCase):
>          """
>          pass
> 
> +    def get_core_from_socket(self):
> +       """
> +       select  the port and lcores from same socket.
> +       """
> +
> +       out = self.dut.send_expect("./usertools/cpu_layout.py","#", 10)

Please add space after comma symbol.

> +       k = re.search("Core 0 (.*)", out)
> +       result = re.findall("(\d+),", k.group())
> +       socket_id = self.dut.ports_info[0]['port'].socket
> +       if socket_id == 0 or socket_id == -1:
> +          return  int(result[0])
> +       else:
> +          return  int(result[1])
> +
>      def test_pmd_burst(self):
>          """
>          Run pmd stream control mode burst test case.
>          """
> 
> -        self.dut.send_expect("./test/test/test -n 1 -c f",
> "R.*T.*E.*>.*>", 60)
> +        self.core = self.get_core_from_socket()
> +        self.dut.send_expect("./test/test/test -n 1 --lcores='%d-
> %d'" %(self.core, self.core + 6), "R.*T.*E.*>.*>", 60)

Please add space after percent sign.

>          for mode in self.burst_ctlmodes:
>              self.dut.send_expect("set_rxtx_sc %s" % mode, "RTE>>", 10)
>              out = self.dut.send_expect("pmd_perf_autotest", "RTE>>", 120)
> @@ -105,7 +120,8 @@ class TestUnitTestsPmdPerf(TestCase):
>          """
>          Run pmd stream control mode continues test case.
>          """
> -
> +
> +        self.core = self.get_core_from_socket()
>          self.table_header = ['Mode']
>          self.table_header += self.anchors
>          self.result_table_create(self.table_header)
> @@ -113,9 +129,9 @@ class TestUnitTestsPmdPerf(TestCase):
> 
>          for mode in self.rxtx_modes:
>              if mode is "scalar":
> -                self.dut.send_expect("./test/test/test_scalar -n 1 -c f",
> "R.*T.*E.*>.*>", 60)
> +                self.dut.send_expect("./test/test/test_scalar -n 1 --
> lcores='%d-%d'" %(self.core, self.core + 6), "R.*T.*E.*>.*>", 60)

Please reduce the number of core, if possible please just use 2 cores.

>              else:
> -                self.dut.send_expect("./test/test/test -n 1 -c f",
> "R.*T.*E.*>.*>", 60)
> +                self.dut.send_expect("./test/test/test -n 1 --lcores='%d-
> %d'" %(self.core, self.core + 6), "R.*T.*E.*>.*>", 60)
> 
>              table_row = [mode]
>              self.dut.send_expect("set_rxtx_sc continuous", "RTE>>", 10)
> --
> 1.9.3