Re: [dts] [PATCH V1] tests/sriov kvm:add vlan strip

["Liu, Yong" <yong.liu@intel.com>]

Hi Meijuan,
Could you please confirm with developer that vlan strip was must for mirror? 
If it is true, please also update related test plan.

Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhao,meijuan
> Sent: Tuesday, June 12, 2018 4:45 PM
> To: dts@dpdk.org
> Cc: Zhao, MeijuanX <meijuanx.zhao@intel.com>
> Subject: [dts] [PATCH V1] tests/sriov kvm:add vlan strip
> 
> before dpdk18.02, testpmd default vlan strip value is enable,
>  test vlan mirror need enable vlan strip
> 
> Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
> ---
>  tests/TestSuite_sriov_kvm.py | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/TestSuite_sriov_kvm.py b/tests/TestSuite_sriov_kvm.py
> index ee8d555..e5c984c 100644
> --- a/tests/TestSuite_sriov_kvm.py
> +++ b/tests/TestSuite_sriov_kvm.py
> @@ -772,7 +772,7 @@ class TestSriovKvm(TestCase):
>      def test_two_vms_vlan_mirror(self):
>          self.setup_2vm_2vf_env()
>          self.setup_two_vm_common_prerequisite()
> -
> +        self.vm1_testpmd.execute_cmd('vlan set strip on 0')
>          port_id_0 = 0
>          vlan_id = 0
>          vf_mask = '0x1'
> @@ -804,7 +804,8 @@ class TestSriovKvm(TestCase):
>      def test_two_vms_vlan_and_pool_mirror(self):
>          self.setup_2vm_2vf_env()
>          self.setup_two_vm_common_prerequisite()
> -
> +        self.vm0_testpmd.execute_cmd('vlan set strip on 0')
> +        self.vm1_testpmd.execute_cmd('vlan set strip on 0')
>          port_id_0 = 0
>          vlan_id = 3
>          vf_mask = '0x2'
> @@ -851,7 +852,8 @@ class TestSriovKvm(TestCase):
>      def test_two_vms_uplink_and_downlink_mirror(self):
>          self.setup_2vm_2vf_env()
>          self.setup_two_vm_common_prerequisite()
> -
> +        self.vm0_testpmd.execute_cmd('vlan set strip on 0')
> +        self.vm1_testpmd.execute_cmd('vlan set strip on 0')
>          self.vm0_testpmd.execute_cmd('stop')
>          self.vm1_testpmd.execute_cmd('stop')
> 
> --
> 1.9.3