test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH] tests: TestSuite_runtime_queue_number.py
@ 2018-07-11  5:45 Peng Yuan
  2018-07-12  3:14 ` Liu, Yong
  0 siblings, 1 reply; 2+ messages in thread
From: Peng Yuan @ 2018-07-11  5:45 UTC (permalink / raw)
  To: dts; +Cc: Peng Yuan

there are different vf number in different fortville type.

Signed-off-by: Peng Yuan <yuan.peng@intel.com>

diff --git a/tests/TestSuite_runtime_queue_number.py b/tests/TestSuite_runtime_queue_number.py
index b767e06..2daac45 100644
--- a/tests/TestSuite_runtime_queue_number.py
+++ b/tests/TestSuite_runtime_queue_number.py
@@ -125,7 +125,7 @@ class TestRuntime_Queue_Number(TestCase):
         """
         self.tester.scapy_foreground()
         time.sleep(2)
-        for i in range(32):
+        for i in range(100):
             packet = r'sendp([Ether(dst="%s", src=get_if_hwaddr("%s"))/IP(src="192.168.0.%d", dst="192.168.0.%d")], iface="%s")' % (
                 self.vf_mac, itf, i + 1, i + 2, itf)
             self.tester.scapy_append(packet)
@@ -160,7 +160,7 @@ class TestRuntime_Queue_Number(TestCase):
                 m = scanner.search(line)
                 packet_rec = m.group(1)
             
-        self.verify(packet_sumnum == int(packet_rec) == 32, "There are some packets lost.")
+        self.verify(packet_sumnum == int(packet_rec) == 100, "There are some packets lost.")
 
     def test_set_valid_vf_max_qn(self):
         """
@@ -238,18 +238,24 @@ class TestRuntime_Queue_Number(TestCase):
         """
         set max queue number when setting 32 VFs on 1 PF port.
         """
-        self.setup_env(32)
-        # failed to set VF max queue num to 16.
-        out = self.pmdout.start_testpmd("%s" % self.cores, eal_param="-w %s,queue-num-per-vf=16 --file-prefix=test1 --socket-mem 1024,1024" % self.pf_pci)
-        self.verify("exceeds the hardware maximum 384" in out, "the queue num exceeds the hardware maximum 384")
+        if (self.nic in ["fortville_eagle", "fortpark_TLV"]):
+            self.setup_env(32)
+            # failed to set VF max queue num to 16.
+            out = self.pmdout.start_testpmd("%s" % self.cores, eal_param="-w %s,queue-num-per-vf=16 --file-prefix=test1 --socket-mem 1024,1024" % self.pf_pci)
+            self.verify("exceeds the hardware maximum 384" in out, "the queue num exceeds the hardware maximum 384")
+        elif (self.nic in ["fortville_spirit", "fortville_spirit_single"]):
+            self.setup_env(64)
+            # failed to set VF max queue num to 16.
+            out = self.pmdout.start_testpmd("%s" % self.cores, eal_param="-w %s,queue-num-per-vf=16 --file-prefix=test1 --socket-mem 1024,1024" % self.pf_pci)
+            self.verify("exceeds the hardware maximum 768" in out, "the queue num exceeds the hardware maximum 768")
         self.dut.send_expect("quit", "# ")
         time.sleep(5)
         # succeed in setting VF max queue num to 8
         self.pmdout.start_testpmd("%s" % self.cores, eal_param="-w %s,queue-num-per-vf=8 --file-prefix=test1 --socket-mem 1024,1024" % self.pf_pci)
         # start testpmd on vf0
-        self.session_secondary.send_expect("./%s/app/testpmd -c 0xf0 -n 4 -w %s --file-prefix=test2 --socket-mem 1024,1024 -- -i --rxq=%d --txq=%d" % (self.target, self.sriov_vfs_port[0].pci, 8, 8), "testpmd>", 120)
+        self.session_secondary.send_expect("./%s/app/testpmd -c 0x1e0 -n 4 -w %s --file-prefix=test2 --socket-mem 1024,1024 -- -i --rxq=%d --txq=%d" % (self.target, self.sriov_vfs_port[0].pci, 8, 8), "testpmd>", 120)
         # start testpmd on vf31 with different rxq/txq number
-        self.session_third.send_expect("./%s/app/testpmd -c 0xf00 -n 4 -w %s --file-prefix=test3 --socket-mem 1024,1024 -- -i" % (self.target, self.sriov_vfs_port[31].pci), "testpmd>", 120)
+        self.session_third.send_expect("./%s/app/testpmd -c 0x1e00 -n 4 -w %s --file-prefix=test3 --socket-mem 1024,1024 -- -i" % (self.target, self.sriov_vfs_port[31].pci), "testpmd>", 120)
         # check the max queue number and current queue number
         outstring = self.session_secondary.send_expect("show port info all", "testpmd> ", 120)
         self.verify_result(outstring, max_rxqn=8, max_txqn=8, cur_rxqn=8, cur_txqn=8)
-- 
2.7.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH] tests: TestSuite_runtime_queue_number.py
  2018-07-11  5:45 [dts] [PATCH] tests: TestSuite_runtime_queue_number.py Peng Yuan
@ 2018-07-12  3:14 ` Liu, Yong
  0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2018-07-12  3:14 UTC (permalink / raw)
  To: Peng, Yuan, dts; +Cc: Peng, Yuan

Yuan, you'd better update VF number in test plan. 
I think 100 packets maybe not spread on all VF devices, more number like 256 or 512 will be needed.

Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Peng Yuan
> Sent: Wednesday, July 11, 2018 1:46 PM
> To: dts@dpdk.org
> Cc: Peng, Yuan <yuan.peng@intel.com>
> Subject: [dts] [PATCH] tests: TestSuite_runtime_queue_number.py
> 
> there are different vf number in different fortville type.
> 
> Signed-off-by: Peng Yuan <yuan.peng@intel.com>
> 
> diff --git a/tests/TestSuite_runtime_queue_number.py
> b/tests/TestSuite_runtime_queue_number.py
> index b767e06..2daac45 100644
> --- a/tests/TestSuite_runtime_queue_number.py
> +++ b/tests/TestSuite_runtime_queue_number.py
> @@ -125,7 +125,7 @@ class TestRuntime_Queue_Number(TestCase):
>          """
>          self.tester.scapy_foreground()
>          time.sleep(2)
> -        for i in range(32):
> +        for i in range(100):
>              packet = r'sendp([Ether(dst="%s",
> src=get_if_hwaddr("%s"))/IP(src="192.168.0.%d", dst="192.168.0.%d")],
> iface="%s")' % (
>                  self.vf_mac, itf, i + 1, i + 2, itf)
>              self.tester.scapy_append(packet)
> @@ -160,7 +160,7 @@ class TestRuntime_Queue_Number(TestCase):
>                  m = scanner.search(line)
>                  packet_rec = m.group(1)
> 
> -        self.verify(packet_sumnum == int(packet_rec) == 32, "There are
> some packets lost.")
> +        self.verify(packet_sumnum == int(packet_rec) == 100, "There are
> some packets lost.")
> 
>      def test_set_valid_vf_max_qn(self):
>          """
> @@ -238,18 +238,24 @@ class TestRuntime_Queue_Number(TestCase):
>          """
>          set max queue number when setting 32 VFs on 1 PF port.
>          """
> -        self.setup_env(32)
> -        # failed to set VF max queue num to 16.
> -        out = self.pmdout.start_testpmd("%s" % self.cores, eal_param="-
> w %s,queue-num-per-vf=16 --file-prefix=test1 --socket-mem 1024,1024" %
> self.pf_pci)
> -        self.verify("exceeds the hardware maximum 384" in out, "the queue
> num exceeds the hardware maximum 384")
> +        if (self.nic in ["fortville_eagle", "fortpark_TLV"]):
> +            self.setup_env(32)
> +            # failed to set VF max queue num to 16.
> +            out = self.pmdout.start_testpmd("%s" % self.cores,
> eal_param="-w %s,queue-num-per-vf=16 --file-prefix=test1 --socket-mem
> 1024,1024" % self.pf_pci)
> +            self.verify("exceeds the hardware maximum 384" in out, "the
> queue num exceeds the hardware maximum 384")
> +        elif (self.nic in ["fortville_spirit",
> "fortville_spirit_single"]):
> +            self.setup_env(64)
> +            # failed to set VF max queue num to 16.
> +            out = self.pmdout.start_testpmd("%s" % self.cores,
> eal_param="-w %s,queue-num-per-vf=16 --file-prefix=test1 --socket-mem
> 1024,1024" % self.pf_pci)
> +            self.verify("exceeds the hardware maximum 768" in out, "the
> queue num exceeds the hardware maximum 768")
>          self.dut.send_expect("quit", "# ")
>          time.sleep(5)
>          # succeed in setting VF max queue num to 8
>          self.pmdout.start_testpmd("%s" % self.cores, eal_param="-
> w %s,queue-num-per-vf=8 --file-prefix=test1 --socket-mem 1024,1024" %
> self.pf_pci)
>          # start testpmd on vf0
> -        self.session_secondary.send_expect("./%s/app/testpmd -c 0xf0 -n 4
> -w %s --file-prefix=test2 --socket-mem 1024,1024 -- -i --rxq=%d --txq=%d" %
> (self.target, self.sriov_vfs_port[0].pci, 8, 8), "testpmd>", 120)
> +        self.session_secondary.send_expect("./%s/app/testpmd -c 0x1e0 -n
> 4 -w %s --file-prefix=test2 --socket-mem 1024,1024 -- -i --rxq=%d --
> txq=%d" % (self.target, self.sriov_vfs_port[0].pci, 8, 8), "testpmd>", 120)
>          # start testpmd on vf31 with different rxq/txq number
> -        self.session_third.send_expect("./%s/app/testpmd -c 0xf00 -n 4 -
> w %s --file-prefix=test3 --socket-mem 1024,1024 -- -i" % (self.target,
> self.sriov_vfs_port[31].pci), "testpmd>", 120)
> +        self.session_third.send_expect("./%s/app/testpmd -c 0x1e00 -n 4 -
> w %s --file-prefix=test3 --socket-mem 1024,1024 -- -i" % (self.target,
> self.sriov_vfs_port[31].pci), "testpmd>", 120)
>          # check the max queue number and current queue number
>          outstring = self.session_secondary.send_expect("show port info
> all", "testpmd> ", 120)
>          self.verify_result(outstring, max_rxqn=8, max_txqn=8, cur_rxqn=8,
> cur_txqn=8)
> --
> 2.7.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-07-12  3:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-11  5:45 [dts] [PATCH] tests: TestSuite_runtime_queue_number.py Peng Yuan
2018-07-12  3:14 ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).