From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 0E9A31B431 for ; Thu, 2 Aug 2018 07:02:56 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Aug 2018 22:02:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,434,1526367600"; d="scan'208";a="79815858" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga002.jf.intel.com with ESMTP; 01 Aug 2018 22:02:54 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 1 Aug 2018 22:02:53 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 1 Aug 2018 22:02:53 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.100]) by shsmsx102.ccr.corp.intel.com ([169.254.2.124]) with mapi id 14.03.0319.002; Thu, 2 Aug 2018 13:02:51 +0800 From: "Liu, Yong" To: "Han, YingyaX" , "dts@dpdk.org" CC: "Han, YingyaX" Thread-Topic: [dts] [PATCH V1]tests/shutdown-api: fix the crc-strip issue Thread-Index: AQHUKgcphIGl9BiuykOZEKe6e2UFLqSr5neA Date: Thu, 2 Aug 2018 05:02:51 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E63104EF2@SHSMSX103.ccr.corp.intel.com> References: <1533176303-109061-1-git-send-email-yingyax.han@intel.com> In-Reply-To: <1533176303-109061-1-git-send-email-yingyax.han@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmM2MTg3YjktNjZiZi00ZGY4LWJiODktZjYyMDU5NGEzZTRhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiXC9tTGcxZHlrSEZpTHkwVytZQmRJeFFzMWZnc1hvandJT0o1UWk5UDBheGpjMGtLSnAwQSt0REhUb2huZXQwYTMifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1]tests/shutdown-api: fix the crc-strip issue X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Aug 2018 05:02:57 -0000 Hi Yingya, Hex value 0x10000 look wired here, please change the verify message to "CRC= keeping not enabled properly" which will be more meaningful. Thanks, Marvin > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of han,yingya > Sent: Thursday, August 02, 2018 10:18 AM > To: dts@dpdk.org > Cc: Han, YingyaX > Subject: [dts] [PATCH V1]tests/shutdown-api: fix the crc-strip issue >=20 > The "disable-crc-strip" parameter was modified in dpdk 18.08. > The expected value for RX_offloads when crc-strip is off is 0x10000 and w= hen > crc-strip is on is 0x1000. > More details can refer to dpdk commit e557ebc0 and DPDK-5829. > Signed-off-by: han,yingya > --- > tests/TestSuite_shutdown_api.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/tests/TestSuite_shutdown_api.py > b/tests/TestSuite_shutdown_api.py > index d00c3fb..3cb0eff 100644 > --- a/tests/TestSuite_shutdown_api.py > +++ b/tests/TestSuite_shutdown_api.py > @@ -266,7 +266,7 @@ class TestShutdownApi(TestCase): > self.pmdout.start_testpmd("Default", "--portmask=3D%s --port- > topology=3Dloop --disable-crc-strip" % utils.create_mask(self.ports), > socket=3Dself.ports_socket) > out =3D self.dut.send_expect("show config rxtx", "testpmd> ") > self.verify( > - "Rx offloads=3D0x0" in out, "CRC stripping not disabled prop= erly") > + "Rx offloads=3D0x10000" in out, "CRC stripping not disabled > properly") >=20 > self.dut.send_expect("port stop all", "testpmd> ", 100) > self.dut.send_expect("port config all crc-strip on", "testpmd> "= ) > -- > 1.9.3