* [dts] [PATCH V1]tests/shutdown-api: fix the crc-strip issue @ 2018-08-02 2:18 han,yingya 2018-08-02 5:02 ` Liu, Yong 0 siblings, 1 reply; 3+ messages in thread From: han,yingya @ 2018-08-02 2:18 UTC (permalink / raw) To: dts; +Cc: han,yingya The "disable-crc-strip" parameter was modified in dpdk 18.08. The expected value for RX_offloads when crc-strip is off is 0x10000 and when crc-strip is on is 0x1000. More details can refer to dpdk commit e557ebc0 and DPDK-5829. Signed-off-by: han,yingya <yingyax.han@intel.com> --- tests/TestSuite_shutdown_api.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py index d00c3fb..3cb0eff 100644 --- a/tests/TestSuite_shutdown_api.py +++ b/tests/TestSuite_shutdown_api.py @@ -266,7 +266,7 @@ class TestShutdownApi(TestCase): self.pmdout.start_testpmd("Default", "--portmask=%s --port-topology=loop --disable-crc-strip" % utils.create_mask(self.ports), socket=self.ports_socket) out = self.dut.send_expect("show config rxtx", "testpmd> ") self.verify( - "Rx offloads=0x0" in out, "CRC stripping not disabled properly") + "Rx offloads=0x10000" in out, "CRC stripping not disabled properly") self.dut.send_expect("port stop all", "testpmd> ", 100) self.dut.send_expect("port config all crc-strip on", "testpmd> ") -- 1.9.3 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dts] [PATCH V1]tests/shutdown-api: fix the crc-strip issue 2018-08-02 2:18 [dts] [PATCH V1]tests/shutdown-api: fix the crc-strip issue han,yingya @ 2018-08-02 5:02 ` Liu, Yong 2018-08-02 6:37 ` Han, YingyaX 0 siblings, 1 reply; 3+ messages in thread From: Liu, Yong @ 2018-08-02 5:02 UTC (permalink / raw) To: Han, YingyaX, dts; +Cc: Han, YingyaX Hi Yingya, Hex value 0x10000 look wired here, please change the verify message to "CRC keeping not enabled properly" which will be more meaningful. Thanks, Marvin > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of han,yingya > Sent: Thursday, August 02, 2018 10:18 AM > To: dts@dpdk.org > Cc: Han, YingyaX <yingyax.han@intel.com> > Subject: [dts] [PATCH V1]tests/shutdown-api: fix the crc-strip issue > > The "disable-crc-strip" parameter was modified in dpdk 18.08. > The expected value for RX_offloads when crc-strip is off is 0x10000 and when > crc-strip is on is 0x1000. > More details can refer to dpdk commit e557ebc0 and DPDK-5829. > Signed-off-by: han,yingya <yingyax.han@intel.com> > --- > tests/TestSuite_shutdown_api.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/TestSuite_shutdown_api.py > b/tests/TestSuite_shutdown_api.py > index d00c3fb..3cb0eff 100644 > --- a/tests/TestSuite_shutdown_api.py > +++ b/tests/TestSuite_shutdown_api.py > @@ -266,7 +266,7 @@ class TestShutdownApi(TestCase): > self.pmdout.start_testpmd("Default", "--portmask=%s --port- > topology=loop --disable-crc-strip" % utils.create_mask(self.ports), > socket=self.ports_socket) > out = self.dut.send_expect("show config rxtx", "testpmd> ") > self.verify( > - "Rx offloads=0x0" in out, "CRC stripping not disabled properly") > + "Rx offloads=0x10000" in out, "CRC stripping not disabled > properly") > > self.dut.send_expect("port stop all", "testpmd> ", 100) > self.dut.send_expect("port config all crc-strip on", "testpmd> ") > -- > 1.9.3 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dts] [PATCH V1]tests/shutdown-api: fix the crc-strip issue 2018-08-02 5:02 ` Liu, Yong @ 2018-08-02 6:37 ` Han, YingyaX 0 siblings, 0 replies; 3+ messages in thread From: Han, YingyaX @ 2018-08-02 6:37 UTC (permalink / raw) To: Liu, Yong, dts; +Cc: Xia, JuanX Hi Marvin, Ok, I'll change it. Thank you for your advice. Yingya -----Original Message----- From: Liu, Yong Sent: Thursday, August 2, 2018 1:03 PM To: Han, YingyaX <yingyax.han@intel.com>; dts@dpdk.org Cc: Han, YingyaX <yingyax.han@intel.com> Subject: RE: [dts] [PATCH V1]tests/shutdown-api: fix the crc-strip issue Hi Yingya, Hex value 0x10000 look wired here, please change the verify message to "CRC keeping not enabled properly" which will be more meaningful. Thanks, Marvin > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of han,yingya > Sent: Thursday, August 02, 2018 10:18 AM > To: dts@dpdk.org > Cc: Han, YingyaX <yingyax.han@intel.com> > Subject: [dts] [PATCH V1]tests/shutdown-api: fix the crc-strip issue > > The "disable-crc-strip" parameter was modified in dpdk 18.08. > The expected value for RX_offloads when crc-strip is off is 0x10000 > and when crc-strip is on is 0x1000. > More details can refer to dpdk commit e557ebc0 and DPDK-5829. > Signed-off-by: han,yingya <yingyax.han@intel.com> > --- > tests/TestSuite_shutdown_api.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/TestSuite_shutdown_api.py > b/tests/TestSuite_shutdown_api.py index d00c3fb..3cb0eff 100644 > --- a/tests/TestSuite_shutdown_api.py > +++ b/tests/TestSuite_shutdown_api.py > @@ -266,7 +266,7 @@ class TestShutdownApi(TestCase): > self.pmdout.start_testpmd("Default", "--portmask=%s --port- > topology=loop --disable-crc-strip" % utils.create_mask(self.ports), > socket=self.ports_socket) > out = self.dut.send_expect("show config rxtx", "testpmd> ") > self.verify( > - "Rx offloads=0x0" in out, "CRC stripping not disabled properly") > + "Rx offloads=0x10000" in out, "CRC stripping not disabled > properly") > > self.dut.send_expect("port stop all", "testpmd> ", 100) > self.dut.send_expect("port config all crc-strip on", > "testpmd> ") > -- > 1.9.3 ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-02 6:38 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-08-02 2:18 [dts] [PATCH V1]tests/shutdown-api: fix the crc-strip issue han,yingya 2018-08-02 5:02 ` Liu, Yong 2018-08-02 6:37 ` Han, YingyaX
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).