From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id E69F92E41 for ; Mon, 20 Aug 2018 09:30:50 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Aug 2018 00:30:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,264,1531810800"; d="scan'208";a="256329550" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga006.fm.intel.com with ESMTP; 20 Aug 2018 00:30:38 -0700 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 20 Aug 2018 00:30:38 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 20 Aug 2018 00:30:38 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.240]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.150]) with mapi id 14.03.0319.002; Mon, 20 Aug 2018 15:30:36 +0800 From: "Liu, Yong" To: "Lin, Xueqin" , "dts@dpdk.org" CC: "Lin, Xueqin" Thread-Topic: [dts] [PATCH] tests/dynamic_queue: add dynamic queue test suite Thread-Index: AQHULjj+4hSv6h66BkeFi5XoYEqenKTISBBw Date: Mon, 20 Aug 2018 07:30:35 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E63129BB0@SHSMSX103.ccr.corp.intel.com> References: <1533615829-108513-1-git-send-email-xueqin.lin@intel.com> In-Reply-To: <1533615829-108513-1-git-send-email-xueqin.lin@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDljZjA0ZTAtZGI0NC00MGEzLWJhMmYtMjRiZmQxNTdlY2U0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWDZsZlo0ekEzR05GTFlKUlJlTExrczRRMEoyTUxGUFlHcWVtc3U5c3NOV3UyWXNoWmtYN3JlYzJHVUJwZGRYeiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH] tests/dynamic_queue: add dynamic queue test suite X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Aug 2018 07:30:51 -0000 > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xueqin Lin > Sent: Tuesday, August 07, 2018 12:24 PM > To: dts@dpdk.org > Cc: Lin, Xueqin > Subject: [dts] [PATCH] tests/dynamic_queue: add dynamic queue test suite >=20 > From: "xueqin.lin" >=20 > Signed-off-by: Xueqin Lin >=20 > --- > tests/TestSuite_dynamic_queue.py | 180 > +++++++++++++++++++++++++++++++++++++++ > 1 file changed, 180 insertions(+) > create mode 100644 tests/TestSuite_dynamic_queue.py >=20 > diff --git a/tests/TestSuite_dynamic_queue.py > b/tests/TestSuite_dynamic_queue.py > new file mode 100644 > index 0000000..880d421 > --- /dev/null > +++ b/tests/TestSuite_dynamic_queue.py > @@ -0,0 +1,180 @@ > +# > + > +import time > +import re > +import utils > +from test_case import TestCase > +from pmd_output import PmdOutput > +from settings import get_nic_name > +from packet import Packet, sniff_packets, load_sniff_packets > +import random > + > + > +class TestDynamicQueue(TestCase): > + > + def set_up_all(self): > + self.dut_ports =3D self.dut.get_ports(self.nic) > + self.verify(len(self.dut_ports) >=3D 1, "Insufficient ports") > + out =3D self.dut.send_expect("cat config/common_base", "]# ", 10= ) > + self.PF_Q_strip =3D 'CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_PF' > + pattern =3D "%s=3D(\d*)" % self.PF_Q_strip > + self.PF_QUEUE =3D self.element_strip(out, pattern) We can strip config value by existing API self.dut.get_def_rte_config. Plea= se use that one. > + self.used_dut_port =3D self.dut_ports[0] > + tester_port =3D self.tester.get_local_port(self.used_dut_port) > + self.tester_intf =3D self.tester.get_interface(tester_port) > + self.dut_testpmd =3D PmdOutput(self.dut) > + > + def set_up(self): > + self.dut_testpmd.start_testpmd( > + "Default", "--port-topology=3Dchained --txq=3D%s --rxq=3D%s" > + % (self.PF_QUEUE, self.PF_QUEUE)) > + > + def element_strip(self, out, pattern): > + """ > + Strip and get queue number. > + """ > + s =3D re.compile(pattern, re.DOTALL) > + res =3D s.search(out) > + if res is None: > + print utils.RED('Fail to search number.') > + return None > + else: > + result =3D res.group(1) > + return int(result) > + > + def send_packet(self): > + """ > + Generate packets and send them to dut > + """ > + mac =3D self.dut.get_mac_address(0) > + for i in range(self.PF_QUEUE * 2): > + pkt =3D Packet(pkt_type=3D'IP_RAW') > + pkt.config_layer('ether', {'dst': mac}) > + pkt.config_layer( > + 'ipv4', {'dst': '192.168.0.%d' % i, 'src': '191.168.0.1'= }) > + pkt.send_pkt(tx_port=3Dself.tester_intf) > + > + def rxq_setup_test(self, chgflag=3D0): > + """ > + Dynamic to setup rxq and reconfigure ring size at runtime. > + chgflag: reconfigure ring size flag > + 1:reconfigure Rx ring size > + 0:no change on Rx ring size > + """ > + queue =3D range(3) Queue is just list here, why not just use list() ? > + for i in range(3): Recommend not use hard-code 3 here, you can define one global variable for = test loop.=20 > + queue[i] =3D random.randint(1, self.PF_QUEUE - 1) > + self.dut_testpmd.execute_cmd('port 0 rxq %d stop' % queue[i]= ) Please add blank line here for different code block.=20 > + self.dut_testpmd.execute_cmd('set fwd rxonly') > + self.dut_testpmd.execute_cmd('start') > + self.send_packet() > + self.dut.get_session_output(timeout=3D10) > + out =3D self.dut_testpmd.execute_cmd('stop') > + for i in range(3): > + self.verify( > + "Forward Stats for RX Port=3D 0/Queue=3D%2d" % queue[i] = not in > out, > + "Fail to verify rxq stop!") Check queue stop by "Forward stats" not shown is not straight-forward. Is t= here any other method like check rx stats? > + if chgflag =3D=3D 1: > + for i in range(3): > + out =3D self.dut_testpmd.execute_cmd( > + 'show rxq info 0 %d' % queue[i]) > + qring_strip =3D 'Number of RXDs: ' > + pattern =3D "%s([0-9]+)" % qring_strip > + qringsize =3D self.element_strip(out, pattern) > + chg_qringsize =3D qringsize % 1024 + 256 Xueqin, why first mod 1024 and then add 256? Why not just add 256? > + self.dut_testpmd.execute_cmd( > + 'port config 0 rxq %d ring_size %d' > + % (queue[i], chg_qringsize)) > + self.dut_testpmd.execute_cmd('port 0 rxq %d setup' % > queue[i]) > + out =3D self.dut_testpmd.execute_cmd( > + 'show rxq info 0 %d' % queue[i]) > + chk_qringsize =3D self.element_strip(out, pattern) > + self.verify(chk_qringsize =3D=3D chg_qringsize, > + "Fail to change ring size at runtime!") > + for i in range(3): > + if chgflag =3D=3D 0: > + self.dut_testpmd.execute_cmd('port 0 rxq %d setup' % > queue[i]) > + self.dut_testpmd.execute_cmd('port 0 rxq %d start' % queue[i= ]) > + self.dut_testpmd.execute_cmd('start') > + self.send_packet() > + self.dut.get_session_output(timeout=3D10) > + out =3D self.dut_testpmd.execute_cmd('stop') Please add blank line here, one line comment will be helpful.=20 > + for i in range(3): > + self.verify("Forward Stats for RX Port=3D 0/Queue=3D%2d" > + % queue[i] in out, "Fail to setup rxq %d at runt= ime" > + % queue[i]) > + > + def txq_setup_test(self, chgflag=3D0): > + """ > + Dynamic to setup txq and reconfigure ring size at runtime. > + chgflag: reconfigure ring size flag > + 1:reconfigure Tx ring size > + 0:no change on Tx ring size > + """ > + for i in range(3): > + queue =3D random.randint(1, self.PF_QUEUE - 1) > + out =3D self.dut_testpmd.execute_cmd('show txq info 0 %d' % = queue) > + qring_strip =3D 'Number of TXDs: ' > + pattern =3D "%s([0-9]+)" % qring_strip > + qringsize =3D self.element_strip(out, pattern) > + self.dut_testpmd.execute_cmd('port 0 txq %d stop' % queue) > + self.dut_testpmd.execute_cmd('set fwd txonly') > + self.dut_testpmd.execute_cmd('start') > + time.sleep(10) > + out =3D self.dut_testpmd.execute_cmd('stop') > + tx_num =3D qringsize - 1 > + self.verify("TX-packets: %d" % tx_num in out, > + "Fail to stop txq at runtime") > + if chgflag =3D=3D 1: > + chg_qringsize =3D qringsize % 1024 + 256 > + self.dut_testpmd.execute_cmd( > + 'port config 0 txq %d ring_size %d' > + % (queue, chg_qringsize)) > + self.dut_testpmd.execute_cmd('port 0 txq %d setup' % que= ue) > + out =3D self.dut_testpmd.execute_cmd( > + 'show txq info 0 %d' % queue) > + chk_qringsize =3D self.element_strip(out, pattern) > + self.verify(chk_qringsize =3D=3D chg_qringsize, > + "Fail to change ring size at runtime!") > + if chgflag =3D=3D 0: > + self.dut_testpmd.execute_cmd('port 0 txq %d setup' % que= ue) > + self.dut_testpmd.execute_cmd('port 0 txq %d start' % queue) > + self.dut_testpmd.execute_cmd('start') > + time.sleep(10) > + out =3D self.dut_testpmd.execute_cmd('stop') > + self.verify("TX-packets: %d" % tx_num not in out, > + "Fail to setup txq at runtime") Tx stats should be much larger than tx_num, please check that number.=20 > + if chgflag =3D=3D 1: > + chgtx_num =3D chg_qringsize - 1 > + self.verify("TX-packets: %d" % chgtx_num not in out, > + "Fail to change txq ring size at runtime") > + Same as previous comment.=20 > + def test_rxq_setup(self): > + """ > + Dynamic to setup rxq test > + """ > + self.rxq_setup_test() > + > + def test_rxq_chgring_setup(self): > + """ > + Dynamic to setup rxq and change ring size test > + """ > + self.rxq_setup_test(chgflag=3D1) > + > + def test_txq_setup(self): > + """ > + Dynamic to setup txq test > + """ > + self.txq_setup_test() > + > + def test_txq_chgring_setup(self): > + """ > + Dynamic to setup txq and change ring size test > + """ > + self.txq_setup_test(chgflag=3D1) > + > + def tear_down(self): > + self.dut_testpmd.quit() > + > + def tear_down_all(self): > + pass > -- > 2.7.5