From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 816FA2BAA; Mon, 27 Aug 2018 07:27:48 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Aug 2018 22:27:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,293,1531810800"; d="scan'208";a="66217520" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga008.fm.intel.com with ESMTP; 26 Aug 2018 22:27:42 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 26 Aug 2018 22:27:40 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 26 Aug 2018 22:27:40 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.240]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.185]) with mapi id 14.03.0319.002; Mon, 27 Aug 2018 13:27:38 +0800 From: "Liu, Yong" To: dts , "dts@dpdk.org" CC: "nd@arm.com" Thread-Topic: [dts] [PATCH] framework/dut: setup hugepage for all available NUMA nodes Thread-Index: AQHUPbPZN1lJ15W9BkW2yYEL65Uof6TTEN/Q Date: Mon, 27 Aug 2018 05:27:38 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E6312D154@SHSMSX103.ccr.corp.intel.com> References: <1535332589-8090-1-git-send-email-phil.yang@arm.com> In-Reply-To: <1535332589-8090-1-git-send-email-phil.yang@arm.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzk5NDFkMjUtNzBhNS00NjJkLWIzYmYtOTEyNGFhYzgwODc1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoieFgxZGpqNERcLzNjNzZvZkErc0YrYVVzeGtQWkFjUXFFNXdQcEJkVXFFQU9PTlh1RmZuNVNPOTBWSHk5QVFNd0IifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH] framework/dut: setup hugepage for all available NUMA nodes X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2018 05:27:49 -0000 Hi Phil, One comment is inline. Thanks, Marvin > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] > Sent: Monday, August 27, 2018 9:16 AM > To: dts@dpdk.org > Cc: nd@arm.com > Subject: [dts] [PATCH] framework/dut: setup hugepage for all available NU= MA > nodes >=20 > On a NUMA machine, we need to setup hugepage for all NUMA nodes. >=20 > The default approach is by setting /sys/kernel/mm/hugepages, but it > only works on a single-node system. >=20 > This fix needs numactl tool support on Linux. >=20 > Signed-off-by: Phil Yang > --- > framework/crb.py | 6 ++++-- > framework/dut.py | 9 ++++++++- > 2 files changed, 12 insertions(+), 3 deletions(-) >=20 > diff --git a/framework/crb.py b/framework/crb.py > index 5c555db..97bebfe 100644 > --- a/framework/crb.py > +++ b/framework/crb.py > @@ -204,8 +204,10 @@ class Crb(object): > if numa =3D=3D -1: > self.send_expect('echo %d > /sys/kernel/mm/hugepages/hugepag= es- > %skB/nr_hugepages' % (huge_pages, page_size), '# ', 5) > else: > - # sometimes we set hugepage on kernel cmdline, so we need cl= ear > default hugepage > - self.send_expect('echo 0 > /sys/kernel/mm/hugepages/hugepage= s- > %skB/nr_hugepages' % (page_size), '# ', 5) > + # sometimes we set hugepage on kernel cmdline, so we clear a= ll > nodes' default hugepages at the first time. > + if numa =3D=3D 0: > + self.send_expect('echo 0 > > /sys/kernel/mm/hugepages/hugepages-%skB/nr_hugepages' % (page_size), '# '= , 5) > + > # some platform not support numa, example vm dut > try: > self.send_expect('echo %d > > /sys/devices/system/node/node%d/hugepages/hugepages-%skB/nr_hugepages' % > (huge_pages, numa, page_size), '# ', 5) > diff --git a/framework/dut.py b/framework/dut.py > index 18f0b39..b358578 100644 > --- a/framework/dut.py > +++ b/framework/dut.py > @@ -305,6 +305,12 @@ class Dut(Crb): > return > hugepages_size =3D self.send_expect("awk '/Hugepagesize/ {print = $2}' > /proc/meminfo", "# ") > total_huge_pages =3D self.get_total_huge_pages() > + total_numa_nodes =3D self.send_expect("numactl -H | awk '/availa= ble/ > {print $2}'", "# ") We may not expect that numactl is installed on the DUT. It will be more por= table by checking sysfs like "ls /sys/devices/system/node | grep node* | wc= -l". > + numa_service_num =3D > self.get_def_rte_config('CONFIG_RTE_MAX_NUMA_NODES') > + if numa_service_num: > + numa =3D min(total_numa_nodes, numa_service_num) > + else: > + numa =3D total_numa_nodes > force_socket =3D False >=20 > if int(hugepages_size) < (1024 * 1024): > @@ -332,7 +338,8 @@ class Dut(Crb): > if force_socket: > self.set_huge_pages(arch_huge_pages, 0) > else: > - self.set_huge_pages(arch_huge_pages) > + for numa_id in range(0, int(numa)): > + self.set_huge_pages(arch_huge_pages, numa_id) >=20 > self.mount_huge_pages() > self.hugepage_path =3D self.strip_hugepage_path() > -- > 2.7.4