test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Li, WenjieX A" <wenjiex.a.li@intel.com>
To: "Liu, Yong" <yong.liu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH V1] short_live/clean_up_with_signal_testpmd: the	expected return value of send_expect is incorrect on Suse12
Date: Thu, 2 Aug 2018 08:37:38 +0000	[thread overview]
Message-ID: <8688172CD5C0B74590FAE19D9579F94B53567E92@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <86228AFD5BCD8E4EBFD2B90117B5E81E63104F11@SHSMSX103.ccr.corp.intel.com>

After change the dpdk driver name to "igb_uio" on Suse12, the return value is correct . So please ignore this patch. Thank you!

-----Original Message-----
From: Liu, Yong 
Sent: Thursday, August 2, 2018 1:07 PM
To: Li, WenjieX A <wenjiex.a.li@intel.com>; dts@dpdk.org
Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
Subject: RE: [dts] [PATCH V1] short_live/clean_up_with_signal_testpmd: the expected return value of send_expect is incorrect on Suse12

Hi Wenjie,
I think there maybe one issue on Suse12, LSC event should be available for all OSs.
Could you please explain that what happened on Suse12? 

Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of wenjieli
> Sent: Thursday, August 02, 2018 11:22 AM
> To: dts@dpdk.org
> Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
> Subject: [dts] [PATCH V1] short_live/clean_up_with_signal_testpmd: the 
> expected return value of send_expect is incorrect on Suse12
> 
> In test_clean_up_with_signal_testpmd():
> 1. change the return value from "LSC event" to "testpmd>", since on 
> Suse12 the testpmd failed to start when using "LSC event"
> 2. wait 5 seconds to ensure that testpmd is ready before the DUT sends 
> packets
> 
> Signed-off-by: wenjieli <wenjiex.a.li@intel.com>
> ---
>  tests/TestSuite_short_live.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_short_live.py 
> b/tests/TestSuite_short_live.py index 238e3ab..d65dc6b 100644
> --- a/tests/TestSuite_short_live.py
> +++ b/tests/TestSuite_short_live.py
> @@ -151,10 +151,11 @@ class TestShortLiveApp(TestCase):
>          for i in range(repeat_time):
>              #dpdk start
>              print "clean_up_with_signal_testpmd round %d" % (i + 1)
> -            self.dut.send_expect("./%s/app/testpmd -c 0xf -n 4 -- -i --
> portmask=0x3" % self.target, "LSC event", 120)
> +            self.dut.send_expect("./%s/app/testpmd -c 0xf -n 4 -- -i 
> + --
> portmask=0x3" % self.target, "testpmd>", 120)
>              self.dut.send_expect("set fwd mac", "testpmd>")
>              self.dut.send_expect("set promisc all off", "testpmd>")
>              self.dut.send_expect("start", "testpmd>")
> +            time.sleep(5)
>              self.check_forwarding([0, 1], self.nic)
> 
>              # kill with differen Signal
> --
> 1.9.3

      reply	other threads:[~2018-08-02  8:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-02  3:21 wenjieli
2018-08-02  5:07 ` Liu, Yong
2018-08-02  8:37   ` Li, WenjieX A [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8688172CD5C0B74590FAE19D9579F94B53567E92@SHSMSX103.ccr.corp.intel.com \
    --to=wenjiex.a.li@intel.com \
    --cc=dts@dpdk.org \
    --cc=yong.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).