[dts] [PATCH V1] short_live/clean_up_with_signal_testpmd: the expected return value of send_expect is incorrect on Suse12

[dts] [PATCH V1] short_live/clean_up_with_signal_testpmd: the expected return value of send_expect is incorrect on Suse12

[wenjieli]

In test_clean_up_with_signal_testpmd():
1. change the return value from "LSC event" to "testpmd>", since on Suse12 the testpmd failed to start when using "LSC event"
2. wait 5 seconds to ensure that testpmd is ready before the DUT sends packets

Signed-off-by: wenjieli <wenjiex.a.li@intel.com>
---
 tests/TestSuite_short_live.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_short_live.py b/tests/TestSuite_short_live.py
index 238e3ab..d65dc6b 100644
--- a/tests/TestSuite_short_live.py
+++ b/tests/TestSuite_short_live.py
@@ -151,10 +151,11 @@ class TestShortLiveApp(TestCase):
         for i in range(repeat_time):
             #dpdk start
             print "clean_up_with_signal_testpmd round %d" % (i + 1)
-            self.dut.send_expect("./%s/app/testpmd -c 0xf -n 4 -- -i --portmask=0x3" % self.target, "LSC event", 120)
+            self.dut.send_expect("./%s/app/testpmd -c 0xf -n 4 -- -i --portmask=0x3" % self.target, "testpmd>", 120)
             self.dut.send_expect("set fwd mac", "testpmd>")
             self.dut.send_expect("set promisc all off", "testpmd>")
             self.dut.send_expect("start", "testpmd>")
+            time.sleep(5)
             self.check_forwarding([0, 1], self.nic)
 
             # kill with differen Signal
-- 
1.9.3

Re: [dts] [PATCH V1] short_live/clean_up_with_signal_testpmd: the expected return value of send_expect is incorrect on Suse12

[Liu, Yong]

Hi Wenjie,
I think there maybe one issue on Suse12, LSC event should be available for all OSs.
Could you please explain that what happened on Suse12? 

Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of wenjieli
> Sent: Thursday, August 02, 2018 11:22 AM
> To: dts@dpdk.org
> Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
> Subject: [dts] [PATCH V1] short_live/clean_up_with_signal_testpmd: the
> expected return value of send_expect is incorrect on Suse12
> 
> In test_clean_up_with_signal_testpmd():
> 1. change the return value from "LSC event" to "testpmd>", since on Suse12
> the testpmd failed to start when using "LSC event"
> 2. wait 5 seconds to ensure that testpmd is ready before the DUT sends
> packets
> 
> Signed-off-by: wenjieli <wenjiex.a.li@intel.com>
> ---
>  tests/TestSuite_short_live.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_short_live.py b/tests/TestSuite_short_live.py
> index 238e3ab..d65dc6b 100644
> --- a/tests/TestSuite_short_live.py
> +++ b/tests/TestSuite_short_live.py
> @@ -151,10 +151,11 @@ class TestShortLiveApp(TestCase):
>          for i in range(repeat_time):
>              #dpdk start
>              print "clean_up_with_signal_testpmd round %d" % (i + 1)
> -            self.dut.send_expect("./%s/app/testpmd -c 0xf -n 4 -- -i --
> portmask=0x3" % self.target, "LSC event", 120)
> +            self.dut.send_expect("./%s/app/testpmd -c 0xf -n 4 -- -i --
> portmask=0x3" % self.target, "testpmd>", 120)
>              self.dut.send_expect("set fwd mac", "testpmd>")
>              self.dut.send_expect("set promisc all off", "testpmd>")
>              self.dut.send_expect("start", "testpmd>")
> +            time.sleep(5)
>              self.check_forwarding([0, 1], self.nic)
> 
>              # kill with differen Signal
> --
> 1.9.3

Re: [dts] [PATCH V1] short_live/clean_up_with_signal_testpmd: the expected return value of send_expect is incorrect on Suse12

[Li, WenjieX A]

After change the dpdk driver name to "igb_uio" on Suse12, the return value is correct . So please ignore this patch. Thank you!

-----Original Message-----
From: Liu, Yong 
Sent: Thursday, August 2, 2018 1:07 PM
To: Li, WenjieX A <wenjiex.a.li@intel.com>; dts@dpdk.org
Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
Subject: RE: [dts] [PATCH V1] short_live/clean_up_with_signal_testpmd: the expected return value of send_expect is incorrect on Suse12

Hi Wenjie,
I think there maybe one issue on Suse12, LSC event should be available for all OSs.
Could you please explain that what happened on Suse12? 

Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of wenjieli
> Sent: Thursday, August 02, 2018 11:22 AM
> To: dts@dpdk.org
> Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
> Subject: [dts] [PATCH V1] short_live/clean_up_with_signal_testpmd: the 
> expected return value of send_expect is incorrect on Suse12
> 
> In test_clean_up_with_signal_testpmd():
> 1. change the return value from "LSC event" to "testpmd>", since on 
> Suse12 the testpmd failed to start when using "LSC event"
> 2. wait 5 seconds to ensure that testpmd is ready before the DUT sends 
> packets
> 
> Signed-off-by: wenjieli <wenjiex.a.li@intel.com>
> ---
>  tests/TestSuite_short_live.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_short_live.py 
> b/tests/TestSuite_short_live.py index 238e3ab..d65dc6b 100644
> --- a/tests/TestSuite_short_live.py
> +++ b/tests/TestSuite_short_live.py
> @@ -151,10 +151,11 @@ class TestShortLiveApp(TestCase):
>          for i in range(repeat_time):
>              #dpdk start
>              print "clean_up_with_signal_testpmd round %d" % (i + 1)
> -            self.dut.send_expect("./%s/app/testpmd -c 0xf -n 4 -- -i --
> portmask=0x3" % self.target, "LSC event", 120)
> +            self.dut.send_expect("./%s/app/testpmd -c 0xf -n 4 -- -i 
> + --
> portmask=0x3" % self.target, "testpmd>", 120)
>              self.dut.send_expect("set fwd mac", "testpmd>")
>              self.dut.send_expect("set promisc all off", "testpmd>")
>              self.dut.send_expect("start", "testpmd>")
> +            time.sleep(5)
>              self.check_forwarding([0, 1], self.nic)
> 
>              # kill with differen Signal
> --
> 1.9.3