From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E2513A046B for ; Mon, 19 Aug 2019 12:17:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B0F651BE81; Mon, 19 Aug 2019 12:17:35 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 437501B994 for ; Mon, 19 Aug 2019 12:17:34 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Aug 2019 03:17:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,403,1559545200"; d="scan'208";a="172082568" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga008.jf.intel.com with ESMTP; 19 Aug 2019 03:17:03 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 19 Aug 2019 03:17:03 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.139]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.80]) with mapi id 14.03.0439.000; Mon, 19 Aug 2019 18:17:01 +0800 From: "Li, WenjieX A" To: "dts@dpdk.org" CC: "Li, WenjieX A" Thread-Topic: [dts][PATCH V1] tests/enable_package_download_in_ice_driver:add all ports with -w Thread-Index: AQHVVnb7rHHeaiB/IUyOHR1BfytxfqcCQXkA Date: Mon, 19 Aug 2019 10:17:01 +0000 Message-ID: <8688172CD5C0B74590FAE19D9579F94B537762CE@SHSMSX103.ccr.corp.intel.com> References: <1566241756-5557-1-git-send-email-wenjiex.a.li@intel.com> In-Reply-To: <1566241756-5557-1-git-send-email-wenjiex.a.li@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] tests/enable_package_download_in_ice_driver:add all ports with -w X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Tested-by: Li, WenjieX A > -----Original Message----- > From: Li, WenjieX A > Sent: Tuesday, August 20, 2019 3:09 AM > To: dts@dpdk.org > Cc: Li, WenjieX A > Subject: [dts][PATCH V1] tests/enable_package_download_in_ice_driver:add = all > ports with -w >=20 > Should add ALL ports with -w parameter. > If the nic has 4 ports, all ports should be bind with -w; otherwise, the = ports will > be down in testpmd. >=20 > Signed-off-by: Wenjie Li > --- > tests/TestSuite_enable_package_download_in_ice_driver.py | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) >=20 > diff --git a/tests/TestSuite_enable_package_download_in_ice_driver.py > b/tests/TestSuite_enable_package_download_in_ice_driver.py > index 9197198..b225ef3 100644 > --- a/tests/TestSuite_enable_package_download_in_ice_driver.py > +++ b/tests/TestSuite_enable_package_download_in_ice_driver.py > @@ -54,9 +54,6 @@ class > TestEnable_Package_Download_In_Ice_Driver(TestCase): > self.tester_p0_mac =3D self.tester.get_mac(localPort0) > self.dut_testpmd =3D PmdOutput(self.dut) >=20 > - self.dut_p0_pci =3D self.dut.get_port_pci(self.dut_ports[0]) > - self.dut_p1_pci =3D self.dut.get_port_pci(self.dut_ports[1]) > - > self.pkg_file =3D '/lib/firmware/intel/ice/ddp/ice.pkg' > out =3D self.dut.send_expect("ls %s" % self.pkg_file, "#") > self.verify("No such file or directory" not in out, "Cannot find= %s, please > check you system/driver." % self.pkg_file) @@ -88,10 +85,10 @@ class > TestEnable_Package_Download_In_Ice_Driver(TestCase): > self.dut.send_expect("touch %s" % self.pkg_file, "#") >=20 > def start_testpmd(self, ice_pkg=3D"true", safe_mode_support=3D"false= "): > + self.eal_param =3D "" > if safe_mode_support =3D=3D "true": > - self.eal_param=3D"-w %s,safe-mode-support=3D1 -w %s,safe-mod= e- > support=3D1" % (self.dut_p0_pci, self.dut_p1_pci) > - else: > - self.eal_param=3D"" > + for i in range(len(self.dut_ports)): > + self.eal_param =3D self.eal_param + "-w > + %s,safe-mode-support=3D1 " % self.dut.ports_info[i]['pci'] > out =3D self.dut_testpmd.start_testpmd("all", "--nb-cores=3D8 --= rxq=3D%s -- > txq=3D%s --port-topology=3Dchained" % (self.PF_QUEUE, self.PF_QUEUE), > eal_param=3Dself.eal_param) > if ice_pkg =3D=3D "false": > if safe_mode_support =3D=3D "true": > -- > 2.17.1