Re: [dts] [PATCH V1] tests/TestSuite_ipgre.py: Tear_down func increase kill testpmd statement. check_packet_transmission func exiting abnormally willcause testpmd to not exit. The next test case continues to use untested testpmd, causing the test case to

["Li, WenjieX A" <wenjiex.a.li@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1906 bytes --]

FYI

> -----Original Message-----
> From: Mo, YufengX
> Sent: Monday, September 16, 2019 4:32 PM
> To: dts@dpdk.org; Peng, ZhihongX <zhihongx.peng@intel.com>; Li, WenjieX A
> <wenjiex.a.li@intel.com>; Zhang, YanX A <yanx.a.zhang@intel.com>
> Cc: Yu, PingX <pingx.yu@intel.com>
> Subject: RE: [dts] [PATCH V1] tests/TestSuite_ipgre.py: Tear_down func increase
> kill testpmd statement. check_packet_transmission func exiting abnormally
> willcause testpmd to not exit. The next test case continues to use untested
> testpmd, causing the test case to
> 
> Hi, peng zhihong
> 
> Li,wenjie has one patch to do the same thing. Could you sync with him?
> 
> [dts] [PATCH V1] tests/ipgre: optimize script
> 
> BRs
> Yufen, Mo
> 
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Peng Zhihong
> > Sent: Monday, September 16, 2019 10:10 PM
> > To: dts@dpdk.org
> > Cc: Peng, ZhihongX <zhihongx.peng@intel.com>; Peng@dpdk.org
> > Subject: [dts] [PATCH V1] tests/TestSuite_ipgre.py: Tear_down func
> > increase kill testpmd statement. check_packet_transmission func exiting
> abnormally willcause testpmd to not exit. The next test case continues to use
> untested testpmd, causing the test case to f...
> >
> > From: "Peng, ZhihongX" <zhihongx.peng@intel.com>
> >
> > Signed-off-by: Peng, ZhihongX <zhihongx.peng@intel.com>
> > ---
> >  tests/TestSuite_ipgre.py | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/TestSuite_ipgre.py b/tests/TestSuite_ipgre.py index
> > d74ac05..d1db8df 100644
> > --- a/tests/TestSuite_ipgre.py
> > +++ b/tests/TestSuite_ipgre.py
> > @@ -439,6 +439,7 @@ class TestIpgre(TestCase):
> >          Run after each test case.
> >          Nothing to do.
> >          """
> > +        self.dut.kill_all()
> >          pass
> >
> >      def tear_down_all(self):
> > --
> > 2.17.1


[-- Attachment #2: Type: message/rfc822, Size: 2990 bytes --]

From: "Li, WenjieX A" <wenjiex.a.li@intel.com>
To: "dts@dpdk.org" <dts@dpdk.org>
Cc: "Li, WenjieX A" <wenjiex.a.li@intel.com>
Subject: [dts][PATCH V1] tests/ipgre: optimize script
Date: Fri, 6 Sep 2019 18:42:30 +0000
Message-ID: <1567795350-70617-1-git-send-email-wenjiex.a.li@intel.com>

1. could support cvl nic, add cvl to nic list
2. move dut.kill_all from tear_down_all to tear_down, since testpmd will
be started in every case, if one case is failed, the testpmd is still
runnning, this will affect the following cases.

Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
---
 tests/TestSuite_ipgre.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/tests/TestSuite_ipgre.py b/tests/TestSuite_ipgre.py
index 7fbddf1..e10b0e0 100644
--- a/tests/TestSuite_ipgre.py
+++ b/tests/TestSuite_ipgre.py
@@ -63,7 +63,7 @@ class TestIpgre(TestCase):
         """
         self.printFlag = self._enable_debug
         ports = self.dut.get_ports()
-        self.verify(self.nic in ["fortville_eagle", "fortville_spirit", "fortville_spirit_single", "fortville_25g", "carlsville"],
+        self.verify(self.nic in ["fortville_eagle", "fortville_spirit", "fortville_spirit_single", "fortville_25g", "carlsville", "columbiaville_25g", "columbiaville_100g"],
                     "GRE tunnel packet type only support by fortville and carlsville")
         self.verify(len(ports) >= 1, "Insufficient ports for testing")
         valports = [_ for _ in ports if self.tester.get_local_port(_) != -1]
@@ -439,12 +439,11 @@ class TestIpgre(TestCase):
         Run after each test case.
         Nothing to do.
         """
-        pass
+        self.dut.kill_all()

     def tear_down_all(self):
         """
         Run after each test suite.
         Nothing to do.
         """
-        self.dut.kill_all()
         pass
--
2.17.1