test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Li, WenjieX A" <wenjiex.a.li@intel.com>
To: "dts@dpdk.org" <dts@dpdk.org>
Cc: "Li, WenjieX A" <wenjiex.a.li@intel.com>
Subject: Re: [dts] [PATCH V1] tests/interrupt_pmd: reduce the execution time
Date: Tue, 26 Nov 2019 08:34:05 +0000	[thread overview]
Message-ID: <8688172CD5C0B74590FAE19D9579F94B537EFB13@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1574788723-61123-1-git-send-email-wenjiex.a.li@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1880 bytes --]

Tested-by: Li, WenjieX A <wenjiex.a.li@intel.com>

> -----Original Message-----
> From: Li, WenjieX A
> Sent: Wednesday, November 27, 2019 1:19 AM
> To: dts@dpdk.org
> Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
> Subject: [dts][PATCH V1] tests/interrupt_pmd: reduce the execution time
> 
> It is unnecessary to start/close scapy when sending every packet.
> The execution time could be reduced to 1 minute from 9.
> 
> Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
> ---
>  tests/TestSuite_interrupt_pmd.py | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/TestSuite_interrupt_pmd.py
> b/tests/TestSuite_interrupt_pmd.py
> index a0467bd..4e99cf4 100644
> --- a/tests/TestSuite_interrupt_pmd.py
> +++ b/tests/TestSuite_interrupt_pmd.py
> @@ -106,19 +106,20 @@ class TestInterruptPmd(TestCase):
>          """
>          Send a packet to port
>          """
> +        self.tester.send_expect("scapy", ">>>", 30)
>          for i in range(len(self.dut_ports[:portnum])):
>              for j in range(num):
>                  txport = self.tester.get_local_port(self.dut_ports[i])
>                  mac = self.dut.get_mac_address(self.dut_ports[i])
>                  txItf = self.tester.get_interface(txport)
> -                self.tester.scapy_append(
> -                    'sendp([Ether()/IP(dst="198.0.0.%d")/UDP()/Raw(\'X\'*18)],
> iface="%s")' % (j, txItf))
> -                self.tester.scapy_execute()
> +
> self.tester.send_expect('sendp([Ether()/IP(dst="198.0.0.%d")/UDP()/Raw(\'X\'*1
> 8)], iface="%s")' % (j, txItf), ">>>")
> +        self.tester.send_expect("quit()", "#", 30)
> 
>      def tear_down(self):
>          """
>          Run after each test case.
>          """
> +        self.dut.kill_all()
>          pass
> 
>      def tear_down_all(self):
> --
> 2.17.1


[-- Attachment #2: TestInterruptPmd.log --]
[-- Type: application/octet-stream, Size: 60586 bytes --]

  reply	other threads:[~2019-11-26  8:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-26 17:18 Wenjie Li
2019-11-26  8:34 ` Li, WenjieX A [this message]
2019-11-27  8:53 ` Ma, LihongX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8688172CD5C0B74590FAE19D9579F94B537EFB13@SHSMSX103.ccr.corp.intel.com \
    --to=wenjiex.a.li@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).