From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 9CCC644BE for ; Mon, 22 Oct 2018 04:28:52 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Oct 2018 19:28:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,410,1534834800"; d="scan'208";a="274399304" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga006.fm.intel.com with ESMTP; 21 Oct 2018 19:28:50 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 21 Oct 2018 19:28:50 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 21 Oct 2018 19:28:49 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.46]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.21]) with mapi id 14.03.0319.002; Mon, 22 Oct 2018 10:28:47 +0800 From: "Tu, Lijuan" To: "Li, WenjieX A" , "dts@dpdk.org" CC: "Li, WenjieX A" Thread-Topic: [dts] [PATCH V1] shutdown_api/reconfigure_ports: change DEV_RX_OFFLOAD_CRC_STRIP from 0x1000 to 0x0 Thread-Index: AQHUZPsSkdQrIh0NoEuAq3bnp7E+9qUqkIzw Date: Mon, 22 Oct 2018 02:28:47 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0B9911FD@SHSMSX101.ccr.corp.intel.com> References: <1539658413-5656-1-git-send-email-wenjiex.a.li@intel.com> In-Reply-To: <1539658413-5656-1-git-send-email-wenjiex.a.li@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjY0MGYyMTAtMDU1Mi00ZDRkLTllOWItODJjNTQ2NWI4MWMyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWldHVUxEVEJFMHdRcG9XcWkxZXh5TUNtTXFRNFNmcDNPTVpuZ0J5ZjZOXC95RTVYc0wySGtyQnlzc21jc3NHc0kifQ== x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] shutdown_api/reconfigure_ports: change DEV_RX_OFFLOAD_CRC_STRIP from 0x1000 to 0x0 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Oct 2018 02:28:53 -0000 We just need check crc strip bit, no need to check other offloads. If crc strip enabled, we just check bit 12 is 0, else bit 12 is 1. We don't= care about bit 0~11 Moreover, we cannot force the other bits to be 0. Now the other bits are 0,= but someday they may be changed to 1. > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of wenjieli > Sent: Tuesday, October 16, 2018 10:54 AM > To: dts@dpdk.org > Cc: Li, WenjieX A > Subject: [dts] [PATCH V1] shutdown_api/reconfigure_ports: change > DEV_RX_OFFLOAD_CRC_STRIP from 0x1000 to 0x0 >=20 > "#define DEV_RX_OFFLOAD_CRC_STRIP 0x00001000" was removed from > dpdk/lib/librte_ethdev/rte_ethdev.h since 33e7b667f18376c603512, the > expected DEV_RX_OFFLOAD_CRC_STRIP value changed to 0x0; update > testsuit for this changement. >=20 > Signed-off-by: wenjieli > --- > tests/TestSuite_shutdown_api.py | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/tests/TestSuite_shutdown_api.py > b/tests/TestSuite_shutdown_api.py index 52a8fbf..0f8436b 100644 > --- a/tests/TestSuite_shutdown_api.py > +++ b/tests/TestSuite_shutdown_api.py > @@ -263,18 +263,18 @@ class TestShutdownApi(TestCase): > """ > Reconfigure All Ports With The Same Configurations (CRC) > """ > + DEV_RX_OFFLOAD_KEEP_CRC=3D"0x10000" > + DEV_RX_OFFLOAD_CRC_STRIP=3D"0x0" > self.pmdout.start_testpmd("Default", "--portmask=3D%s > --port-topology=3Dloop --disable-crc-strip" % utils.create_mask(self.port= s), > socket=3Dself.ports_socket) > out =3D self.dut.send_expect("show config rxtx", "testpmd> ") > - self.verify( > - "Rx offloads=3D0x10000" in out, "CRC keeping not enabled > properly") > + self.verify("Rx offloads=3D%s" % DEV_RX_OFFLOAD_KEEP_CRC in > out, > + "CRC keeping not enabled properly") >=20 > self.dut.send_expect("port stop all", "testpmd> ", 100) > self.dut.send_expect("port config all crc-strip on", "testpmd> "= ) > self.dut.send_expect("set fwd mac", "testpmd>") > self.dut.send_expect("port start all", "testpmd> ", 100) > out =3D self.dut.send_expect("show config rxtx", "testpmd> ") > - self.verify( > - "Rx offloads=3D0x1000" in out, "CRC stripping not enabled > properly") > + self.verify("Rx offloads=3D%s" % DEV_RX_OFFLOAD_CRC_STRIP in > out, [Lijuan]Only check crc strip bit here, don't check other bit. if Rx offload= s=3D0xe111, it also should pass in the case. > + "CRC stripping not enabled properly") > self.dut.send_expect("start", "testpmd> ") > self.check_forwarding() >=20 > -- > 2.17.2