From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Yao, BingX Y" <bingx.y.yao@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Yao, BingX Y" <bingx.y.yao@intel.com>
Subject: Re: [dts] [PATCH V1] tests/hotplug:detach_port function changes with dpdk
Date: Mon, 5 Nov 2018 07:53:42 +0000 [thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0B9B7F08@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1541396425-24149-1-git-send-email-bingx.y.yao@intel.com>
I think "Port not stop" is a remainder, it means please stop port firstly and then detach.
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of yaobing
> Sent: Monday, November 5, 2018 1:40 PM
> To: dts@dpdk.org
> Cc: Yao, BingX Y <bingx.y.yao@intel.com>
> Subject: [dts] [PATCH V1] tests/hotplug:detach_port function changes with
> dpdk
>
> detach_port function changes with dpdk, its print was changed from 'Please
> close port first' to 'Port not stopped'
>
> Signed-off-by: yaobing <bingx.y.yao@intel.com>
> ---
> tests/TestSuite_hotplug.py | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/TestSuite_hotplug.py b/tests/TestSuite_hotplug.py index
> 7d63b71..5528a22 100644
> --- a/tests/TestSuite_hotplug.py
> +++ b/tests/TestSuite_hotplug.py
> @@ -101,13 +101,13 @@ class TestPortHotPlug(TestCase):
> self.dut.close_session(session_secondary)
> self.attach(self.port)
> self.dut.send_expect("start","testpmd>",60)
> - self.dut.send_expect("port detach %s" % self.port,"Please close
> port first",60)
> + self.dut.send_expect("port detach %s" % self.port,"Port not
> + stopped",60)
> self.dut.send_expect("stop","testpmd>",60)
> self.detach(self.port)
> self.attach(self.port)
>
> self.dut.send_expect("start","testpmd>",60)
> - self.dut.send_expect("port detach %s" % self.port,"Please close
> port first",60)
> + self.dut.send_expect("port detach %s" % self.port,"Port not
> + stopped",60)
> self.dut.send_expect("clear port stats %s" %
> self.port ,"testpmd>",60)
> self.send_packet(self.port)
> out = self.dut.send_expect("show port stats %s" %
> self.port ,"testpmd>",60) @@ -140,7 +140,7 @@ class
> TestPortHotPlug(TestCase):
> self.attach(self.port)
>
> self.dut.send_expect("start","testpmd>",60)
> - self.dut.send_expect("port detach %s" % self.port, "Please close
> port first",60)
> + self.dut.send_expect("port detach %s" % self.port, "Port not
> + stopped",60)
> self.dut.send_expect("clear port stats %s" %
> self.port ,"testpmd>",60)
> self.send_packet(self.port)
> out = self.dut.send_expect("show port stats %s" %
> self.port ,"testpmd>",60)
> --
> 2.17.2
prev parent reply other threads:[~2018-11-05 7:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 5:40 yaobing
2018-11-05 7:53 ` Tu, Lijuan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0B9B7F08@SHSMSX101.ccr.corp.intel.com \
--to=lijuan.tu@intel.com \
--cc=bingx.y.yao@intel.com \
--cc=dts@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).