test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] tests/hotplug:detach_port function changes with dpdk
@ 2018-11-05  5:40 yaobing
  2018-11-05  7:53 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: yaobing @ 2018-11-05  5:40 UTC (permalink / raw)
  To: dts; +Cc: yaobing

detach_port function changes with dpdk, its print was changed from
'Please close port first' to 'Port not stopped'

Signed-off-by: yaobing <bingx.y.yao@intel.com>
---
 tests/TestSuite_hotplug.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/TestSuite_hotplug.py b/tests/TestSuite_hotplug.py
index 7d63b71..5528a22 100644
--- a/tests/TestSuite_hotplug.py
+++ b/tests/TestSuite_hotplug.py
@@ -101,13 +101,13 @@ class TestPortHotPlug(TestCase):
         self.dut.close_session(session_secondary)
         self.attach(self.port)
         self.dut.send_expect("start","testpmd>",60)
-        self.dut.send_expect("port detach %s" % self.port,"Please close port first",60)
+        self.dut.send_expect("port detach %s" % self.port,"Port not stopped",60)
         self.dut.send_expect("stop","testpmd>",60)
         self.detach(self.port)
         self.attach(self.port)
    
         self.dut.send_expect("start","testpmd>",60)
-        self.dut.send_expect("port detach %s" % self.port,"Please close port first",60)
+        self.dut.send_expect("port detach %s" % self.port,"Port not stopped",60)
         self.dut.send_expect("clear port stats %s" % self.port ,"testpmd>",60)
         self.send_packet(self.port)
         out = self.dut.send_expect("show port stats %s" % self.port ,"testpmd>",60)
@@ -140,7 +140,7 @@ class TestPortHotPlug(TestCase):
         self.attach(self.port)
 
         self.dut.send_expect("start","testpmd>",60)
-        self.dut.send_expect("port detach %s" % self.port, "Please close port first",60)
+        self.dut.send_expect("port detach %s" % self.port, "Port not stopped",60)
         self.dut.send_expect("clear port stats %s" % self.port ,"testpmd>",60)
         self.send_packet(self.port)
         out = self.dut.send_expect("show port stats %s" % self.port ,"testpmd>",60)
-- 
2.17.2

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V1] tests/hotplug:detach_port function changes with dpdk
  2018-11-05  5:40 [dts] [PATCH V1] tests/hotplug:detach_port function changes with dpdk yaobing
@ 2018-11-05  7:53 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2018-11-05  7:53 UTC (permalink / raw)
  To: Yao, BingX Y, dts; +Cc: Yao, BingX Y

I think "Port not stop" is a remainder, it means please stop port firstly and then detach.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of yaobing
> Sent: Monday, November 5, 2018 1:40 PM
> To: dts@dpdk.org
> Cc: Yao, BingX Y <bingx.y.yao@intel.com>
> Subject: [dts] [PATCH V1] tests/hotplug:detach_port function changes with
> dpdk
> 
> detach_port function changes with dpdk, its print was changed from 'Please
> close port first' to 'Port not stopped'
> 
> Signed-off-by: yaobing <bingx.y.yao@intel.com>
> ---
>  tests/TestSuite_hotplug.py | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/TestSuite_hotplug.py b/tests/TestSuite_hotplug.py index
> 7d63b71..5528a22 100644
> --- a/tests/TestSuite_hotplug.py
> +++ b/tests/TestSuite_hotplug.py
> @@ -101,13 +101,13 @@ class TestPortHotPlug(TestCase):
>          self.dut.close_session(session_secondary)
>          self.attach(self.port)
>          self.dut.send_expect("start","testpmd>",60)
> -        self.dut.send_expect("port detach %s" % self.port,"Please close
> port first",60)
> +        self.dut.send_expect("port detach %s" % self.port,"Port not
> + stopped",60)
>          self.dut.send_expect("stop","testpmd>",60)
>          self.detach(self.port)
>          self.attach(self.port)
> 
>          self.dut.send_expect("start","testpmd>",60)
> -        self.dut.send_expect("port detach %s" % self.port,"Please close
> port first",60)
> +        self.dut.send_expect("port detach %s" % self.port,"Port not
> + stopped",60)
>          self.dut.send_expect("clear port stats %s" %
> self.port ,"testpmd>",60)
>          self.send_packet(self.port)
>          out = self.dut.send_expect("show port stats %s" %
> self.port ,"testpmd>",60) @@ -140,7 +140,7 @@ class
> TestPortHotPlug(TestCase):
>          self.attach(self.port)
> 
>          self.dut.send_expect("start","testpmd>",60)
> -        self.dut.send_expect("port detach %s" % self.port, "Please close
> port first",60)
> +        self.dut.send_expect("port detach %s" % self.port, "Port not
> + stopped",60)
>          self.dut.send_expect("clear port stats %s" %
> self.port ,"testpmd>",60)
>          self.send_packet(self.port)
>          out = self.dut.send_expect("show port stats %s" %
> self.port ,"testpmd>",60)
> --
> 2.17.2

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-11-05  7:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-05  5:40 [dts] [PATCH V1] tests/hotplug:detach_port function changes with dpdk yaobing
2018-11-05  7:53 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).