From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 508DB5398 for ; Mon, 5 Nov 2018 08:53:48 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Nov 2018 23:53:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,467,1534834800"; d="scan'208";a="103459274" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 04 Nov 2018 23:53:45 -0800 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 4 Nov 2018 23:53:45 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 4 Nov 2018 23:53:45 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.102]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.161]) with mapi id 14.03.0415.000; Mon, 5 Nov 2018 15:53:43 +0800 From: "Tu, Lijuan" To: "Yao, BingX Y" , "dts@dpdk.org" CC: "Yao, BingX Y" Thread-Topic: [dts] [PATCH V1] tests/hotplug:detach_port function changes with dpdk Thread-Index: AQHUdMmsEq1oj0ebiUy+6mL8rbIcG6VAz1eQ Date: Mon, 5 Nov 2018 07:53:42 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0B9B7F08@SHSMSX101.ccr.corp.intel.com> References: <1541396425-24149-1-git-send-email-bingx.y.yao@intel.com> In-Reply-To: <1541396425-24149-1-git-send-email-bingx.y.yao@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNmM5MjdjNzItMTIzYy00M2U0LWI5YzMtMTUwNDE3YmY3MzQ1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicWV1a0hkMFRTQ1RxZGlRTE5XVGJvUzFoV0IxQ1wvaDRibjhJeDIwMjVFNmhKaXdnY1NKcTZRNzNJZ3hxcUxyQWMifQ== x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] tests/hotplug:detach_port function changes with dpdk X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Nov 2018 07:53:48 -0000 I think "Port not stop" is a remainder, it means please stop port firstly a= nd then detach. > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of yaobing > Sent: Monday, November 5, 2018 1:40 PM > To: dts@dpdk.org > Cc: Yao, BingX Y > Subject: [dts] [PATCH V1] tests/hotplug:detach_port function changes with > dpdk >=20 > detach_port function changes with dpdk, its print was changed from 'Pleas= e > close port first' to 'Port not stopped' >=20 > Signed-off-by: yaobing > --- > tests/TestSuite_hotplug.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/tests/TestSuite_hotplug.py b/tests/TestSuite_hotplug.py inde= x > 7d63b71..5528a22 100644 > --- a/tests/TestSuite_hotplug.py > +++ b/tests/TestSuite_hotplug.py > @@ -101,13 +101,13 @@ class TestPortHotPlug(TestCase): > self.dut.close_session(session_secondary) > self.attach(self.port) > self.dut.send_expect("start","testpmd>",60) > - self.dut.send_expect("port detach %s" % self.port,"Please close > port first",60) > + self.dut.send_expect("port detach %s" % self.port,"Port not > + stopped",60) > self.dut.send_expect("stop","testpmd>",60) > self.detach(self.port) > self.attach(self.port) >=20 > self.dut.send_expect("start","testpmd>",60) > - self.dut.send_expect("port detach %s" % self.port,"Please close > port first",60) > + self.dut.send_expect("port detach %s" % self.port,"Port not > + stopped",60) > self.dut.send_expect("clear port stats %s" % > self.port ,"testpmd>",60) > self.send_packet(self.port) > out =3D self.dut.send_expect("show port stats %s" % > self.port ,"testpmd>",60) @@ -140,7 +140,7 @@ class > TestPortHotPlug(TestCase): > self.attach(self.port) >=20 > self.dut.send_expect("start","testpmd>",60) > - self.dut.send_expect("port detach %s" % self.port, "Please close > port first",60) > + self.dut.send_expect("port detach %s" % self.port, "Port not > + stopped",60) > self.dut.send_expect("clear port stats %s" % > self.port ,"testpmd>",60) > self.send_packet(self.port) > out =3D self.dut.send_expect("show port stats %s" % > self.port ,"testpmd>",60) > -- > 2.17.2