From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Zhu, WenhuiX" <wenhuix.zhu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Zhu, WenhuiX" <wenhuix.zhu@intel.com>
Subject: Re: [dts] [PATCH V1] kni/ethtool delete ethtool -a during the running process
Date: Wed, 7 Nov 2018 10:07:52 +0000 [thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0B9B99A9@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1541573335-29570-1-git-send-email-wenhuix.zhu@intel.com>
It's not a good option to remove these operation. Snice kernel 4.19 changes ethtool_ops, but that does not mean we can't support the kernel version lower than 4.19.
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhuwenhui
> Sent: Wednesday, November 7, 2018 2:49 PM
> To: dts@dpdk.org
> Cc: Zhu, WenhuiX <wenhuix.zhu@intel.com>
> Subject: [dts] [PATCH V1] kni/ethtool delete ethtool -a during the running
> process
>
>
> KNI, when ethtool support enabled ("CONFIG_RTE_KNI_KMOD_ETHTOOL=y")
> ethtool commands "ETHTOOL_GSET & ETHTOOL_SSET" are no more
> supported for the kernels that has "ETHTOOL_GLINKSETTINGS &
> ETHTOOL_SLINKSETTINGS"
> support. This means ``ethtool "-a|--show-pause", "-s|--change"`` won't work,
> and ``ethtool <iface>`` output will have less information.
>
> Signed-off-by: zhuwenhui <wenhuix.zhu@intel.com>
> ---
> tests/TestSuite_kni.py | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/tests/TestSuite_kni.py b/tests/TestSuite_kni.py index
> 23d6d04..46928a7 100644
> --- a/tests/TestSuite_kni.py
> +++ b/tests/TestSuite_kni.py
> @@ -676,14 +676,6 @@ class TestKni(TestCase):
> self.verify("Operation not supported" not in out,
> "'ethtool -i' not supported")
>
> - # Request pause parameters
> - out = self.dut.send_expect("ethtool -a %s" %
> virtual_interface,
> - "# ")
> - self.verify("Pause parameters for %s" % virtual_interface in
> out,
> - "'ethtool -a' not supported")
> - self.verify("Operation not supported" not in out,
> - "ethtool '-a' not supported")
> -
> # Request statistics
> out = self.dut.send_expect("ethtool -S %s" %
> virtual_interface,
> "# ")
> --
> 2.17.2
prev parent reply other threads:[~2018-11-07 10:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 6:48 zhuwenhui
2018-11-07 10:07 ` Tu, Lijuan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0B9B99A9@SHSMSX101.ccr.corp.intel.com \
--to=lijuan.tu@intel.com \
--cc=dts@dpdk.org \
--cc=wenhuix.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).