From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id B53B52862 for ; Wed, 7 Nov 2018 11:07:56 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Nov 2018 02:07:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,475,1534834800"; d="scan'208";a="89236245" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga006.jf.intel.com with ESMTP; 07 Nov 2018 02:07:55 -0800 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 7 Nov 2018 02:07:54 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 7 Nov 2018 02:07:54 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.102]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.161]) with mapi id 14.03.0415.000; Wed, 7 Nov 2018 18:07:53 +0800 From: "Tu, Lijuan" To: "Zhu, WenhuiX" , "dts@dpdk.org" CC: "Zhu, WenhuiX" Thread-Topic: [dts] [PATCH V1] kni/ethtool delete ethtool -a during the running process Thread-Index: AQHUdmWcXqypRSsAgE+OIxnIf12096VECUXQ Date: Wed, 7 Nov 2018 10:07:52 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0B9B99A9@SHSMSX101.ccr.corp.intel.com> References: <1541573335-29570-1-git-send-email-wenhuix.zhu@intel.com> In-Reply-To: <1541573335-29570-1-git-send-email-wenhuix.zhu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDJmYTBlZGItOTJiNi00YjU5LWFlMjgtMjk0MWE2NjI5MzYyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQmd0RnFQTVd4OHBPQTljTW82NlFtaTRFSWhPZHJNT0V4TlNrRFwvZjhLOFZoWVNpUkgydmNsWnFzUTlRN2sxUFcifQ== x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] kni/ethtool delete ethtool -a during the running process X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Nov 2018 10:07:57 -0000 It's not a good option to remove these operation. Snice kernel 4.19 changes= ethtool_ops, but that does not mean we can't support the kernel version lo= wer than 4.19. > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhuwenhui > Sent: Wednesday, November 7, 2018 2:49 PM > To: dts@dpdk.org > Cc: Zhu, WenhuiX > Subject: [dts] [PATCH V1] kni/ethtool delete ethtool -a during the runnin= g > process >=20 >=20 > KNI, when ethtool support enabled ("CONFIG_RTE_KNI_KMOD_ETHTOOL=3Dy") > ethtool commands "ETHTOOL_GSET & ETHTOOL_SSET" are no more > supported for the kernels that has "ETHTOOL_GLINKSETTINGS & > ETHTOOL_SLINKSETTINGS" > support. This means ``ethtool "-a|--show-pause", "-s|--change"`` won't wo= rk, > and ``ethtool `` output will have less information. >=20 > Signed-off-by: zhuwenhui > --- > tests/TestSuite_kni.py | 8 -------- > 1 file changed, 8 deletions(-) >=20 > diff --git a/tests/TestSuite_kni.py b/tests/TestSuite_kni.py index > 23d6d04..46928a7 100644 > --- a/tests/TestSuite_kni.py > +++ b/tests/TestSuite_kni.py > @@ -676,14 +676,6 @@ class TestKni(TestCase): > self.verify("Operation not supported" not in out, > "'ethtool -i' not supported") >=20 > - # Request pause parameters > - out =3D self.dut.send_expect("ethtool -a %s" % > virtual_interface, > - "# ") > - self.verify("Pause parameters for %s" % virtual_interface in > out, > - "'ethtool -a' not supported") > - self.verify("Operation not supported" not in out, > - "ethtool '-a' not supported") > - > # Request statistics > out =3D self.dut.send_expect("ethtool -S %s" % > virtual_interface, > "# ") > -- > 2.17.2