[dts] [PATCH V1] kni/ethtool delete ethtool -a during the running process

[dts] [PATCH V1] kni/ethtool delete ethtool -a during the running process

[zhuwenhui]

KNI, when ethtool support enabled ("CONFIG_RTE_KNI_KMOD_ETHTOOL=y") 
ethtool commands "ETHTOOL_GSET & ETHTOOL_SSET" are no more supported 
for the kernels that has "ETHTOOL_GLINKSETTINGS & ETHTOOL_SLINKSETTINGS" 
support. This means ``ethtool "-a|--show-pause", "-s|--change"`` won't
work, and ``ethtool <iface>`` output will have less information.

Signed-off-by: zhuwenhui <wenhuix.zhu@intel.com>
---
 tests/TestSuite_kni.py | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/tests/TestSuite_kni.py b/tests/TestSuite_kni.py
index 23d6d04..46928a7 100644
--- a/tests/TestSuite_kni.py
+++ b/tests/TestSuite_kni.py
@@ -676,14 +676,6 @@ class TestKni(TestCase):
             self.verify("Operation not supported" not in out,
                         "'ethtool -i' not supported")
 
-            # Request pause parameters
-            out = self.dut.send_expect("ethtool -a %s" % virtual_interface,
-                                       "# ")
-            self.verify("Pause parameters for %s" % virtual_interface in out,
-                        "'ethtool -a' not supported")
-            self.verify("Operation not supported" not in out,
-                        "ethtool '-a' not supported")
-
             # Request statistics
             out = self.dut.send_expect("ethtool -S %s" % virtual_interface,
                                        "# ")
-- 
2.17.2

Re: [dts] [PATCH V1] kni/ethtool delete ethtool -a during the running process

[Tu, Lijuan]

It's not a good option to remove these operation. Snice kernel 4.19 changes ethtool_ops, but that does not mean we can't support the kernel version lower than 4.19.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhuwenhui
> Sent: Wednesday, November 7, 2018 2:49 PM
> To: dts@dpdk.org
> Cc: Zhu, WenhuiX <wenhuix.zhu@intel.com>
> Subject: [dts] [PATCH V1] kni/ethtool delete ethtool -a during the running
> process
> 
> 
> KNI, when ethtool support enabled ("CONFIG_RTE_KNI_KMOD_ETHTOOL=y")
> ethtool commands "ETHTOOL_GSET & ETHTOOL_SSET" are no more
> supported for the kernels that has "ETHTOOL_GLINKSETTINGS &
> ETHTOOL_SLINKSETTINGS"
> support. This means ``ethtool "-a|--show-pause", "-s|--change"`` won't work,
> and ``ethtool <iface>`` output will have less information.
> 
> Signed-off-by: zhuwenhui <wenhuix.zhu@intel.com>
> ---
>  tests/TestSuite_kni.py | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/tests/TestSuite_kni.py b/tests/TestSuite_kni.py index
> 23d6d04..46928a7 100644
> --- a/tests/TestSuite_kni.py
> +++ b/tests/TestSuite_kni.py
> @@ -676,14 +676,6 @@ class TestKni(TestCase):
>              self.verify("Operation not supported" not in out,
>                          "'ethtool -i' not supported")
> 
> -            # Request pause parameters
> -            out = self.dut.send_expect("ethtool -a %s" %
> virtual_interface,
> -                                       "# ")
> -            self.verify("Pause parameters for %s" % virtual_interface in
> out,
> -                        "'ethtool -a' not supported")
> -            self.verify("Operation not supported" not in out,
> -                        "ethtool '-a' not supported")
> -
>              # Request statistics
>              out = self.dut.send_expect("ethtool -S %s" %
> virtual_interface,
>                                         "# ")
> --
> 2.17.2