test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Lin, Xueqin" <xueqin.lin@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Lin, Xueqin" <xueqin.lin@intel.com>
Subject: Re: [dts] [PATCH] test_plans: add hotplug on multi-processes test plan
Date: Wed, 28 Nov 2018 08:28:41 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0B9C1BFD@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1543296605-36380-1-git-send-email-xueqin.lin@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xueqin Lin
> Sent: Tuesday, November 27, 2018 1:30 PM
> To: dts@dpdk.org
> Cc: Lin, Xueqin <xueqin.lin@intel.com>
> Subject: [dts] [PATCH] test_plans: add hotplug on multi-processes test plan
> 
> From: "xueqin.lin" <xueqin.lin@intel.com>
> 
> Signed-off-by: Xueqin Lin <xueqin.lin@intel.com>
> 
> ---
>  test_plans/hotplug_mp_test_plan.rst | 229
> ++++++++++++++++++++++++++++++++++++
>  1 file changed, 229 insertions(+)
>  create mode 100755 test_plans/hotplug_mp_test_plan.rst
> 
> diff --git a/test_plans/hotplug_mp_test_plan.rst
> b/test_plans/hotplug_mp_test_plan.rst
> new file mode 100755
> index 0000000..4b9c6dd
> --- /dev/null
> +++ b/test_plans/hotplug_mp_test_plan.rst
> @@ -0,0 +1,229 @@
> +.. Copyright (c) <2018>, Intel Corporation
> +   All rights reserved.
> +
> +   Redistribution and use in source and binary forms, with or without
> +   modification, are permitted provided that the following conditions
> +   are met:
> +
> +   - Redistributions of source code must retain the above copyright
> +     notice, this list of conditions and the following disclaimer.
> +
> +   - Redistributions in binary form must reproduce the above copyright
> +     notice, this list of conditions and the following disclaimer in
> +     the documentation and/or other materials provided with the
> +     distribution.
> +
> +   - Neither the name of Intel Corporation nor the names of its
> +     contributors may be used to endorse or promote products derived
> +     from this software without specific prior written permission.
> +
> +   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
> CONTRIBUTORS
> +   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT
> NOT
> +   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND
> FITNESS
> +   FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL
> THE
> +   COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT,
> INDIRECT,
> +   INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
> +   (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE
> GOODS OR
> +   SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
> INTERRUPTION)
> +   HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
> CONTRACT,
> +   STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
> +   ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
> ADVISED
> +   OF THE POSSIBILITY OF SUCH DAMAGE.
> +
> +==========================
> +Hotplug on multi-processes
> +==========================
> +Currently secondary process will only sync ethdev from primary process
> +at init stage, but it will not be aware if device is attached/detached
> +on primary process at runtime.
> +
> +While there is the requirement from application that take
> +primary-secondary process model. The primary process work as a resource
> +management process, it will create/destroy virtual device at runtime,
> +while the secondary process deal with the network stuff with these
> +devices.
> +
> +So the orignial intention is to fix this gap, but beyond that the patch
> +set provide a more comprehesive solution to handle different hotplug
> +cases in multi-process situation, it cover below
> +scenario:
> +
> + Attach a device from the primary
> + Detach a device from the primary
> + Attach a device from a secondary
> + Detach a device from a secondary
> +
> +In primary-secondary process model, we assume ethernet devices are
> +shared by default, that means attach or detach a device on any process
> +will broadcast to all other processes through mp channel then device
> +information will be synchronized on all processes.
> +
> +Any failure during attaching process will cause inconsistent status
> +between processes, so proper rollback action should be considered.
> +
> +
> +Test Case: Attach physical device from primary or secondary
> +===========================================================
> +Start sample code as primary then secondary::
> +    ./hotplug_mp --proc-type=auto
> +
> +Check primary and secondary processes don't have any device::
> +    example> list
> +    list all etherdev
> +
> +Bind one port to igb_uio or vfio
> +
> +Attach the physical device from primary or secondary, check primary and
> +secondary processes attach the share device successfully::
> +
> +     example> attach 0000:88:00.0
> +     example> list
> +     list all etherdev
> +     0       0000:88:00.0
> +
> +Quit primary and secondary processes
> +
> +Re-bind port to kernel state
> +
> +
> +Test Case: Detach physical device from primary or secondary
> +===========================================================
> +Bind one port to igb_uio or vfio
> +
> +Start sample code as primary then secondary::
> +    ./hotplug_mp --proc-type=auto
> +
> +Check primary and secondary processes have the device::
> +    example> list
> +    list all etherdev
> +    0       0000:88:00.0
> +
> +Detach the physical device from primary or secondary, check primary and
> +secondary processes detach the share device successfully::
> +
> +    example> detach 0000:88:00.0
> +    example> list
> +    list all etherdev
> +
> +Quit primary and secondary processes
> +
> +Re-bind port to kernel state
> +
> +
> +Test Case: Attach virtual device from primary or secondary
> +==========================================================
> +Start sample code as primary then secondary::
> +    ./hotplug_mp --proc-type=auto
> +
> +Check primary and secondary processes don't have any device::
> +    example> list
> +    list all etherdev
> +
> +Attach a virtual device from primary or secondary, check primary and
> +secondary processes attach the share device successfully::
> +
> +    example> attach net_af_packet,iface=ens803f1
> +    example> list
> +    list all etherdev
> +    0       net_af_packet
> +
> +Quit primary and secondary processes
> +
> +Test Case: Detach virtual device from primary or secondary
> +==========================================================
> +Start sample code as primary then secondary::
> +    ./hotplug_mp --proc-type=auto
> +
> +Check primary and secondary processes don't have any device::
> +    example> list
> +    list all etherdev
> +
> +Attach a virtual device from primary or secondary, check primary and
> +secondary processes attach the share device successfully::
> +
> +    example> attach net_af_packet,iface=ens803f1
> +    example> list
> +    list all etherdev
> +    0       net_af_packet
> +
> +Detach the physical device from primary or secondary, check primary and
> +secondary processes detach the share device successfully::
> +
> +    example> detach net_af_packet
> +    example> list
> +    list all etherdev
> +
> +Quit primary and secondary processes
> +
> +Test Case: Repeat to attach/detach physical device from primary or
> +secondary
> +=============================================================
> ==========
> +===== Start sample code as primary then secondary::
> +    ./hotplug_mp --proc-type=auto
> +
> +Check primary and secondary processes don't have any device::
> +    example> list
> +    list all etherdev
> +
> +Bind one port to igb_uio or vfio
> +
> +Attach the physical device from primary or secondary, check primary and
> +secondary processes attach the share device successfully::
> +
> +    example> attach 0000:88:00.0
> +    example> list
> +    list all etherdev
> +    0       0000:88:00.0
> +
> +Attach the same physical device from primary or secondary, check
> +primary and secondary processes fail to attach same device again
> +
> +Detach the physical device from primary or secondary, check primary and
> +secondary processes detach the share device successfully::
> +
> +    example> detach 0000:88:00.0
> +    example> list
> +    list all etherdev
> +
> +Detach the same physical device from primary or secondary, check
> +primary and secondary processes fail to detach same device again
> +
> +Repeat above attach and detach for 2 times
> +
> +Quit primary and secondary processes
> +
> +Re-bind port to kernel state
> +
> +
> +Test Case: Repeat to attach/detach virtual device from primary or
> +secondary
> +=============================================================
> ==========
> +==== Start sample code as primary then secondary::
> +     ./hotplug_mp --proc-type=auto
> +
> +Check primary and secondary processes don't have any device::
> +     example> list
> +     list all etherdev
> +
> +Attach a virtual device from primary or secondary, check primary and
> +secondary processes attach the share device successfully::
> +
> +    example> attach net_af_packet,iface=ens803f1
> +    example> list
> +    list all etherdev
> +    0       net_af_packet
> +
> +Attach the same virtual device from primary or secondary, check primary
> +and secondary processes fail to attach same device again
> +
> +Detach the virtual device from primary or secondary, check primary and
> +secondary processes detach the share device successfully::
> +
> +    example> detach net_af_packet
> +    example> list
> +    list all etherdev
> +
> +Detach the same virtual device from primary or secondary, check primary
> +and secondary processes fail to detach same device again
> +
> +Repeat above attach and detach for 2 times
> +
> +Quit primary and secondary processes
> --
> 2.7.5

      reply	other threads:[~2018-11-28  8:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-27  5:30 Xueqin Lin
2018-11-28  8:28 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0B9C1BFD@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=xueqin.lin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).