test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Tu, Lijuan" <lijuan.tu@intel.com>,
	"Ma, LihongX" <lihongx.ma@intel.com>,
	 "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH V1] Use tcpdump_sniff_packets instead of sniff method
Date: Tue, 11 Dec 2018 10:51:34 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0B9DEEE2@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <c5188358-78f6-37a4-3c2c-6c477c21546f@intel.com>

Sorry, applied V2 instead of V1

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Lijuan Tu
> Sent: Wednesday, December 12, 2018 3:00 AM
> To: Ma, LihongX <lihongx.ma@intel.com>; dts@dpdk.org
> Subject: Re: [dts] [PATCH V1] Use tcpdump_sniff_packets instead of sniff
> method
> 
> Applied, thanks
> 
> 
> On 2018年12月05日 09:36, lihong wrote:
> > About the test case test_vxlan_ipv6_checksum_offload,the sniff method
> > may not work well when add filter arguments, so use
> > tcpdump_sniff_packets instead of it.
> >
> > Signed-off-by: lihong <lihongx.ma@intel.com>
> > ---
> >   tests/TestSuite_vxlan.py | 8 +++-----
> >   1 file changed, 3 insertions(+), 5 deletions(-)
> >
> > diff --git a/tests/TestSuite_vxlan.py b/tests/TestSuite_vxlan.py index
> > d5a9d77..8de8384 100644
> > --- a/tests/TestSuite_vxlan.py
> > +++ b/tests/TestSuite_vxlan.py
> > @@ -447,16 +447,14 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
> >           config.create_pcap()
> >
> >           # remove tempory files
> > +        config.capture_file = "/tmp/sniff_%s.pcap" % self.recv_iface
> >           self.tester.send_expect("rm -rf %s" % config.capture_file, "#
> ")
> >           # save the capture packet into pcap format
> >           self.tester.scapy_background()
> > -        self.tester.scapy_append(
> > -
> 'p=sniff(iface="%s",filter="ether[12:2]!=0x88cc",count=1,timeout=5)' %
> self.recv_iface)
> > -        self.tester.scapy_append(
> > -            'wrpcap(\"%s\", p)' % config.capture_file)
> > -        self.tester.scapy_foreground()
> >
> > +        inst = self.tester.tcpdump_sniff_packets(self.recv_iface,
> > + timeout=5)
> >           config.send_pcap(self.tester_iface)
> > +        self.tester.load_tcpdump_sniff_packets(inst)
> >           time.sleep(5)
> >
> >           # extract the checksum offload from saved pcap file


      reply	other threads:[~2018-12-11 10:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-05  1:36 lihong
2018-12-06  5:46 ` Zhu, WenhuiX
2018-12-11 18:59 ` Lijuan Tu
2018-12-11 10:51   ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0B9DEEE2@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=lihongx.ma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).