test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Zhao, MeijuanX" <meijuanx.zhao@intel.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH V1] tests/vf_port_start_stop: restore device status
Date: Mon, 24 Dec 2018 08:39:51 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0B9E6463@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <9866F1E5CE768A45B24F6603C6EF54DE05A3A119@shsmsx102.ccr.corp.intel.com>

Sorry, I make a mistake.

> -----Original Message-----
> From: Zhao, MeijuanX
> Sent: Monday, December 24, 2018 4:38 PM
> To: Tu, Lijuan <lijuan.tu@intel.com>; dts@dpdk.org
> Cc: Zhao, MeijuanX <meijuanx.zhao@intel.com>
> Subject: RE: [dts] [PATCH V1] tests/vf_port_start_stop: restore device status
> 
> tx_interface = self.tester.get_interface(self.tester_tx_port) is get tester nic
> name,
> 
> self.tester.send_expect("./dpdk_nic_bind.py --bind=%s %s" \
>                   %(self.tester_port_driver, self.tester_tx_pci), "#") use
> pci bind driver, They are not duplicated, I don't bind nic
> 
> 
> 
> -----Original Message-----
> From: Tu, Lijuan
> Sent: Saturday, December 22, 2018 9:59 AM
> To: Zhao, MeijuanX <meijuanx.zhao@intel.com>; dts@dpdk.org
> Cc: Zhao, MeijuanX <meijuanx.zhao@intel.com>
> Subject: RE: [dts] [PATCH V1] tests/vf_port_start_stop: restore device status
> 
> Hi meijuan,
> 
> tx_interface = self.tester.get_interface(self.tester_tx_port) is duplicated
> with
>               self.tester.send_expect("./dpdk_nic_bind.py --bind=%s %s"
> \
>                   %(self.tester_port_driver, self.tester_tx_pci), "#")
> 
> 
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhao,meijuan
> > Sent: Wednesday, December 12, 2018 2:42 PM
> > To: dts@dpdk.org
> > Cc: Zhao, MeijuanX <meijuanx.zhao@intel.com>
> > Subject: [dts] [PATCH V1] tests/vf_port_start_stop: restore device
> > status
> >
> > Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
> > ---
> >  tests/TestSuite_vf_port_start_stop.py | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/tests/TestSuite_vf_port_start_stop.py
> > b/tests/TestSuite_vf_port_start_stop.py
> > index a9e88d8..4857dd3 100644
> > --- a/tests/TestSuite_vf_port_start_stop.py
> > +++ b/tests/TestSuite_vf_port_start_stop.py
> > @@ -248,6 +248,8 @@ class TestVfPortStartStop(TestCase):
> >              self.tester.send_expect("./dpdk_nic_bind.py
> --bind=%s %s" \
> >                  %(self.tester_port_driver, self.tester_tx_pci), "#")
> >
> > +        tx_interface = self.tester.get_interface(self.tester_tx_port)
> > +        self.tester.send_expect("ifconfig %s up" % tx_interface, "#")
> >          if getattr(self, 'vm0', None):
> >              self.vm0.stop()
> >
> > --
> > 2.17.2

      reply	other threads:[~2018-12-24  8:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-12  6:41 zhao,meijuan
2018-12-13  2:31 ` Yao, BingX Y
2018-12-22  1:59 ` Tu, Lijuan
2018-12-24  8:38   ` Zhao, MeijuanX
2018-12-24  8:39     ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0B9E6463@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=meijuanx.zhao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).