test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] tests/vf_port_start_stop: restore device status
@ 2018-12-12  6:41 zhao,meijuan
  2018-12-13  2:31 ` Yao, BingX Y
  2018-12-22  1:59 ` Tu, Lijuan
  0 siblings, 2 replies; 5+ messages in thread
From: zhao,meijuan @ 2018-12-12  6:41 UTC (permalink / raw)
  To: dts; +Cc: zhao,meijuan

Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
---
 tests/TestSuite_vf_port_start_stop.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/TestSuite_vf_port_start_stop.py b/tests/TestSuite_vf_port_start_stop.py
index a9e88d8..4857dd3 100644
--- a/tests/TestSuite_vf_port_start_stop.py
+++ b/tests/TestSuite_vf_port_start_stop.py
@@ -248,6 +248,8 @@ class TestVfPortStartStop(TestCase):
             self.tester.send_expect("./dpdk_nic_bind.py --bind=%s %s" \
                 %(self.tester_port_driver, self.tester_tx_pci), "#")
 
+        tx_interface = self.tester.get_interface(self.tester_tx_port)
+        self.tester.send_expect("ifconfig %s up" % tx_interface, "#")
         if getattr(self, 'vm0', None):
             self.vm0.stop()
 
-- 
2.17.2

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1] tests/vf_port_start_stop: restore device status
  2018-12-12  6:41 [dts] [PATCH V1] tests/vf_port_start_stop: restore device status zhao,meijuan
@ 2018-12-13  2:31 ` Yao, BingX Y
  2018-12-22  1:59 ` Tu, Lijuan
  1 sibling, 0 replies; 5+ messages in thread
From: Yao, BingX Y @ 2018-12-13  2:31 UTC (permalink / raw)
  To: Zhao, MeijuanX, dts; +Cc: Zhao, MeijuanX, Wang, FengqinX

Tested-by: Yao, bing<bingx.y.yao@intel.com>

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhao,meijuan
Sent: Wednesday, December 12, 2018 2:42 PM
To: dts@dpdk.org
Cc: Zhao, MeijuanX <meijuanx.zhao@intel.com>
Subject: [dts] [PATCH V1] tests/vf_port_start_stop: restore device status

Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
---
 tests/TestSuite_vf_port_start_stop.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/TestSuite_vf_port_start_stop.py b/tests/TestSuite_vf_port_start_stop.py
index a9e88d8..4857dd3 100644
--- a/tests/TestSuite_vf_port_start_stop.py
+++ b/tests/TestSuite_vf_port_start_stop.py
@@ -248,6 +248,8 @@ class TestVfPortStartStop(TestCase):
             self.tester.send_expect("./dpdk_nic_bind.py --bind=%s %s" \
                 %(self.tester_port_driver, self.tester_tx_pci), "#")
 
+        tx_interface = self.tester.get_interface(self.tester_tx_port)
+        self.tester.send_expect("ifconfig %s up" % tx_interface, "#")
         if getattr(self, 'vm0', None):
             self.vm0.stop()
 
-- 
2.17.2

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1] tests/vf_port_start_stop: restore device status
  2018-12-12  6:41 [dts] [PATCH V1] tests/vf_port_start_stop: restore device status zhao,meijuan
  2018-12-13  2:31 ` Yao, BingX Y
@ 2018-12-22  1:59 ` Tu, Lijuan
  2018-12-24  8:38   ` Zhao, MeijuanX
  1 sibling, 1 reply; 5+ messages in thread
From: Tu, Lijuan @ 2018-12-22  1:59 UTC (permalink / raw)
  To: Zhao, MeijuanX, dts; +Cc: Zhao, MeijuanX

Hi meijuan,

tx_interface = self.tester.get_interface(self.tester_tx_port) is duplicated with 
              self.tester.send_expect("./dpdk_nic_bind.py --bind=%s %s" \
                  %(self.tester_port_driver, self.tester_tx_pci), "#")


> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhao,meijuan
> Sent: Wednesday, December 12, 2018 2:42 PM
> To: dts@dpdk.org
> Cc: Zhao, MeijuanX <meijuanx.zhao@intel.com>
> Subject: [dts] [PATCH V1] tests/vf_port_start_stop: restore device status
> 
> Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
> ---
>  tests/TestSuite_vf_port_start_stop.py | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/TestSuite_vf_port_start_stop.py
> b/tests/TestSuite_vf_port_start_stop.py
> index a9e88d8..4857dd3 100644
> --- a/tests/TestSuite_vf_port_start_stop.py
> +++ b/tests/TestSuite_vf_port_start_stop.py
> @@ -248,6 +248,8 @@ class TestVfPortStartStop(TestCase):
>              self.tester.send_expect("./dpdk_nic_bind.py --bind=%s %s" \
>                  %(self.tester_port_driver, self.tester_tx_pci), "#")
> 
> +        tx_interface = self.tester.get_interface(self.tester_tx_port)
> +        self.tester.send_expect("ifconfig %s up" % tx_interface, "#")
>          if getattr(self, 'vm0', None):
>              self.vm0.stop()
> 
> --
> 2.17.2

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1] tests/vf_port_start_stop: restore device status
  2018-12-22  1:59 ` Tu, Lijuan
@ 2018-12-24  8:38   ` Zhao, MeijuanX
  2018-12-24  8:39     ` Tu, Lijuan
  0 siblings, 1 reply; 5+ messages in thread
From: Zhao, MeijuanX @ 2018-12-24  8:38 UTC (permalink / raw)
  To: Tu, Lijuan, dts; +Cc: Zhao, MeijuanX

tx_interface = self.tester.get_interface(self.tester_tx_port) is get tester nic name,

self.tester.send_expect("./dpdk_nic_bind.py --bind=%s %s" \
                  %(self.tester_port_driver, self.tester_tx_pci), "#") use pci bind driver,
They are not duplicated, I don't bind nic



-----Original Message-----
From: Tu, Lijuan 
Sent: Saturday, December 22, 2018 9:59 AM
To: Zhao, MeijuanX <meijuanx.zhao@intel.com>; dts@dpdk.org
Cc: Zhao, MeijuanX <meijuanx.zhao@intel.com>
Subject: RE: [dts] [PATCH V1] tests/vf_port_start_stop: restore device status

Hi meijuan,

tx_interface = self.tester.get_interface(self.tester_tx_port) is duplicated with 
              self.tester.send_expect("./dpdk_nic_bind.py --bind=%s %s" \
                  %(self.tester_port_driver, self.tester_tx_pci), "#")


> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhao,meijuan
> Sent: Wednesday, December 12, 2018 2:42 PM
> To: dts@dpdk.org
> Cc: Zhao, MeijuanX <meijuanx.zhao@intel.com>
> Subject: [dts] [PATCH V1] tests/vf_port_start_stop: restore device status
> 
> Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
> ---
>  tests/TestSuite_vf_port_start_stop.py | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/TestSuite_vf_port_start_stop.py
> b/tests/TestSuite_vf_port_start_stop.py
> index a9e88d8..4857dd3 100644
> --- a/tests/TestSuite_vf_port_start_stop.py
> +++ b/tests/TestSuite_vf_port_start_stop.py
> @@ -248,6 +248,8 @@ class TestVfPortStartStop(TestCase):
>              self.tester.send_expect("./dpdk_nic_bind.py --bind=%s %s" \
>                  %(self.tester_port_driver, self.tester_tx_pci), "#")
> 
> +        tx_interface = self.tester.get_interface(self.tester_tx_port)
> +        self.tester.send_expect("ifconfig %s up" % tx_interface, "#")
>          if getattr(self, 'vm0', None):
>              self.vm0.stop()
> 
> --
> 2.17.2

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1] tests/vf_port_start_stop: restore device status
  2018-12-24  8:38   ` Zhao, MeijuanX
@ 2018-12-24  8:39     ` Tu, Lijuan
  0 siblings, 0 replies; 5+ messages in thread
From: Tu, Lijuan @ 2018-12-24  8:39 UTC (permalink / raw)
  To: Zhao, MeijuanX, dts

Sorry, I make a mistake.

> -----Original Message-----
> From: Zhao, MeijuanX
> Sent: Monday, December 24, 2018 4:38 PM
> To: Tu, Lijuan <lijuan.tu@intel.com>; dts@dpdk.org
> Cc: Zhao, MeijuanX <meijuanx.zhao@intel.com>
> Subject: RE: [dts] [PATCH V1] tests/vf_port_start_stop: restore device status
> 
> tx_interface = self.tester.get_interface(self.tester_tx_port) is get tester nic
> name,
> 
> self.tester.send_expect("./dpdk_nic_bind.py --bind=%s %s" \
>                   %(self.tester_port_driver, self.tester_tx_pci), "#") use
> pci bind driver, They are not duplicated, I don't bind nic
> 
> 
> 
> -----Original Message-----
> From: Tu, Lijuan
> Sent: Saturday, December 22, 2018 9:59 AM
> To: Zhao, MeijuanX <meijuanx.zhao@intel.com>; dts@dpdk.org
> Cc: Zhao, MeijuanX <meijuanx.zhao@intel.com>
> Subject: RE: [dts] [PATCH V1] tests/vf_port_start_stop: restore device status
> 
> Hi meijuan,
> 
> tx_interface = self.tester.get_interface(self.tester_tx_port) is duplicated
> with
>               self.tester.send_expect("./dpdk_nic_bind.py --bind=%s %s"
> \
>                   %(self.tester_port_driver, self.tester_tx_pci), "#")
> 
> 
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhao,meijuan
> > Sent: Wednesday, December 12, 2018 2:42 PM
> > To: dts@dpdk.org
> > Cc: Zhao, MeijuanX <meijuanx.zhao@intel.com>
> > Subject: [dts] [PATCH V1] tests/vf_port_start_stop: restore device
> > status
> >
> > Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
> > ---
> >  tests/TestSuite_vf_port_start_stop.py | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/tests/TestSuite_vf_port_start_stop.py
> > b/tests/TestSuite_vf_port_start_stop.py
> > index a9e88d8..4857dd3 100644
> > --- a/tests/TestSuite_vf_port_start_stop.py
> > +++ b/tests/TestSuite_vf_port_start_stop.py
> > @@ -248,6 +248,8 @@ class TestVfPortStartStop(TestCase):
> >              self.tester.send_expect("./dpdk_nic_bind.py
> --bind=%s %s" \
> >                  %(self.tester_port_driver, self.tester_tx_pci), "#")
> >
> > +        tx_interface = self.tester.get_interface(self.tester_tx_port)
> > +        self.tester.send_expect("ifconfig %s up" % tx_interface, "#")
> >          if getattr(self, 'vm0', None):
> >              self.vm0.stop()
> >
> > --
> > 2.17.2

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-12-24  8:39 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-12  6:41 [dts] [PATCH V1] tests/vf_port_start_stop: restore device status zhao,meijuan
2018-12-13  2:31 ` Yao, BingX Y
2018-12-22  1:59 ` Tu, Lijuan
2018-12-24  8:38   ` Zhao, MeijuanX
2018-12-24  8:39     ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).