test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: Phanendra Vukkisala <pvukkisala@marvell.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Cc: Vijaya Bhaskar Annayyolla <avijay@marvell.com>,
	Faisal Masood <fmasood@marvell.com>
Subject: Re: [dts] [PATCH] conf/test_case_supportlist.json: Avoid showing fail for not supported NICs
Date: Mon, 7 Jan 2019 08:43:59 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0B9FDF6B@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1546592352-22633-1-git-send-email-pvukkisala@marvell.com>

Hi phanendra,

If test cases are not supported by some NICs, I should be added into test_case_checklist.json.
Only the cases that added in supportlist.json are supported by these specific NICs.

For instance: the syn_filter you added in the support list.
Syn_filter is only supported by Niantic, kawela_r, bartonhills, powerville, but not supported by Fortville and other NICes.

"syn_filter": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "niantic",
> +                "kawela_4",
> +                "bartonhills",
> +                "powerville"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case not support on this NIC"
> +        }
> +    ],


> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Phanendra Vukkisala
> Sent: Friday, January 4, 2019 5:00 PM
> To: dts@dpdk.org
> Cc: Vijaya Bhaskar Annayyolla <avijay@marvell.com>; Faisal Masood
> <fmasood@marvell.com>; Phanendra Vukkisala <pvukkisala@marvell.com>
> Subject: [dts] [PATCH] conf/test_case_supportlist.json: Avoid showing fail
> for not supported NICs
> 
> From: pvukkisala <pvukkisala@marvell.com>
> 
> Result is showing as fail for not supported NICs. Added proper fix to avoid
> show test result as fail instead of N/A.
> 
> Signed-off-by: phanendra,vukkisala <pvukkisala@marvell.com>
> ---
>  conf/test_case_supportlist.json |  201
> +++++++++++++++++++++++++++++++++++++++
>  1 file changed, 201 insertions(+)
> 
> diff --git a/conf/test_case_supportlist.json
> b/conf/test_case_supportlist.json index 571bb5c..c128c95 100644
> --- a/conf/test_case_supportlist.json
> +++ b/conf/test_case_supportlist.json
> @@ -633,5 +633,206 @@
>              "Bug ID": "",
>              "Comments": "This case only support on FVL"
>          }
> +    ],
> +    "syn_filter": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "niantic",
> +                "kawela_4",
> +                "bartonhills",
> +                "powerville"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case not support on this NIC"
> +        }
> +    ],
> +    "priority_filter": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "niantic",
> +                "kawela_4",
> +                "bartonhills",
> +                "powerville"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case not support on this NIC"
> +        }
> +    ],
> +    "five_tuple_filter": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "niantic",
> +                "kawela_4"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case only support only on Niantic and
> kawela_4"
> +        }
> +    ],
> +    "ethertype_filter": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "niantic",
> +                "kawela_4",
> +                "bartonhills",
> +                "powerville",
> +                "fortville_eagle",
> +                "fortville_spirit",
> +                "fortville_spirit_single",
> +                "fortpark_TLV",
> +                "fortville_25g"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case is not supported on this NIC"
> +        }
> +    ],
> +    "multiple_filters_10GB": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "niantic"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case only support with Niantic NIC"
> +        }
> +    ],
> +    "twotuple_filter": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "powerville",
> +                "bartonhills"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case is not supported on this NIC"
> +        }
> +    ],
> +    "flex_filter": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "powerville",
> +                "bartonhills"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case is not supported on this NIC"
> +        }
> +    ],
> +    "multiple_filters_1GB": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "powerville",
> +                "kawela_4",
> +                "bartonhills"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case is not supported on this NIC"
> +        }
> +    ],
> +    "128_queues": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "niantic",
> +                "ironpond",
> +                "twinpond",
> +                "twinville",
> +                "sageville",
> +                "sagepond",
> +                "magnolia_park",
> +                "springfountain"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case only support with ixgbe driver"
> +        }
> +    ],
> +    "rss_key_size": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "fortville_eagle",
> +                "fortville_spirit",
> +                "fortville_spirit_single",
> +                "fortville_25g",
> +                "niantic",
> +                "redrockcanyou",
> +                "atwood",
> +                "boulderrapid",
> +                "fortpark_TLV"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case is not supported on this NIC"
> +        }
> +    ],
> +    "vlan_qinq_tpid": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "fortville_eagle",
> +                "fortville_spirit",
> +                "fortville_spirit_single"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case is not supported on this NIC"
> +        }
>      ]
>  }
> --
> 1.7.9.5

  reply	other threads:[~2019-01-07  8:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-04  8:59 Phanendra Vukkisala
2019-01-07  8:43 ` Tu, Lijuan [this message]
2019-01-07  9:38   ` Phanendra Vukkisala
2019-01-07 10:42     ` Tu, Lijuan
2019-01-08 12:46 ` [dts] [PATCH v2] conf/test_case_checklist.json: Avoid showing fail for not supported tests Phanendra Vukkisala
2019-01-09 11:08   ` Lijuan Tu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0B9FDF6B@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=avijay@marvell.com \
    --cc=dts@dpdk.org \
    --cc=fmasood@marvell.com \
    --cc=pvukkisala@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).