* [dts] [PATCH] disable-hw-vlan-filter: Removed flag in testpmd "--disable-hw-vlan-filter"
@ 2019-01-03 12:39 Phanendra Vukkisala
2019-01-07 8:46 ` Tu, Lijuan
0 siblings, 1 reply; 2+ messages in thread
From: Phanendra Vukkisala @ 2019-01-03 12:39 UTC (permalink / raw)
To: dts; +Cc: Vijaya Bhaskar Annayyolla, Faisal Masood, Phanendra Vukkisala
From: pvukkisala <pvukkisala@marvell.com>
For cavium devices this flag was added before, but now testpmd is not supporting
this flag, which is leading to failing tests on cavium devices. So removing
unwanted flag
Signed-off-by: phanendra,vukkisala <pvukkisala@marvell.com>
---
framework/pmd_output.py | 4 ----
tests/TestSuite_dynamic_config.py | 6 ------
tests/TestSuite_pmdpcap.py | 4 ----
tests/TestSuite_unit_tests_dump.py | 9 ---------
4 files changed, 23 deletions(-)
diff --git a/framework/pmd_output.py b/framework/pmd_output.py
index aa9384d..80005e5 100644
--- a/framework/pmd_output.py
+++ b/framework/pmd_output.py
@@ -111,10 +111,6 @@ class PmdOutput():
self.coremask = create_mask(core_list)
command = "./%s/app/testpmd -c %s -n %d %s -- -i %s" \
% (self.dut.target, self.coremask, self.dut.get_memory_channels(), eal_param, param)
- if "cavium" in self.dut.nic_type:
- # thunder nicvf does not support hw vlan filter, the application crashes
- # without this option added
- command += " --disable-hw-vlan-filter"
out = self.dut.send_expect(command, "testpmd> ", 120)
self.command = command
# wait 10s to ensure links getting up before test start.
diff --git a/tests/TestSuite_dynamic_config.py b/tests/TestSuite_dynamic_config.py
index 4df1291..d11a6b1 100644
--- a/tests/TestSuite_dynamic_config.py
+++ b/tests/TestSuite_dynamic_config.py
@@ -78,9 +78,6 @@ class TestDynamicConfig(TestCase):
cmd = "./%s/app/testpmd -c %s -n 3 -- -i --rxpt=0 \
--rxht=0 --rxwt=0 --txpt=39 --txht=0 --txwt=0 --portmask=%s" % (self.target, self.coreMask, self.portMask)
- if "cavium" in self.dut.nic_type:
- cmd += " --disable-hw-vlan-filter"
-
self.dut.send_expect("%s" % cmd, "testpmd> ", 120)
# get dest address from self.target port
@@ -119,9 +116,6 @@ class TestDynamicConfig(TestCase):
cmd = "./%s/app/testpmd -c %s -n 3 -- -i --rxpt=0 \
--rxht=0 --rxwt=0 --txpt=39 --txht=0 --txwt=0 --portmask=%s" % (self.target, self.coreMask, self.portMask)
- if "cavium" in self.dut.nic_type:
- cmd += " --disable-hw-vlan-filter"
-
self.dut.send_expect("%s" % cmd, "testpmd> ", 120)
time.sleep(5)
self.dut.send_expect("start", "testpmd> ", 120)
diff --git a/tests/TestSuite_pmdpcap.py b/tests/TestSuite_pmdpcap.py
index eafd064..e0c4993 100644
--- a/tests/TestSuite_pmdpcap.py
+++ b/tests/TestSuite_pmdpcap.py
@@ -127,8 +127,6 @@ class TestPmdPcap(TestCase):
command = ("./{}/app/testpmd -c {} -n {} " +
"--vdev=eth_pcap0,rx_pcap={},tx_pcap={} " +
"-- -i --port-topology=chained --no-flush-rx")
- if "cavium" in self.dut.nic_type:
- command += " --disable-hw-vlan-filter"
self.dut.send_expect(command.format(self.target, core_mask,
self.memory_channel,
@@ -163,8 +161,6 @@ class TestPmdPcap(TestCase):
"--vdev=eth_pcap0,rx_pcap={},tx_pcap={} " +
"--vdev=eth_pcap1,rx_pcap={},tx_pcap={} " +
"-- -i --no-flush-rx")
- if "cavium" in self.dut.nic_type:
- command += " --disable-hw-vlan-filter"
self.dut.send_expect(command.format(self.target, core_mask,
self.memory_channel,
diff --git a/tests/TestSuite_unit_tests_dump.py b/tests/TestSuite_unit_tests_dump.py
index 84ecce7..74dac56 100644
--- a/tests/TestSuite_unit_tests_dump.py
+++ b/tests/TestSuite_unit_tests_dump.py
@@ -90,9 +90,6 @@ class TestUnitTestsDump(TestCase):
"""
cmd = "./%s/app/testpmd -n 1 -c f -- -i" % self.target
- if "cavium_a034" in self.dut.nic_type:
- cmd += " --disable-hw-vlan-filter"
-
self.dut.send_expect("%s" % cmd, "testpmd>", self.start_test_time)
out = self.dut.send_expect("dump_ring", "testpmd>", self.run_cmd_time)
self.dut.send_expect("quit", "# ")
@@ -110,9 +107,6 @@ class TestUnitTestsDump(TestCase):
"""
cmd = "./%s/app/testpmd -n 1 -c f -- -i" % self.target
- if "cavium_a034" in self.dut.nic_type:
- cmd += " --disable-hw-vlan-filter"
-
self.dut.send_expect("%s" % cmd, "testpmd>", self.start_test_time)
out = self.dut.send_expect("dump_mempool", "testpmd>", self.run_cmd_time * 2)
self.dut.send_expect("quit", "# ")
@@ -148,9 +142,6 @@ class TestUnitTestsDump(TestCase):
"""
cmd = "./%s/app/testpmd -n 1 -c f -- -i" % self.target
- if "cavium_a034" in self.dut.nic_type:
- cmd += " --disable-hw-vlan-filter"
-
self.dut.send_expect("%s" % cmd, "testpmd>", self.start_test_time)
out = self.dut.send_expect("dump_memzone", "testpmd>", self.run_cmd_time * 2)
self.dut.send_expect("quit", "# ")
--
1.7.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dts] [PATCH] disable-hw-vlan-filter: Removed flag in testpmd "--disable-hw-vlan-filter"
2019-01-03 12:39 [dts] [PATCH] disable-hw-vlan-filter: Removed flag in testpmd "--disable-hw-vlan-filter" Phanendra Vukkisala
@ 2019-01-07 8:46 ` Tu, Lijuan
0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2019-01-07 8:46 UTC (permalink / raw)
To: Phanendra Vukkisala, dts; +Cc: Vijaya Bhaskar Annayyolla, Faisal Masood
Applied, thanks
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Phanendra Vukkisala
> Sent: Thursday, January 3, 2019 8:39 PM
> To: dts@dpdk.org
> Cc: Vijaya Bhaskar Annayyolla <avijay@marvell.com>; Faisal Masood
> <fmasood@marvell.com>; Phanendra Vukkisala <pvukkisala@marvell.com>
> Subject: [dts] [PATCH] disable-hw-vlan-filter: Removed flag in testpmd
> "--disable-hw-vlan-filter"
>
> From: pvukkisala <pvukkisala@marvell.com>
>
> For cavium devices this flag was added before, but now testpmd is not
> supporting this flag, which is leading to failing tests on cavium devices. So
> removing unwanted flag
>
> Signed-off-by: phanendra,vukkisala <pvukkisala@marvell.com>
> ---
> framework/pmd_output.py | 4 ----
> tests/TestSuite_dynamic_config.py | 6 ------
> tests/TestSuite_pmdpcap.py | 4 ----
> tests/TestSuite_unit_tests_dump.py | 9 ---------
> 4 files changed, 23 deletions(-)
>
> diff --git a/framework/pmd_output.py b/framework/pmd_output.py index
> aa9384d..80005e5 100644
> --- a/framework/pmd_output.py
> +++ b/framework/pmd_output.py
> @@ -111,10 +111,6 @@ class PmdOutput():
> self.coremask = create_mask(core_list)
> command = "./%s/app/testpmd -c %s -n %d %s -- -i %s" \
> % (self.dut.target, self.coremask,
> self.dut.get_memory_channels(), eal_param, param)
> - if "cavium" in self.dut.nic_type:
> - # thunder nicvf does not support hw vlan filter, the
> application crashes
> - # without this option added
> - command += " --disable-hw-vlan-filter"
> out = self.dut.send_expect(command, "testpmd> ", 120)
> self.command = command
> # wait 10s to ensure links getting up before test start.
> diff --git a/tests/TestSuite_dynamic_config.py
> b/tests/TestSuite_dynamic_config.py
> index 4df1291..d11a6b1 100644
> --- a/tests/TestSuite_dynamic_config.py
> +++ b/tests/TestSuite_dynamic_config.py
> @@ -78,9 +78,6 @@ class TestDynamicConfig(TestCase):
> cmd = "./%s/app/testpmd -c %s -n 3 -- -i --rxpt=0 \
> --rxht=0 --rxwt=0 --txpt=39 --txht=0 --txwt=0 --portmask=%s" %
> (self.target, self.coreMask, self.portMask)
>
> - if "cavium" in self.dut.nic_type:
> - cmd += " --disable-hw-vlan-filter"
> -
> self.dut.send_expect("%s" % cmd, "testpmd> ", 120)
>
> # get dest address from self.target port @@ -119,9 +116,6 @@
> class TestDynamicConfig(TestCase):
> cmd = "./%s/app/testpmd -c %s -n 3 -- -i --rxpt=0 \
> --rxht=0 --rxwt=0 --txpt=39 --txht=0 --txwt=0 --portmask=%s" %
> (self.target, self.coreMask, self.portMask)
>
> - if "cavium" in self.dut.nic_type:
> - cmd += " --disable-hw-vlan-filter"
> -
> self.dut.send_expect("%s" % cmd, "testpmd> ", 120)
> time.sleep(5)
> self.dut.send_expect("start", "testpmd> ", 120) diff --git
> a/tests/TestSuite_pmdpcap.py b/tests/TestSuite_pmdpcap.py index
> eafd064..e0c4993 100644
> --- a/tests/TestSuite_pmdpcap.py
> +++ b/tests/TestSuite_pmdpcap.py
> @@ -127,8 +127,6 @@ class TestPmdPcap(TestCase):
> command = ("./{}/app/testpmd -c {} -n {} " +
> "--vdev=eth_pcap0,rx_pcap={},tx_pcap={} " +
> "-- -i --port-topology=chained --no-flush-rx")
> - if "cavium" in self.dut.nic_type:
> - command += " --disable-hw-vlan-filter"
>
> self.dut.send_expect(command.format(self.target, core_mask,
> self.memory_channel, @@ -163,8
> +161,6 @@ class TestPmdPcap(TestCase):
> "--vdev=eth_pcap0,rx_pcap={},tx_pcap={} " +
> "--vdev=eth_pcap1,rx_pcap={},tx_pcap={} " +
> "-- -i --no-flush-rx")
> - if "cavium" in self.dut.nic_type:
> - command += " --disable-hw-vlan-filter"
>
> self.dut.send_expect(command.format(self.target, core_mask,
>
> self.memory_channel, diff --git a/tests/TestSuite_unit_tests_dump.py
> b/tests/TestSuite_unit_tests_dump.py
> index 84ecce7..74dac56 100644
> --- a/tests/TestSuite_unit_tests_dump.py
> +++ b/tests/TestSuite_unit_tests_dump.py
> @@ -90,9 +90,6 @@ class TestUnitTestsDump(TestCase):
> """
> cmd = "./%s/app/testpmd -n 1 -c f -- -i" % self.target
>
> - if "cavium_a034" in self.dut.nic_type:
> - cmd += " --disable-hw-vlan-filter"
> -
> self.dut.send_expect("%s" % cmd, "testpmd>",
> self.start_test_time)
> out = self.dut.send_expect("dump_ring", "testpmd>",
> self.run_cmd_time)
> self.dut.send_expect("quit", "# ") @@ -110,9 +107,6 @@ class
> TestUnitTestsDump(TestCase):
> """
> cmd = "./%s/app/testpmd -n 1 -c f -- -i" % self.target
>
> - if "cavium_a034" in self.dut.nic_type:
> - cmd += " --disable-hw-vlan-filter"
> -
> self.dut.send_expect("%s" % cmd, "testpmd>",
> self.start_test_time)
> out = self.dut.send_expect("dump_mempool", "testpmd>",
> self.run_cmd_time * 2)
> self.dut.send_expect("quit", "# ") @@ -148,9 +142,6 @@ class
> TestUnitTestsDump(TestCase):
> """
> cmd = "./%s/app/testpmd -n 1 -c f -- -i" % self.target
>
> - if "cavium_a034" in self.dut.nic_type:
> - cmd += " --disable-hw-vlan-filter"
> -
> self.dut.send_expect("%s" % cmd, "testpmd>",
> self.start_test_time)
> out = self.dut.send_expect("dump_memzone", "testpmd>",
> self.run_cmd_time * 2)
> self.dut.send_expect("quit", "# ")
> --
> 1.7.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-07 8:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-03 12:39 [dts] [PATCH] disable-hw-vlan-filter: Removed flag in testpmd "--disable-hw-vlan-filter" Phanendra Vukkisala
2019-01-07 8:46 ` Tu, Lijuan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).