From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id D9B1C1B457 for ; Mon, 7 Jan 2019 09:46:09 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Jan 2019 00:46:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,450,1539673200"; d="scan'208";a="116034596" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga003.jf.intel.com with ESMTP; 07 Jan 2019 00:46:08 -0800 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 7 Jan 2019 00:46:08 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 7 Jan 2019 00:46:08 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.196]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.160]) with mapi id 14.03.0415.000; Mon, 7 Jan 2019 16:46:06 +0800 From: "Tu, Lijuan" To: Phanendra Vukkisala , "dts@dpdk.org" CC: Vijaya Bhaskar Annayyolla , Faisal Masood Thread-Topic: [PATCH] disable-hw-vlan-filter: Removed flag in testpmd "--disable-hw-vlan-filter" Thread-Index: AQHUo2FdLZnehtHVwUKpKRKycdKzr6WjhBBQ Date: Mon, 7 Jan 2019 08:46:05 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0B9FDF98@SHSMSX101.ccr.corp.intel.com> References: <1546519124-20339-1-git-send-email-pvukkisala@marvell.com> In-Reply-To: <1546519124-20339-1-git-send-email-pvukkisala@marvell.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDMwMzg0Y2QtMDczZi00YWRiLTkxMWYtYmZjNmRhYmE2YzIzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTWhueDEzRDBJNjdrdFhyem9Fd1UrY2lmQ3loTnR6RDFuRmlrZ0lIOE9SZTlLVGlCZHpBcXc0d3owcGVBVTI3byJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH] disable-hw-vlan-filter: Removed flag in testpmd "--disable-hw-vlan-filter" X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jan 2019 08:46:10 -0000 Applied, thanks > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Phanendra Vukkisala > Sent: Thursday, January 3, 2019 8:39 PM > To: dts@dpdk.org > Cc: Vijaya Bhaskar Annayyolla ; Faisal Masood > ; Phanendra Vukkisala > Subject: [dts] [PATCH] disable-hw-vlan-filter: Removed flag in testpmd > "--disable-hw-vlan-filter" >=20 > From: pvukkisala >=20 > For cavium devices this flag was added before, but now testpmd is not > supporting this flag, which is leading to failing tests on cavium devices= . So > removing unwanted flag >=20 > Signed-off-by: phanendra,vukkisala > --- > framework/pmd_output.py | 4 ---- > tests/TestSuite_dynamic_config.py | 6 ------ > tests/TestSuite_pmdpcap.py | 4 ---- > tests/TestSuite_unit_tests_dump.py | 9 --------- > 4 files changed, 23 deletions(-) >=20 > diff --git a/framework/pmd_output.py b/framework/pmd_output.py index > aa9384d..80005e5 100644 > --- a/framework/pmd_output.py > +++ b/framework/pmd_output.py > @@ -111,10 +111,6 @@ class PmdOutput(): > self.coremask =3D create_mask(core_list) > command =3D "./%s/app/testpmd -c %s -n %d %s -- -i %s" \ > % (self.dut.target, self.coremask, > self.dut.get_memory_channels(), eal_param, param) > - if "cavium" in self.dut.nic_type: > - # thunder nicvf does not support hw vlan filter, the > application crashes > - # without this option added > - command +=3D " --disable-hw-vlan-filter" > out =3D self.dut.send_expect(command, "testpmd> ", 120) > self.command =3D command > # wait 10s to ensure links getting up before test start. > diff --git a/tests/TestSuite_dynamic_config.py > b/tests/TestSuite_dynamic_config.py > index 4df1291..d11a6b1 100644 > --- a/tests/TestSuite_dynamic_config.py > +++ b/tests/TestSuite_dynamic_config.py > @@ -78,9 +78,6 @@ class TestDynamicConfig(TestCase): > cmd =3D "./%s/app/testpmd -c %s -n 3 -- -i --rxpt=3D0 \ > --rxht=3D0 --rxwt=3D0 --txpt=3D39 --txht=3D0 --txwt=3D0 --portma= sk=3D%s" % > (self.target, self.coreMask, self.portMask) >=20 > - if "cavium" in self.dut.nic_type: > - cmd +=3D " --disable-hw-vlan-filter" > - > self.dut.send_expect("%s" % cmd, "testpmd> ", 120) >=20 > # get dest address from self.target port @@ -119,9 +116,6 @@ > class TestDynamicConfig(TestCase): > cmd =3D "./%s/app/testpmd -c %s -n 3 -- -i --rxpt=3D0 \ > --rxht=3D0 --rxwt=3D0 --txpt=3D39 --txht=3D0 --txwt=3D0 --portma= sk=3D%s" % > (self.target, self.coreMask, self.portMask) >=20 > - if "cavium" in self.dut.nic_type: > - cmd +=3D " --disable-hw-vlan-filter" > - > self.dut.send_expect("%s" % cmd, "testpmd> ", 120) > time.sleep(5) > self.dut.send_expect("start", "testpmd> ", 120) diff --git > a/tests/TestSuite_pmdpcap.py b/tests/TestSuite_pmdpcap.py index > eafd064..e0c4993 100644 > --- a/tests/TestSuite_pmdpcap.py > +++ b/tests/TestSuite_pmdpcap.py > @@ -127,8 +127,6 @@ class TestPmdPcap(TestCase): > command =3D ("./{}/app/testpmd -c {} -n {} " + > "--vdev=3Deth_pcap0,rx_pcap=3D{},tx_pcap=3D{} " + > "-- -i --port-topology=3Dchained --no-flush-rx") > - if "cavium" in self.dut.nic_type: > - command +=3D " --disable-hw-vlan-filter" >=20 > self.dut.send_expect(command.format(self.target, core_mask, > self.memory_channel, @@ -163,8 > +161,6 @@ class TestPmdPcap(TestCase): > "--vdev=3Deth_pcap0,rx_pcap=3D{},tx_pcap=3D{} " + > "--vdev=3Deth_pcap1,rx_pcap=3D{},tx_pcap=3D{} " + > "-- -i --no-flush-rx") > - if "cavium" in self.dut.nic_type: > - command +=3D " --disable-hw-vlan-filter" >=20 > self.dut.send_expect(command.format(self.target, core_mask, >=20 > self.memory_channel, diff --git a/tests/TestSuite_unit_tests_dump.py > b/tests/TestSuite_unit_tests_dump.py > index 84ecce7..74dac56 100644 > --- a/tests/TestSuite_unit_tests_dump.py > +++ b/tests/TestSuite_unit_tests_dump.py > @@ -90,9 +90,6 @@ class TestUnitTestsDump(TestCase): > """ > cmd =3D "./%s/app/testpmd -n 1 -c f -- -i" % self.target >=20 > - if "cavium_a034" in self.dut.nic_type: > - cmd +=3D " --disable-hw-vlan-filter" > - > self.dut.send_expect("%s" % cmd, "testpmd>", > self.start_test_time) > out =3D self.dut.send_expect("dump_ring", "testpmd>", > self.run_cmd_time) > self.dut.send_expect("quit", "# ") @@ -110,9 +107,6 @@ class > TestUnitTestsDump(TestCase): > """ > cmd =3D "./%s/app/testpmd -n 1 -c f -- -i" % self.target >=20 > - if "cavium_a034" in self.dut.nic_type: > - cmd +=3D " --disable-hw-vlan-filter" > - > self.dut.send_expect("%s" % cmd, "testpmd>", > self.start_test_time) > out =3D self.dut.send_expect("dump_mempool", "testpmd>", > self.run_cmd_time * 2) > self.dut.send_expect("quit", "# ") @@ -148,9 +142,6 @@ class > TestUnitTestsDump(TestCase): > """ > cmd =3D "./%s/app/testpmd -n 1 -c f -- -i" % self.target >=20 > - if "cavium_a034" in self.dut.nic_type: > - cmd +=3D " --disable-hw-vlan-filter" > - > self.dut.send_expect("%s" % cmd, "testpmd>", > self.start_test_time) > out =3D self.dut.send_expect("dump_memzone", "testpmd>", > self.run_cmd_time * 2) > self.dut.send_expect("quit", "# ") > -- > 1.7.9.5