[dts] [PATCH] framework/crb: Corrected logic to identify cavium devices

[dts] [PATCH] framework/crb: Corrected logic to identify cavium devices

[Phanendra Vukkisala]

From: pvukkisala <pvukkisala@marvell.com>

Modified function used to get pci device speed, to improve execution
speed. Corrected comparision string

Signed-off-by: phanendra,vukkisala <pvukkisala@marvell.com>
---
 framework/crb.py |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/framework/crb.py b/framework/crb.py
index 97bebfe..a6eb69e 100644
--- a/framework/crb.py
+++ b/framework/crb.py
@@ -282,8 +282,8 @@ class Crb(object):
             #check if device is cavium and check its linkspeed, append only if it is 10G
             if "177d:" in match[i][1]:
                 linkspeed = "10000"
-                nic_linkspeed = self.send_command("cat /sys/bus/pci/devices/%s/net/*/speed" % match[i][0])
-                if nic_linkspeed == linkspeed:
+                nic_linkspeed = self.send_expect("cat /sys/bus/pci/devices/%s/net/*/speed" % match[i][0], "# ", alt_session=True)
+                if nic_linkspeed.split()[0] == linkspeed:
                     self.pci_devices_info.append((match[i][0], match[i][1]))
             else:
                 self.pci_devices_info.append((match[i][0], match[i][1]))
-- 
1.7.9.5

Re: [dts] [PATCH] framework/crb: Corrected logic to identify cavium devices

[Tu, Lijuan]

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Phanendra Vukkisala
> Sent: Thursday, January 3, 2019 8:24 PM
> To: dts@dpdk.org
> Cc: Vijaya Bhaskar Annayyolla <avijay@marvell.com>; Faisal Masood
> <fmasood@marvell.com>; Phanendra Vukkisala <pvukkisala@marvell.com>
> Subject: [dts] [PATCH] framework/crb: Corrected logic to identify cavium
> devices
> 
> From: pvukkisala <pvukkisala@marvell.com>
> 
> Modified function used to get pci device speed, to improve execution speed.
> Corrected comparision string
> 
> Signed-off-by: phanendra,vukkisala <pvukkisala@marvell.com>
> ---
>  framework/crb.py |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/framework/crb.py b/framework/crb.py index 97bebfe..a6eb69e
> 100644
> --- a/framework/crb.py
> +++ b/framework/crb.py
> @@ -282,8 +282,8 @@ class Crb(object):
>              #check if device is cavium and check its linkspeed, append
> only if it is 10G
>              if "177d:" in match[i][1]:
>                  linkspeed = "10000"
> -                nic_linkspeed = self.send_command("cat
> /sys/bus/pci/devices/%s/net/*/speed" % match[i][0])
> -                if nic_linkspeed == linkspeed:
> +                nic_linkspeed = self.send_expect("cat
> /sys/bus/pci/devices/%s/net/*/speed" % match[i][0], "# ", alt_session=True)
> +                if nic_linkspeed.split()[0] == linkspeed:
>                      self.pci_devices_info.append((match[i][0],
> match[i][1]))
>              else:
>                  self.pci_devices_info.append((match[i][0], match[i][1]))
> --
> 1.7.9.5