From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 23AFF1B471 for ; Mon, 7 Jan 2019 09:46:16 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Jan 2019 00:46:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,450,1539673200"; d="scan'208";a="123855405" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by FMSMGA003.fm.intel.com with ESMTP; 07 Jan 2019 00:46:15 -0800 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 7 Jan 2019 00:46:15 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 7 Jan 2019 00:46:15 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.196]) by shsmsx102.ccr.corp.intel.com ([169.254.2.63]) with mapi id 14.03.0415.000; Mon, 7 Jan 2019 16:46:13 +0800 From: "Tu, Lijuan" To: Phanendra Vukkisala , "dts@dpdk.org" CC: Vijaya Bhaskar Annayyolla , Faisal Masood Thread-Topic: [dts] [PATCH] framework/crb: Corrected logic to identify cavium devices Thread-Index: AQHUo18w2Oc4DBemTUqhHP2qxRXxr6WjhB2A Date: Mon, 7 Jan 2019 08:46:12 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0B9FDFA3@SHSMSX101.ccr.corp.intel.com> References: <1546518179-19493-1-git-send-email-pvukkisala@marvell.com> In-Reply-To: <1546518179-19493-1-git-send-email-pvukkisala@marvell.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTc1MmYxN2ItNmVkZi00NzljLTgzZDEtZjg3Y2IwYTQxZTdkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiaEN4Rlk1b0l3XC9nOG1BbmRWcWdwOTczWTdRSUVaSHBldmQ2XC9PeW9uZzh1VHBZTVFsd1lcLzV3dDJkZGFKcVk1cyJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH] framework/crb: Corrected logic to identify cavium devices X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jan 2019 08:46:17 -0000 Applied, thanks > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Phanendra Vukkisala > Sent: Thursday, January 3, 2019 8:24 PM > To: dts@dpdk.org > Cc: Vijaya Bhaskar Annayyolla ; Faisal Masood > ; Phanendra Vukkisala > Subject: [dts] [PATCH] framework/crb: Corrected logic to identify cavium > devices >=20 > From: pvukkisala >=20 > Modified function used to get pci device speed, to improve execution spee= d. > Corrected comparision string >=20 > Signed-off-by: phanendra,vukkisala > --- > framework/crb.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/framework/crb.py b/framework/crb.py index 97bebfe..a6eb69e > 100644 > --- a/framework/crb.py > +++ b/framework/crb.py > @@ -282,8 +282,8 @@ class Crb(object): > #check if device is cavium and check its linkspeed, append > only if it is 10G > if "177d:" in match[i][1]: > linkspeed =3D "10000" > - nic_linkspeed =3D self.send_command("cat > /sys/bus/pci/devices/%s/net/*/speed" % match[i][0]) > - if nic_linkspeed =3D=3D linkspeed: > + nic_linkspeed =3D self.send_expect("cat > /sys/bus/pci/devices/%s/net/*/speed" % match[i][0], "# ", alt_session=3DT= rue) > + if nic_linkspeed.split()[0] =3D=3D linkspeed: > self.pci_devices_info.append((match[i][0], > match[i][1])) > else: > self.pci_devices_info.append((match[i][0], match[i][1])) > -- > 1.7.9.5