From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: Rami Rosen <ramirose@gmail.com>, "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH] test_plans: fix a typo in 2 VLAN test plans
Date: Mon, 7 Jan 2019 08:49:48 +0000 [thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0B9FDFFE@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20181229123446.7701-1-ramirose@gmail.com>
Applied, thanks
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Rami Rosen
> Sent: Saturday, December 29, 2018 8:35 PM
> To: dts@dpdk.org
> Cc: Rami Rosen <ramirose@gmail.com>
> Subject: [dts] [PATCH] test_plans: fix a typo in 2 VLAN test plans
>
> This patch fixes typos in Dual Vlan test plan and in vlan ethertype config test
> plan.
>
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
> ---
> test_plans/dual_vlan_test_plan.rst | 16 ++++++++--------
> test_plans/vlan_ethertype_config_test_plan.rst | 4 ++--
> 2 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/test_plans/dual_vlan_test_plan.rst
> b/test_plans/dual_vlan_test_plan.rst
> index f828c18..3defc91 100644
> --- a/test_plans/dual_vlan_test_plan.rst
> +++ b/test_plans/dual_vlan_test_plan.rst
> @@ -152,14 +152,14 @@ Configure the traffic generator to send VLAN
> packets with the Tag Identifier
> ``1`` and send 1 packet on port ``A``.Verify that the VLAN packet cannot
> been
> received in port ``B``.
>
> -Test Case: Enable/Disable VLAN header striping
> +Test Case: Enable/Disable VLAN header stripping
> ==============================================
>
> Enable vlan packet forwarding on port ``0`` first::
>
> testpmd> vlan set filter off 0
>
> -Enable vlan header striping on port ``0``::
> +Enable vlan header stripping on port ``0``::
>
> testpmd> vlan set strip on 0
>
> @@ -184,7 +184,7 @@ Configure the traffic generator to send VLAN
> packets with the Tag Identifier ``1`` and send 1 packet on port ``A``. Verify
> that the packet without VLAN Tag Identifier can been received in port ``B``.
>
> -Disable vlan header striping on port ``0``::
> +Disable vlan header stripping on port ``0``::
>
> testpmd> vlan set strip off 0
>
> @@ -209,18 +209,18 @@ Configure the traffic generator to send VLAN
> packets with the Tag Identifier ``1`` and send 1 packet on port ``A``. Verify
> that the packet with VLAN Tag Identifier ``1`` can been received in port
> ``B``.
>
> -Test Case: Enable/Disable VLAN header striping in queue
> +Test Case: Enable/Disable VLAN header stripping in queue
> =======================================================
>
> Enable vlan packet forwarding on port ``0`` first::
>
> testpmd> vlan set filter off 0
>
> -Disable vlan header striping on port ``0``::
> +Disable vlan header stripping on port ``0``::
>
> testpmd> vlan set strip off 0
>
> -Disable vlan header striping in queue 0 on port ``0``::
> +Disable vlan header stripping in queue 0 on port ``0``::
>
> testpmd> vlan set stripq off 0,0
>
> @@ -229,7 +229,7 @@ Configure the traffic generator to send VLAN
> packets with the Tag Identifier Identifier ``1`` can been received in port
> ``B``.
>
>
> -Enable vlan header striping in queue 0 on port ``0``::
> +Enable vlan header stripping in queue 0 on port ``0``::
>
> testpmd> vlan set stripq on 0,0
>
> @@ -237,7 +237,7 @@ Configure the traffic generator to send VLAN
> packets with the Tag Identifier ``1`` and send 1 packet on port ``A``. Verify
> that the packet without VLAN Tag Identifier ``1`` can been received in port
> ``B``.
>
> -Enable vlan header striping on port ``0``.
> +Enable vlan header stripping on port ``0``.
>
> MISSING COMMAND
>
> diff --git a/test_plans/vlan_ethertype_config_test_plan.rst
> b/test_plans/vlan_ethertype_config_test_plan.rst
> index 9315e39..81b7d9b 100644
> --- a/test_plans/vlan_ethertype_config_test_plan.rst
> +++ b/test_plans/vlan_ethertype_config_test_plan.rst
> @@ -123,7 +123,7 @@ Test Case 3: test adding VLAN Tag Identifier with
> changing VLAN TPID 7. Send 1 packet with VLAN TPID 0xA100 and VLAN
> Tag 16 on port ``A``,
> Verify that the VLAN packet cannot be received in port ``B``.
>
> -Test Case 4: test VLAN header striping with changing VLAN TPID
> +Test Case 4: test VLAN header stripping with changing VLAN TPID
>
> ==============================================================
>
> 1. start testpmd, setup vlan filter off, vlan strip on, start in mac forwarding
> mode::
> @@ -144,7 +144,7 @@ Test Case 4: test VLAN header striping with changing
> VLAN TPID 4. Send 1 packet with VLAN TPID 0xA100 and VLAN Tag 16 on
> port ``A``.
> Verify that packet received in port ``B`` without VLAN Tag Identifier
>
> -5. Disable vlan header striping on port ``0``::
> +5. Disable vlan header stripping on port ``0``::
>
> testpmd> vlan set strip off 0
>
> --
> 2.19.2
prev parent reply other threads:[~2019-01-07 8:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-29 12:34 Rami Rosen
2019-01-07 8:49 ` Tu, Lijuan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0B9FDFFE@SHSMSX101.ccr.corp.intel.com \
--to=lijuan.tu@intel.com \
--cc=dts@dpdk.org \
--cc=ramirose@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).