test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH] test_plans: fix a typo in 2 VLAN test plans
@ 2018-12-29 12:34 Rami Rosen
  2019-01-07  8:49 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: Rami Rosen @ 2018-12-29 12:34 UTC (permalink / raw)
  To: dts; +Cc: Rami Rosen

This patch fixes typos in Dual Vlan test plan and in vlan ethertype config
test plan.

Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
 test_plans/dual_vlan_test_plan.rst             | 16 ++++++++--------
 test_plans/vlan_ethertype_config_test_plan.rst |  4 ++--
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/test_plans/dual_vlan_test_plan.rst b/test_plans/dual_vlan_test_plan.rst
index f828c18..3defc91 100644
--- a/test_plans/dual_vlan_test_plan.rst
+++ b/test_plans/dual_vlan_test_plan.rst
@@ -152,14 +152,14 @@ Configure the traffic generator to send VLAN packets with the Tag Identifier
  ``1`` and send 1 packet on port ``A``.Verify that the VLAN packet cannot been
  received in port ``B``.
 
-Test Case: Enable/Disable VLAN header striping
+Test Case: Enable/Disable VLAN header stripping
 ==============================================
 
 Enable vlan packet forwarding on port ``0`` first::
 
     testpmd> vlan set filter off 0
 
-Enable vlan header striping on port ``0``::
+Enable vlan header stripping on port ``0``::
 
     testpmd> vlan set strip on 0
 
@@ -184,7 +184,7 @@ Configure the traffic generator to send VLAN packets with the Tag Identifier
 ``1`` and send 1 packet on port ``A``. Verify that the packet without VLAN Tag
 Identifier can been received in port ``B``.
 
-Disable vlan header striping on port ``0``::
+Disable vlan header stripping on port ``0``::
 
     testpmd> vlan set strip off 0
 
@@ -209,18 +209,18 @@ Configure the traffic generator to send VLAN packets with the Tag Identifier
 ``1`` and send 1 packet on port ``A``. Verify that the packet with VLAN Tag
 Identifier ``1`` can been received in port ``B``.
 
-Test Case: Enable/Disable VLAN header striping in queue
+Test Case: Enable/Disable VLAN header stripping in queue
 =======================================================
 
 Enable vlan packet forwarding on port ``0`` first::
 
     testpmd> vlan set filter off 0
 
-Disable vlan header striping on port ``0``::
+Disable vlan header stripping on port ``0``::
 
     testpmd> vlan set strip off 0
 
-Disable vlan header striping in queue 0 on port ``0``::
+Disable vlan header stripping in queue 0 on port ``0``::
 
     testpmd> vlan set stripq off 0,0
 
@@ -229,7 +229,7 @@ Configure the traffic generator to send VLAN packets with the Tag Identifier
 Identifier ``1`` can been received in port ``B``.
 
 
-Enable vlan header striping in queue 0 on port ``0``::
+Enable vlan header stripping in queue 0 on port ``0``::
 
     testpmd> vlan set stripq on 0,0
 
@@ -237,7 +237,7 @@ Configure the traffic generator to send VLAN packets with the Tag Identifier
 ``1`` and send 1 packet on port ``A``. Verify that the packet without VLAN Tag
 Identifier ``1`` can been received in port ``B``.
 
-Enable vlan header striping on port ``0``.
+Enable vlan header stripping on port ``0``.
 
     MISSING COMMAND
 
diff --git a/test_plans/vlan_ethertype_config_test_plan.rst b/test_plans/vlan_ethertype_config_test_plan.rst
index 9315e39..81b7d9b 100644
--- a/test_plans/vlan_ethertype_config_test_plan.rst
+++ b/test_plans/vlan_ethertype_config_test_plan.rst
@@ -123,7 +123,7 @@ Test Case 3: test adding VLAN Tag Identifier with changing VLAN TPID
 7. Send 1 packet with VLAN TPID 0xA100 and VLAN Tag 16 on port ``A``,
    Verify that the VLAN packet cannot be received in port ``B``.
 
-Test Case 4: test VLAN header striping with changing VLAN TPID
+Test Case 4: test VLAN header stripping with changing VLAN TPID
 ==============================================================
 
 1. start testpmd, setup vlan filter off, vlan strip on, start in mac forwarding mode::
@@ -144,7 +144,7 @@ Test Case 4: test VLAN header striping with changing VLAN TPID
 4. Send 1 packet with VLAN TPID 0xA100 and VLAN Tag 16 on port ``A``.
 Verify that packet received in port ``B`` without VLAN Tag Identifier
 
-5. Disable vlan header striping on port ``0``::
+5. Disable vlan header stripping on port ``0``::
 
       testpmd> vlan set strip off 0
 
-- 
2.19.2

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH] test_plans: fix a typo in 2 VLAN test plans
  2018-12-29 12:34 [dts] [PATCH] test_plans: fix a typo in 2 VLAN test plans Rami Rosen
@ 2019-01-07  8:49 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2019-01-07  8:49 UTC (permalink / raw)
  To: Rami Rosen, dts

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Rami Rosen
> Sent: Saturday, December 29, 2018 8:35 PM
> To: dts@dpdk.org
> Cc: Rami Rosen <ramirose@gmail.com>
> Subject: [dts] [PATCH] test_plans: fix a typo in 2 VLAN test plans
> 
> This patch fixes typos in Dual Vlan test plan and in vlan ethertype config test
> plan.
> 
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
> ---
>  test_plans/dual_vlan_test_plan.rst             | 16 ++++++++--------
>  test_plans/vlan_ethertype_config_test_plan.rst |  4 ++--
>  2 files changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/test_plans/dual_vlan_test_plan.rst
> b/test_plans/dual_vlan_test_plan.rst
> index f828c18..3defc91 100644
> --- a/test_plans/dual_vlan_test_plan.rst
> +++ b/test_plans/dual_vlan_test_plan.rst
> @@ -152,14 +152,14 @@ Configure the traffic generator to send VLAN
> packets with the Tag Identifier
>   ``1`` and send 1 packet on port ``A``.Verify that the VLAN packet cannot
> been
>   received in port ``B``.
> 
> -Test Case: Enable/Disable VLAN header striping
> +Test Case: Enable/Disable VLAN header stripping
>  ==============================================
> 
>  Enable vlan packet forwarding on port ``0`` first::
> 
>      testpmd> vlan set filter off 0
> 
> -Enable vlan header striping on port ``0``::
> +Enable vlan header stripping on port ``0``::
> 
>      testpmd> vlan set strip on 0
> 
> @@ -184,7 +184,7 @@ Configure the traffic generator to send VLAN
> packets with the Tag Identifier  ``1`` and send 1 packet on port ``A``. Verify
> that the packet without VLAN Tag  Identifier can been received in port ``B``.
> 
> -Disable vlan header striping on port ``0``::
> +Disable vlan header stripping on port ``0``::
> 
>      testpmd> vlan set strip off 0
> 
> @@ -209,18 +209,18 @@ Configure the traffic generator to send VLAN
> packets with the Tag Identifier  ``1`` and send 1 packet on port ``A``. Verify
> that the packet with VLAN Tag  Identifier ``1`` can been received in port
> ``B``.
> 
> -Test Case: Enable/Disable VLAN header striping in queue
> +Test Case: Enable/Disable VLAN header stripping in queue
>  =======================================================
> 
>  Enable vlan packet forwarding on port ``0`` first::
> 
>      testpmd> vlan set filter off 0
> 
> -Disable vlan header striping on port ``0``::
> +Disable vlan header stripping on port ``0``::
> 
>      testpmd> vlan set strip off 0
> 
> -Disable vlan header striping in queue 0 on port ``0``::
> +Disable vlan header stripping in queue 0 on port ``0``::
> 
>      testpmd> vlan set stripq off 0,0
> 
> @@ -229,7 +229,7 @@ Configure the traffic generator to send VLAN
> packets with the Tag Identifier  Identifier ``1`` can been received in port
> ``B``.
> 
> 
> -Enable vlan header striping in queue 0 on port ``0``::
> +Enable vlan header stripping in queue 0 on port ``0``::
> 
>      testpmd> vlan set stripq on 0,0
> 
> @@ -237,7 +237,7 @@ Configure the traffic generator to send VLAN
> packets with the Tag Identifier  ``1`` and send 1 packet on port ``A``. Verify
> that the packet without VLAN Tag  Identifier ``1`` can been received in port
> ``B``.
> 
> -Enable vlan header striping on port ``0``.
> +Enable vlan header stripping on port ``0``.
> 
>      MISSING COMMAND
> 
> diff --git a/test_plans/vlan_ethertype_config_test_plan.rst
> b/test_plans/vlan_ethertype_config_test_plan.rst
> index 9315e39..81b7d9b 100644
> --- a/test_plans/vlan_ethertype_config_test_plan.rst
> +++ b/test_plans/vlan_ethertype_config_test_plan.rst
> @@ -123,7 +123,7 @@ Test Case 3: test adding VLAN Tag Identifier with
> changing VLAN TPID  7. Send 1 packet with VLAN TPID 0xA100 and VLAN
> Tag 16 on port ``A``,
>     Verify that the VLAN packet cannot be received in port ``B``.
> 
> -Test Case 4: test VLAN header striping with changing VLAN TPID
> +Test Case 4: test VLAN header stripping with changing VLAN TPID
> 
> ==============================================================
> 
>  1. start testpmd, setup vlan filter off, vlan strip on, start in mac forwarding
> mode::
> @@ -144,7 +144,7 @@ Test Case 4: test VLAN header striping with changing
> VLAN TPID  4. Send 1 packet with VLAN TPID 0xA100 and VLAN Tag 16 on
> port ``A``.
>  Verify that packet received in port ``B`` without VLAN Tag Identifier
> 
> -5. Disable vlan header striping on port ``0``::
> +5. Disable vlan header stripping on port ``0``::
> 
>        testpmd> vlan set strip off 0
> 
> --
> 2.19.2

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-01-07  8:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-29 12:34 [dts] [PATCH] test_plans: fix a typo in 2 VLAN test plans Rami Rosen
2019-01-07  8:49 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).