test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH] conf/test_case_supportlist.json: Avoid showing fail for not supported NICs
@ 2019-01-04  8:59 Phanendra Vukkisala
  2019-01-07  8:43 ` Tu, Lijuan
  2019-01-08 12:46 ` [dts] [PATCH v2] conf/test_case_checklist.json: Avoid showing fail for not supported tests Phanendra Vukkisala
  0 siblings, 2 replies; 6+ messages in thread
From: Phanendra Vukkisala @ 2019-01-04  8:59 UTC (permalink / raw)
  To: dts; +Cc: Vijaya Bhaskar Annayyolla, Faisal Masood, Phanendra Vukkisala

From: pvukkisala <pvukkisala@marvell.com>

Result is showing as fail for not supported NICs. Added proper fix to avoid
show test result as fail instead of N/A.

Signed-off-by: phanendra,vukkisala <pvukkisala@marvell.com>
---
 conf/test_case_supportlist.json |  201 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 201 insertions(+)

diff --git a/conf/test_case_supportlist.json b/conf/test_case_supportlist.json
index 571bb5c..c128c95 100644
--- a/conf/test_case_supportlist.json
+++ b/conf/test_case_supportlist.json
@@ -633,5 +633,206 @@
             "Bug ID": "",
             "Comments": "This case only support on FVL"
         }
+    ],
+    "syn_filter": [
+        {
+            "OS": [
+                "ALL"
+            ],
+            "NIC": [
+                "niantic", 
+                "kawela_4", 
+                "bartonhills", 
+                "powerville" 
+            ],
+            "Target": [
+                "ALL"
+            ],
+            "Bug ID": "",
+            "Comments": "This case not support on this NIC"
+        }
+    ],
+    "priority_filter": [
+        {
+            "OS": [
+                "ALL"
+            ],
+            "NIC": [
+                "niantic", 
+                "kawela_4", 
+                "bartonhills", 
+                "powerville" 
+            ],
+            "Target": [
+                "ALL"
+            ],
+            "Bug ID": "",
+            "Comments": "This case not support on this NIC"
+        }
+    ],
+    "five_tuple_filter": [
+        {
+            "OS": [
+                "ALL"
+            ],
+            "NIC": [
+                "niantic", 
+                "kawela_4"
+            ],
+            "Target": [
+                "ALL"
+            ],
+            "Bug ID": "",
+            "Comments": "This case only support only on Niantic and kawela_4"
+        }
+    ],
+    "ethertype_filter": [
+        {
+            "OS": [
+                "ALL"
+            ],
+            "NIC": [
+                "niantic", 
+                "kawela_4", 
+                "bartonhills",
+                "powerville", 
+                "fortville_eagle", 
+                "fortville_spirit",
+                "fortville_spirit_single", 
+                "fortpark_TLV", 
+                "fortville_25g"
+            ],
+            "Target": [
+                "ALL"
+            ],
+            "Bug ID": "",
+            "Comments": "This case is not supported on this NIC"
+        }
+    ],
+    "multiple_filters_10GB": [
+        {
+            "OS": [
+                "ALL"
+            ],
+            "NIC": [
+                "niantic" 
+            ],
+            "Target": [
+                "ALL"
+            ],
+            "Bug ID": "",
+            "Comments": "This case only support with Niantic NIC"
+        }
+    ],
+    "twotuple_filter": [
+        {
+            "OS": [
+                "ALL"
+            ],
+            "NIC": [
+                "powerville",
+                "bartonhills" 
+            ],
+            "Target": [
+                "ALL"
+            ],
+            "Bug ID": "",
+            "Comments": "This case is not supported on this NIC"
+        }
+    ],
+    "flex_filter": [
+        {
+            "OS": [
+                "ALL"
+            ],
+            "NIC": [
+                "powerville",
+                "bartonhills" 
+            ],
+            "Target": [
+                "ALL"
+            ],
+            "Bug ID": "",
+            "Comments": "This case is not supported on this NIC"
+        }
+    ],
+    "multiple_filters_1GB": [
+        {
+            "OS": [
+                "ALL"
+            ],
+            "NIC": [
+                "powerville",
+                "kawela_4",
+                "bartonhills" 
+            ],
+            "Target": [
+                "ALL"
+            ],
+            "Bug ID": "",
+            "Comments": "This case is not supported on this NIC"
+        }
+    ],
+    "128_queues": [
+        {
+            "OS": [
+                "ALL"
+            ],
+            "NIC": [
+                "niantic",
+                "ironpond",
+                "twinpond",
+                "twinville",
+                "sageville",
+                "sagepond",
+                "magnolia_park",
+                "springfountain"
+            ],
+            "Target": [
+                "ALL"
+            ],
+            "Bug ID": "",
+            "Comments": "This case only support with ixgbe driver"
+        }
+    ],
+    "rss_key_size": [
+        {
+            "OS": [
+                "ALL"
+            ],
+            "NIC": [
+                "fortville_eagle",
+                "fortville_spirit",
+                "fortville_spirit_single",
+                "fortville_25g",
+                "niantic",
+                "redrockcanyou",
+                "atwood",
+                "boulderrapid",
+                "fortpark_TLV"
+            ],
+            "Target": [
+                "ALL"
+            ],
+            "Bug ID": "",
+            "Comments": "This case is not supported on this NIC"
+        }
+    ],
+    "vlan_qinq_tpid": [
+        {
+            "OS": [
+                "ALL"
+            ],
+            "NIC": [
+                "fortville_eagle",
+                "fortville_spirit",
+                "fortville_spirit_single"
+            ],
+            "Target": [
+                "ALL"
+            ],
+            "Bug ID": "",
+            "Comments": "This case is not supported on this NIC"
+        }
     ]
 }
-- 
1.7.9.5

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dts] [PATCH] conf/test_case_supportlist.json: Avoid showing fail for not supported NICs
  2019-01-04  8:59 [dts] [PATCH] conf/test_case_supportlist.json: Avoid showing fail for not supported NICs Phanendra Vukkisala
@ 2019-01-07  8:43 ` Tu, Lijuan
  2019-01-07  9:38   ` Phanendra Vukkisala
  2019-01-08 12:46 ` [dts] [PATCH v2] conf/test_case_checklist.json: Avoid showing fail for not supported tests Phanendra Vukkisala
  1 sibling, 1 reply; 6+ messages in thread
From: Tu, Lijuan @ 2019-01-07  8:43 UTC (permalink / raw)
  To: Phanendra Vukkisala, dts; +Cc: Vijaya Bhaskar Annayyolla, Faisal Masood

Hi phanendra,

If test cases are not supported by some NICs, I should be added into test_case_checklist.json.
Only the cases that added in supportlist.json are supported by these specific NICs.

For instance: the syn_filter you added in the support list.
Syn_filter is only supported by Niantic, kawela_r, bartonhills, powerville, but not supported by Fortville and other NICes.

"syn_filter": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "niantic",
> +                "kawela_4",
> +                "bartonhills",
> +                "powerville"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case not support on this NIC"
> +        }
> +    ],


> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Phanendra Vukkisala
> Sent: Friday, January 4, 2019 5:00 PM
> To: dts@dpdk.org
> Cc: Vijaya Bhaskar Annayyolla <avijay@marvell.com>; Faisal Masood
> <fmasood@marvell.com>; Phanendra Vukkisala <pvukkisala@marvell.com>
> Subject: [dts] [PATCH] conf/test_case_supportlist.json: Avoid showing fail
> for not supported NICs
> 
> From: pvukkisala <pvukkisala@marvell.com>
> 
> Result is showing as fail for not supported NICs. Added proper fix to avoid
> show test result as fail instead of N/A.
> 
> Signed-off-by: phanendra,vukkisala <pvukkisala@marvell.com>
> ---
>  conf/test_case_supportlist.json |  201
> +++++++++++++++++++++++++++++++++++++++
>  1 file changed, 201 insertions(+)
> 
> diff --git a/conf/test_case_supportlist.json
> b/conf/test_case_supportlist.json index 571bb5c..c128c95 100644
> --- a/conf/test_case_supportlist.json
> +++ b/conf/test_case_supportlist.json
> @@ -633,5 +633,206 @@
>              "Bug ID": "",
>              "Comments": "This case only support on FVL"
>          }
> +    ],
> +    "syn_filter": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "niantic",
> +                "kawela_4",
> +                "bartonhills",
> +                "powerville"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case not support on this NIC"
> +        }
> +    ],
> +    "priority_filter": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "niantic",
> +                "kawela_4",
> +                "bartonhills",
> +                "powerville"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case not support on this NIC"
> +        }
> +    ],
> +    "five_tuple_filter": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "niantic",
> +                "kawela_4"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case only support only on Niantic and
> kawela_4"
> +        }
> +    ],
> +    "ethertype_filter": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "niantic",
> +                "kawela_4",
> +                "bartonhills",
> +                "powerville",
> +                "fortville_eagle",
> +                "fortville_spirit",
> +                "fortville_spirit_single",
> +                "fortpark_TLV",
> +                "fortville_25g"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case is not supported on this NIC"
> +        }
> +    ],
> +    "multiple_filters_10GB": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "niantic"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case only support with Niantic NIC"
> +        }
> +    ],
> +    "twotuple_filter": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "powerville",
> +                "bartonhills"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case is not supported on this NIC"
> +        }
> +    ],
> +    "flex_filter": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "powerville",
> +                "bartonhills"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case is not supported on this NIC"
> +        }
> +    ],
> +    "multiple_filters_1GB": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "powerville",
> +                "kawela_4",
> +                "bartonhills"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case is not supported on this NIC"
> +        }
> +    ],
> +    "128_queues": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "niantic",
> +                "ironpond",
> +                "twinpond",
> +                "twinville",
> +                "sageville",
> +                "sagepond",
> +                "magnolia_park",
> +                "springfountain"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case only support with ixgbe driver"
> +        }
> +    ],
> +    "rss_key_size": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "fortville_eagle",
> +                "fortville_spirit",
> +                "fortville_spirit_single",
> +                "fortville_25g",
> +                "niantic",
> +                "redrockcanyou",
> +                "atwood",
> +                "boulderrapid",
> +                "fortpark_TLV"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case is not supported on this NIC"
> +        }
> +    ],
> +    "vlan_qinq_tpid": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "fortville_eagle",
> +                "fortville_spirit",
> +                "fortville_spirit_single"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case is not supported on this NIC"
> +        }
>      ]
>  }
> --
> 1.7.9.5

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dts] [PATCH] conf/test_case_supportlist.json: Avoid showing fail for not supported NICs
  2019-01-07  8:43 ` Tu, Lijuan
@ 2019-01-07  9:38   ` Phanendra Vukkisala
  2019-01-07 10:42     ` Tu, Lijuan
  0 siblings, 1 reply; 6+ messages in thread
From: Phanendra Vukkisala @ 2019-01-07  9:38 UTC (permalink / raw)
  To: Tu, Lijuan, dts; +Cc: Vijaya Bhaskar Annayyolla, Faisal Masood

[-- Attachment #1: Type: text/plain, Size: 8852 bytes --]

Hi Lijuan,


I can add these tests in "test_case_checklist.json" as these are not supported on cavium devices.

But in the test scripts, I can see the tests are supported only on few NICs I have mentioned in supportlist.json


For instance: the syn_filter test is supported by Niantic, kawela_4, bartonhills, powerville. I have taken this reference from test scripts.

Below is test script snippet, because of verifying inside test case the result of test is showing as Failed instead of Not Applicable for other NICs.


    def test_syn_filter(self):
        """
        Enable receipt of SYN packets
        """
        self.verify(self.nic in ["niantic", "kawela_4", "bartonhills", "powerville"], "%s nic not support syn filter" % self.nic)



If you fell I should update in "test_case_checklist.json" for cavium device only, please let me know I will do the same.


Regards,

Phanendra

________________________________
From: Tu, Lijuan <lijuan.tu@intel.com>
Sent: Monday, January 7, 2019 2:13:59 PM
To: Phanendra Vukkisala; dts@dpdk.org
Cc: Vijaya Bhaskar Annayyolla; Faisal Masood
Subject: [EXT] RE: [PATCH] conf/test_case_supportlist.json: Avoid showing fail for not supported NICs

External Email

----------------------------------------------------------------------
Hi phanendra,

If test cases are not supported by some NICs, I should be added into test_case_checklist.json.
Only the cases that added in supportlist.json are supported by these specific NICs.

For instance: the syn_filter you added in the support list.
Syn_filter is only supported by Niantic, kawela_r, bartonhills, powerville, but not supported by Fortville and other NICes.

"syn_filter": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "niantic",
> +                "kawela_4",
> +                "bartonhills",
> +                "powerville"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case not support on this NIC"
> +        }
> +    ],


> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Phanendra Vukkisala
> Sent: Friday, January 4, 2019 5:00 PM
> To: dts@dpdk.org
> Cc: Vijaya Bhaskar Annayyolla <avijay@marvell.com>; Faisal Masood
> <fmasood@marvell.com>; Phanendra Vukkisala <pvukkisala@marvell.com>
> Subject: [dts] [PATCH] conf/test_case_supportlist.json: Avoid showing fail
> for not supported NICs
>
> From: pvukkisala <pvukkisala@marvell.com>
>
> Result is showing as fail for not supported NICs. Added proper fix to avoid
> show test result as fail instead of N/A.
>
> Signed-off-by: phanendra,vukkisala <pvukkisala@marvell.com>
> ---
>  conf/test_case_supportlist.json |  201
> +++++++++++++++++++++++++++++++++++++++
>  1 file changed, 201 insertions(+)
>
> diff --git a/conf/test_case_supportlist.json
> b/conf/test_case_supportlist.json index 571bb5c..c128c95 100644
> --- a/conf/test_case_supportlist.json
> +++ b/conf/test_case_supportlist.json
> @@ -633,5 +633,206 @@
>              "Bug ID": "",
>              "Comments": "This case only support on FVL"
>          }
> +    ],
> +    "syn_filter": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "niantic",
> +                "kawela_4",
> +                "bartonhills",
> +                "powerville"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case not support on this NIC"
> +        }
> +    ],
> +    "priority_filter": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "niantic",
> +                "kawela_4",
> +                "bartonhills",
> +                "powerville"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case not support on this NIC"
> +        }
> +    ],
> +    "five_tuple_filter": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "niantic",
> +                "kawela_4"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case only support only on Niantic and
> kawela_4"
> +        }
> +    ],
> +    "ethertype_filter": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "niantic",
> +                "kawela_4",
> +                "bartonhills",
> +                "powerville",
> +                "fortville_eagle",
> +                "fortville_spirit",
> +                "fortville_spirit_single",
> +                "fortpark_TLV",
> +                "fortville_25g"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case is not supported on this NIC"
> +        }
> +    ],
> +    "multiple_filters_10GB": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "niantic"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case only support with Niantic NIC"
> +        }
> +    ],
> +    "twotuple_filter": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "powerville",
> +                "bartonhills"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case is not supported on this NIC"
> +        }
> +    ],
> +    "flex_filter": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "powerville",
> +                "bartonhills"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case is not supported on this NIC"
> +        }
> +    ],
> +    "multiple_filters_1GB": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "powerville",
> +                "kawela_4",
> +                "bartonhills"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case is not supported on this NIC"
> +        }
> +    ],
> +    "128_queues": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "niantic",
> +                "ironpond",
> +                "twinpond",
> +                "twinville",
> +                "sageville",
> +                "sagepond",
> +                "magnolia_park",
> +                "springfountain"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case only support with ixgbe driver"
> +        }
> +    ],
> +    "rss_key_size": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "fortville_eagle",
> +                "fortville_spirit",
> +                "fortville_spirit_single",
> +                "fortville_25g",
> +                "niantic",
> +                "redrockcanyou",
> +                "atwood",
> +                "boulderrapid",
> +                "fortpark_TLV"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case is not supported on this NIC"
> +        }
> +    ],
> +    "vlan_qinq_tpid": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "fortville_eagle",
> +                "fortville_spirit",
> +                "fortville_spirit_single"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case is not supported on this NIC"
> +        }
>      ]
>  }
> --
> 1.7.9.5


[-- Attachment #2: Type: text/html, Size: 32335 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dts] [PATCH] conf/test_case_supportlist.json: Avoid showing fail for not supported NICs
  2019-01-07  9:38   ` Phanendra Vukkisala
@ 2019-01-07 10:42     ` Tu, Lijuan
  0 siblings, 0 replies; 6+ messages in thread
From: Tu, Lijuan @ 2019-01-07 10:42 UTC (permalink / raw)
  To: Phanendra Vukkisala, dts; +Cc: Vijaya Bhaskar Annayyolla, Faisal Masood

[-- Attachment #1: Type: text/plain, Size: 9804 bytes --]

Prefer that add these tests in "test_case_checklist.json" and at the same time filter the NICs that both mentioned in the scripts and your last patch.
In other words, it's make sense to filter these cases that could not be supported by some NICes, both intel NICs and cavium.

I 'd like to clarify that checklist is considered as blacklist while support list constitutes whitelist.

From: Phanendra Vukkisala [mailto:pvukkisala@marvell.com]
Sent: Monday, January 7, 2019 5:39 PM
To: Tu, Lijuan <lijuan.tu@intel.com>; dts@dpdk.org
Cc: Vijaya Bhaskar Annayyolla <avijay@marvell.com>; Faisal Masood <fmasood@marvell.com>
Subject: Re: [PATCH] conf/test_case_supportlist.json: Avoid showing fail for not supported NICs


Hi Lijuan,



I can add these tests in "test_case_checklist.json" as these are not supported on cavium devices.

But in the test scripts, I can see the tests are supported only on few NICs I have mentioned in supportlist.json



For instance: the syn_filter test is supported by Niantic, kawela_4, bartonhills, powerville. I have taken this reference from test scripts.

Below is test script snippet, because of verifying inside test case the result of test is showing as Failed instead of Not Applicable for other NICs.


    def test_syn_filter(self):
        """
        Enable receipt of SYN packets
        """
        self.verify(self.nic in ["niantic", "kawela_4", "bartonhills", "powerville"], "%s nic not support syn filter" % self.nic)




If you fell I should update in "test_case_checklist.json" for cavium device only, please let me know I will do the same.



Regards,

Phanendra

________________________________
From: Tu, Lijuan <lijuan.tu@intel.com<mailto:lijuan.tu@intel.com>>
Sent: Monday, January 7, 2019 2:13:59 PM
To: Phanendra Vukkisala; dts@dpdk.org<mailto:dts@dpdk.org>
Cc: Vijaya Bhaskar Annayyolla; Faisal Masood
Subject: [EXT] RE: [PATCH] conf/test_case_supportlist.json: Avoid showing fail for not supported NICs

External Email

----------------------------------------------------------------------
Hi phanendra,

If test cases are not supported by some NICs, I should be added into test_case_checklist.json.
Only the cases that added in supportlist.json are supported by these specific NICs.

For instance: the syn_filter you added in the support list.
Syn_filter is only supported by Niantic, kawela_r, bartonhills, powerville, but not supported by Fortville and other NICes.

"syn_filter": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "niantic",
> +                "kawela_4",
> +                "bartonhills",
> +                "powerville"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case not support on this NIC"
> +        }
> +    ],


> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Phanendra Vukkisala
> Sent: Friday, January 4, 2019 5:00 PM
> To: dts@dpdk.org<mailto:dts@dpdk.org>
> Cc: Vijaya Bhaskar Annayyolla <avijay@marvell.com<mailto:avijay@marvell.com>>; Faisal Masood
> <fmasood@marvell.com<mailto:fmasood@marvell.com>>; Phanendra Vukkisala <pvukkisala@marvell.com<mailto:pvukkisala@marvell.com>>
> Subject: [dts] [PATCH] conf/test_case_supportlist.json: Avoid showing fail
> for not supported NICs
>
> From: pvukkisala <pvukkisala@marvell.com<mailto:pvukkisala@marvell.com>>
>
> Result is showing as fail for not supported NICs. Added proper fix to avoid
> show test result as fail instead of N/A.
>
> Signed-off-by: phanendra,vukkisala <pvukkisala@marvell.com<mailto:pvukkisala@marvell.com>>
> ---
>  conf/test_case_supportlist.json |  201
> +++++++++++++++++++++++++++++++++++++++
>  1 file changed, 201 insertions(+)
>
> diff --git a/conf/test_case_supportlist.json
> b/conf/test_case_supportlist.json index 571bb5c..c128c95 100644
> --- a/conf/test_case_supportlist.json
> +++ b/conf/test_case_supportlist.json
> @@ -633,5 +633,206 @@
>              "Bug ID": "",
>              "Comments": "This case only support on FVL"
>          }
> +    ],
> +    "syn_filter": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "niantic",
> +                "kawela_4",
> +                "bartonhills",
> +                "powerville"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case not support on this NIC"
> +        }
> +    ],
> +    "priority_filter": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "niantic",
> +                "kawela_4",
> +                "bartonhills",
> +                "powerville"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case not support on this NIC"
> +        }
> +    ],
> +    "five_tuple_filter": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "niantic",
> +                "kawela_4"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case only support only on Niantic and
> kawela_4"
> +        }
> +    ],
> +    "ethertype_filter": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "niantic",
> +                "kawela_4",
> +                "bartonhills",
> +                "powerville",
> +                "fortville_eagle",
> +                "fortville_spirit",
> +                "fortville_spirit_single",
> +                "fortpark_TLV",
> +                "fortville_25g"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case is not supported on this NIC"
> +        }
> +    ],
> +    "multiple_filters_10GB": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "niantic"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case only support with Niantic NIC"
> +        }
> +    ],
> +    "twotuple_filter": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "powerville",
> +                "bartonhills"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case is not supported on this NIC"
> +        }
> +    ],
> +    "flex_filter": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "powerville",
> +                "bartonhills"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case is not supported on this NIC"
> +        }
> +    ],
> +    "multiple_filters_1GB": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "powerville",
> +                "kawela_4",
> +                "bartonhills"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case is not supported on this NIC"
> +        }
> +    ],
> +    "128_queues": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "niantic",
> +                "ironpond",
> +                "twinpond",
> +                "twinville",
> +                "sageville",
> +                "sagepond",
> +                "magnolia_park",
> +                "springfountain"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case only support with ixgbe driver"
> +        }
> +    ],
> +    "rss_key_size": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "fortville_eagle",
> +                "fortville_spirit",
> +                "fortville_spirit_single",
> +                "fortville_25g",
> +                "niantic",
> +                "redrockcanyou",
> +                "atwood",
> +                "boulderrapid",
> +                "fortpark_TLV"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case is not supported on this NIC"
> +        }
> +    ],
> +    "vlan_qinq_tpid": [
> +        {
> +            "OS": [
> +                "ALL"
> +            ],
> +            "NIC": [
> +                "fortville_eagle",
> +                "fortville_spirit",
> +                "fortville_spirit_single"
> +            ],
> +            "Target": [
> +                "ALL"
> +            ],
> +            "Bug ID": "",
> +            "Comments": "This case is not supported on this NIC"
> +        }
>      ]
>  }
> --
> 1.7.9.5

[-- Attachment #2: Type: text/html, Size: 34654 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dts] [PATCH v2] conf/test_case_checklist.json: Avoid showing fail for not supported tests
  2019-01-04  8:59 [dts] [PATCH] conf/test_case_supportlist.json: Avoid showing fail for not supported NICs Phanendra Vukkisala
  2019-01-07  8:43 ` Tu, Lijuan
@ 2019-01-08 12:46 ` Phanendra Vukkisala
  2019-01-09 11:08   ` Lijuan Tu
  1 sibling, 1 reply; 6+ messages in thread
From: Phanendra Vukkisala @ 2019-01-08 12:46 UTC (permalink / raw)
  To: dts; +Cc: Vijaya Bhaskar Annayyolla, Faisal Masood, Phanendra Vukkisala

From: pvukkisala <pvukkisala@marvell.com>

Adding cavium device in checklist file for not supported tests.

Signed-off-by: phanendra,vukkisala <pvukkisala@marvell.com>
---
 conf/test_case_checklist.json |   24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)

diff --git a/conf/test_case_checklist.json b/conf/test_case_checklist.json
index fe20eb3..b4e7126 100644
--- a/conf/test_case_checklist.json
+++ b/conf/test_case_checklist.json
@@ -16,6 +16,8 @@
                 "springfountain",
                 "twinpond",
                 "kawela_4",
+                "cavium_a034",
+                "cavium_a011",
                 "fortpark_TLV"
             ],
             "Target": [
@@ -34,6 +36,8 @@
                 "springville",
                 "ironpond",
                 "springfountain",
+                "cavium_a034",
+                "cavium_a011",
                 "twinpond"
             ],
             "Target": [
@@ -59,6 +63,8 @@
                 "ironpond",
                 "springfountain",
                 "twinpond",
+                "cavium_a034",
+                "cavium_a011",
                 "fortpark_TLV"
             ],
             "Target": [
@@ -84,6 +90,8 @@
                 "ironpond",
                 "springfountain",
                 "twinpond",
+                "cavium_a034",
+                "cavium_a011",
                 "fortpark_TLV"
             ],
             "Target": [
@@ -130,6 +138,8 @@
                 "ironpond",
                 "springfountain",
                 "twinpond",
+                "cavium_a034",
+                "cavium_a011",
                 "fortpark_TLV"
             ],
             "Target": [
@@ -154,6 +164,8 @@
                 "ironpond",
                 "springfountain",
                 "twinpond",
+                "cavium_a034",
+                "cavium_a011",
                 "fortpark_TLV"
             ],
             "Target": [
@@ -177,6 +189,8 @@
                 "ironpond",
                 "springfountain",
                 "twinpond",
+                "cavium_a034",
+                "cavium_a011",
                 "fortpark_TLV"
             ], 
             "Target": [
@@ -200,6 +214,8 @@
                 "ironpond",
                 "springfountain",
                 "twinpond",
+                "cavium_a034",
+                "cavium_a011",
                 "fortpark_TLV"
             ],
             "Target": [
@@ -225,6 +241,8 @@
                 "ironpond",
                 "springfountain",
                 "twinpond",
+                "cavium_a034",
+                "cavium_a011",
                 "fortpark_TLV"
             ],
             "Target": [
@@ -534,7 +552,7 @@
                 "springfountain",
                 "twinpond",
                 "cavium_a034",
-                "cavium_0011"
+                "cavium_a011"
             ],
             "Target": [
                 "ALL"
@@ -833,6 +851,8 @@
                 "springville",
                 "ironpond",
                 "springfountain",
+                "cavium_a034",
+                "cavium_a011",
                 "twinpond"
             ],
             "Target": [
@@ -2050,6 +2070,8 @@
                 "fortville_eagle",
                 "fortville_spirit",
                 "fortville_spirit_single",
+                "cavium_a034",
+                "cavium_a011",
                 "fortville_25g"
             ],
             "Target": [
-- 
1.7.9.5

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dts] [PATCH v2] conf/test_case_checklist.json: Avoid showing fail for not supported tests
  2019-01-08 12:46 ` [dts] [PATCH v2] conf/test_case_checklist.json: Avoid showing fail for not supported tests Phanendra Vukkisala
@ 2019-01-09 11:08   ` Lijuan Tu
  0 siblings, 0 replies; 6+ messages in thread
From: Lijuan Tu @ 2019-01-09 11:08 UTC (permalink / raw)
  To: Phanendra Vukkisala, dts; +Cc: Vijaya Bhaskar Annayyolla, Faisal Masood

Applied, thanks


On 2019年01月08日 20:46, Phanendra Vukkisala wrote:
> From: pvukkisala <pvukkisala@marvell.com>
>
> Adding cavium device in checklist file for not supported tests.
>
> Signed-off-by: phanendra,vukkisala <pvukkisala@marvell.com>
> ---
>   conf/test_case_checklist.json |   24 +++++++++++++++++++++++-
>   1 file changed, 23 insertions(+), 1 deletion(-)
>
> diff --git a/conf/test_case_checklist.json b/conf/test_case_checklist.json
> index fe20eb3..b4e7126 100644
> --- a/conf/test_case_checklist.json
> +++ b/conf/test_case_checklist.json
> @@ -16,6 +16,8 @@
>                   "springfountain",
>                   "twinpond",
>                   "kawela_4",
> +                "cavium_a034",
> +                "cavium_a011",
>                   "fortpark_TLV"
>               ],
>               "Target": [
> @@ -34,6 +36,8 @@
>                   "springville",
>                   "ironpond",
>                   "springfountain",
> +                "cavium_a034",
> +                "cavium_a011",
>                   "twinpond"
>               ],
>               "Target": [
> @@ -59,6 +63,8 @@
>                   "ironpond",
>                   "springfountain",
>                   "twinpond",
> +                "cavium_a034",
> +                "cavium_a011",
>                   "fortpark_TLV"
>               ],
>               "Target": [
> @@ -84,6 +90,8 @@
>                   "ironpond",
>                   "springfountain",
>                   "twinpond",
> +                "cavium_a034",
> +                "cavium_a011",
>                   "fortpark_TLV"
>               ],
>               "Target": [
> @@ -130,6 +138,8 @@
>                   "ironpond",
>                   "springfountain",
>                   "twinpond",
> +                "cavium_a034",
> +                "cavium_a011",
>                   "fortpark_TLV"
>               ],
>               "Target": [
> @@ -154,6 +164,8 @@
>                   "ironpond",
>                   "springfountain",
>                   "twinpond",
> +                "cavium_a034",
> +                "cavium_a011",
>                   "fortpark_TLV"
>               ],
>               "Target": [
> @@ -177,6 +189,8 @@
>                   "ironpond",
>                   "springfountain",
>                   "twinpond",
> +                "cavium_a034",
> +                "cavium_a011",
>                   "fortpark_TLV"
>               ],
>               "Target": [
> @@ -200,6 +214,8 @@
>                   "ironpond",
>                   "springfountain",
>                   "twinpond",
> +                "cavium_a034",
> +                "cavium_a011",
>                   "fortpark_TLV"
>               ],
>               "Target": [
> @@ -225,6 +241,8 @@
>                   "ironpond",
>                   "springfountain",
>                   "twinpond",
> +                "cavium_a034",
> +                "cavium_a011",
>                   "fortpark_TLV"
>               ],
>               "Target": [
> @@ -534,7 +552,7 @@
>                   "springfountain",
>                   "twinpond",
>                   "cavium_a034",
> -                "cavium_0011"
> +                "cavium_a011"
>               ],
>               "Target": [
>                   "ALL"
> @@ -833,6 +851,8 @@
>                   "springville",
>                   "ironpond",
>                   "springfountain",
> +                "cavium_a034",
> +                "cavium_a011",
>                   "twinpond"
>               ],
>               "Target": [
> @@ -2050,6 +2070,8 @@
>                   "fortville_eagle",
>                   "fortville_spirit",
>                   "fortville_spirit_single",
> +                "cavium_a034",
> +                "cavium_a011",
>                   "fortville_25g"
>               ],
>               "Target": [

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-01-09  2:45 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-04  8:59 [dts] [PATCH] conf/test_case_supportlist.json: Avoid showing fail for not supported NICs Phanendra Vukkisala
2019-01-07  8:43 ` Tu, Lijuan
2019-01-07  9:38   ` Phanendra Vukkisala
2019-01-07 10:42     ` Tu, Lijuan
2019-01-08 12:46 ` [dts] [PATCH v2] conf/test_case_checklist.json: Avoid showing fail for not supported tests Phanendra Vukkisala
2019-01-09 11:08   ` Lijuan Tu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).