From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 45EB51B44B for ; Mon, 7 Jan 2019 11:42:48 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Jan 2019 02:42:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,450,1539673200"; d="scan'208,217";a="104533921" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga007.jf.intel.com with ESMTP; 07 Jan 2019 02:42:44 -0800 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 7 Jan 2019 02:42:44 -0800 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 7 Jan 2019 02:42:43 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.196]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.85]) with mapi id 14.03.0415.000; Mon, 7 Jan 2019 18:42:41 +0800 From: "Tu, Lijuan" To: Phanendra Vukkisala , "dts@dpdk.org" CC: Vijaya Bhaskar Annayyolla , Faisal Masood Thread-Topic: [PATCH] conf/test_case_supportlist.json: Avoid showing fail for not supported NICs Thread-Index: AQHUpAvUWhMdRlWTUUy7hKP0alVWwaWjf4iwgAADzSuAABvzIA== Date: Mon, 7 Jan 2019 10:42:40 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0B9FE200@SHSMSX101.ccr.corp.intel.com> References: <1546592352-22633-1-git-send-email-pvukkisala@marvell.com>, <8CE3E05A3F976642AAB0F4675D0AD20E0B9FDF6B@SHSMSX101.ccr.corp.intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmMzNDA2NGMtYmRkZS00NjJiLWFhM2YtNTMzYzFlNzVjY2RjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiOElUVWJHTWpIYmNjQTdjbzhRN3ZRNmgxSWNkeDZna1dycGlNeEUwZ2FRZWY5XC93M2h6Vkpna0pLM0hOMHNJZmwifQ== x-originating-ip: [10.239.127.40] Content-Type: multipart/alternative; boundary="_000_8CE3E05A3F976642AAB0F4675D0AD20E0B9FE200SHSMSX101ccrcor_" MIME-Version: 1.0 Subject: Re: [dts] [PATCH] conf/test_case_supportlist.json: Avoid showing fail for not supported NICs X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jan 2019 10:42:53 -0000 --_000_8CE3E05A3F976642AAB0F4675D0AD20E0B9FE200SHSMSX101ccrcor_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Prefer that add these tests in "test_case_checklist.json" and at the same t= ime filter the NICs that both mentioned in the scripts and your last patch. In other words, it's make sense to filter these cases that could not be sup= ported by some NICes, both intel NICs and cavium. I 'd like to clarify that checklist is considered as blacklist while suppor= t list constitutes whitelist. From: Phanendra Vukkisala [mailto:pvukkisala@marvell.com] Sent: Monday, January 7, 2019 5:39 PM To: Tu, Lijuan ; dts@dpdk.org Cc: Vijaya Bhaskar Annayyolla ; Faisal Masood Subject: Re: [PATCH] conf/test_case_supportlist.json: Avoid showing fail fo= r not supported NICs Hi Lijuan, I can add these tests in "test_case_checklist.json" as these are not suppor= ted on cavium devices. But in the test scripts, I can see the tests are supported only on few NICs= I have mentioned in supportlist.json For instance: the syn_filter test is supported by Niantic, kawela_4, barton= hills, powerville. I have taken this reference from test scripts. Below is test script snippet, because of verifying inside test case the res= ult of test is showing as Failed instead of Not Applicable for other NICs. def test_syn_filter(self): """ Enable receipt of SYN packets """ self.verify(self.nic in ["niantic", "kawela_4", "bartonhills", "pow= erville"], "%s nic not support syn filter" % self.nic) If you fell I should update in "test_case_checklist.json" for cavium device= only, please let me know I will do the same. Regards, Phanendra ________________________________ From: Tu, Lijuan > Sent: Monday, January 7, 2019 2:13:59 PM To: Phanendra Vukkisala; dts@dpdk.org Cc: Vijaya Bhaskar Annayyolla; Faisal Masood Subject: [EXT] RE: [PATCH] conf/test_case_supportlist.json: Avoid showing f= ail for not supported NICs External Email ---------------------------------------------------------------------- Hi phanendra, If test cases are not supported by some NICs, I should be added into test_c= ase_checklist.json. Only the cases that added in supportlist.json are supported by these specif= ic NICs. For instance: the syn_filter you added in the support list. Syn_filter is only supported by Niantic, kawela_r, bartonhills, powerville,= but not supported by Fortville and other NICes. "syn_filter": [ > + { > + "OS": [ > + "ALL" > + ], > + "NIC": [ > + "niantic", > + "kawela_4", > + "bartonhills", > + "powerville" > + ], > + "Target": [ > + "ALL" > + ], > + "Bug ID": "", > + "Comments": "This case not support on this NIC" > + } > + ], > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Phanendra Vukkisala > Sent: Friday, January 4, 2019 5:00 PM > To: dts@dpdk.org > Cc: Vijaya Bhaskar Annayyolla >; Faisal Masood > >; Phanendra Vukkisala > > Subject: [dts] [PATCH] conf/test_case_supportlist.json: Avoid showing fai= l > for not supported NICs > > From: pvukkisala > > > Result is showing as fail for not supported NICs. Added proper fix to avo= id > show test result as fail instead of N/A. > > Signed-off-by: phanendra,vukkisala > > --- > conf/test_case_supportlist.json | 201 > +++++++++++++++++++++++++++++++++++++++ > 1 file changed, 201 insertions(+) > > diff --git a/conf/test_case_supportlist.json > b/conf/test_case_supportlist.json index 571bb5c..c128c95 100644 > --- a/conf/test_case_supportlist.json > +++ b/conf/test_case_supportlist.json > @@ -633,5 +633,206 @@ > "Bug ID": "", > "Comments": "This case only support on FVL" > } > + ], > + "syn_filter": [ > + { > + "OS": [ > + "ALL" > + ], > + "NIC": [ > + "niantic", > + "kawela_4", > + "bartonhills", > + "powerville" > + ], > + "Target": [ > + "ALL" > + ], > + "Bug ID": "", > + "Comments": "This case not support on this NIC" > + } > + ], > + "priority_filter": [ > + { > + "OS": [ > + "ALL" > + ], > + "NIC": [ > + "niantic", > + "kawela_4", > + "bartonhills", > + "powerville" > + ], > + "Target": [ > + "ALL" > + ], > + "Bug ID": "", > + "Comments": "This case not support on this NIC" > + } > + ], > + "five_tuple_filter": [ > + { > + "OS": [ > + "ALL" > + ], > + "NIC": [ > + "niantic", > + "kawela_4" > + ], > + "Target": [ > + "ALL" > + ], > + "Bug ID": "", > + "Comments": "This case only support only on Niantic and > kawela_4" > + } > + ], > + "ethertype_filter": [ > + { > + "OS": [ > + "ALL" > + ], > + "NIC": [ > + "niantic", > + "kawela_4", > + "bartonhills", > + "powerville", > + "fortville_eagle", > + "fortville_spirit", > + "fortville_spirit_single", > + "fortpark_TLV", > + "fortville_25g" > + ], > + "Target": [ > + "ALL" > + ], > + "Bug ID": "", > + "Comments": "This case is not supported on this NIC" > + } > + ], > + "multiple_filters_10GB": [ > + { > + "OS": [ > + "ALL" > + ], > + "NIC": [ > + "niantic" > + ], > + "Target": [ > + "ALL" > + ], > + "Bug ID": "", > + "Comments": "This case only support with Niantic NIC" > + } > + ], > + "twotuple_filter": [ > + { > + "OS": [ > + "ALL" > + ], > + "NIC": [ > + "powerville", > + "bartonhills" > + ], > + "Target": [ > + "ALL" > + ], > + "Bug ID": "", > + "Comments": "This case is not supported on this NIC" > + } > + ], > + "flex_filter": [ > + { > + "OS": [ > + "ALL" > + ], > + "NIC": [ > + "powerville", > + "bartonhills" > + ], > + "Target": [ > + "ALL" > + ], > + "Bug ID": "", > + "Comments": "This case is not supported on this NIC" > + } > + ], > + "multiple_filters_1GB": [ > + { > + "OS": [ > + "ALL" > + ], > + "NIC": [ > + "powerville", > + "kawela_4", > + "bartonhills" > + ], > + "Target": [ > + "ALL" > + ], > + "Bug ID": "", > + "Comments": "This case is not supported on this NIC" > + } > + ], > + "128_queues": [ > + { > + "OS": [ > + "ALL" > + ], > + "NIC": [ > + "niantic", > + "ironpond", > + "twinpond", > + "twinville", > + "sageville", > + "sagepond", > + "magnolia_park", > + "springfountain" > + ], > + "Target": [ > + "ALL" > + ], > + "Bug ID": "", > + "Comments": "This case only support with ixgbe driver" > + } > + ], > + "rss_key_size": [ > + { > + "OS": [ > + "ALL" > + ], > + "NIC": [ > + "fortville_eagle", > + "fortville_spirit", > + "fortville_spirit_single", > + "fortville_25g", > + "niantic", > + "redrockcanyou", > + "atwood", > + "boulderrapid", > + "fortpark_TLV" > + ], > + "Target": [ > + "ALL" > + ], > + "Bug ID": "", > + "Comments": "This case is not supported on this NIC" > + } > + ], > + "vlan_qinq_tpid": [ > + { > + "OS": [ > + "ALL" > + ], > + "NIC": [ > + "fortville_eagle", > + "fortville_spirit", > + "fortville_spirit_single" > + ], > + "Target": [ > + "ALL" > + ], > + "Bug ID": "", > + "Comments": "This case is not supported on this NIC" > + } > ] > } > -- > 1.7.9.5 --_000_8CE3E05A3F976642AAB0F4675D0AD20E0B9FE200SHSMSX101ccrcor_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Prefer that add these = tests in “test_case_checklist.json” and at the same time filter= the NICs that both mentioned in the scripts and your last patch.

In other words, itR= 17;s make sense to filter these cases that could not be supported by some N= ICes, both intel NICs and cavium.

 

I ‘d like to cla= rify that checklist is considered as blacklist while support list constitut= es whitelist.

 

From: Phanendra Vukkisala [mailto:pvukkisala@= marvell.com]
Sent: Monday, January 7, 2019 5:39 PM
To: Tu, Lijuan <lijuan.tu@intel.com>; dts@dpdk.org
Cc: Vijaya Bhaskar Annayyolla <avijay@marvell.com>; Faisal Mas= ood <fmasood@marvell.com>
Subject: Re: [PATCH] conf/test_case_supportlist.json: Avoid showing = fail for not supported NICs

 

Hi Lijuan,

 

I can add these tests in "test_case_checklist.jso= n" as these are not supported on cavium devices.

But in the test scripts, I can see the tests are suppo= rted only on few NICs I have mentioned in supportlist.json

 

For instance: the syn_filter test is supported by Nian= tic, kawela_4, bartonhills, powerville. I have taken this reference from te= st scripts.

Below is test script snippet, because of verifying ins= ide test case the result of test is showing as Failed instead of Not Applic= able for other NICs.

 

    def test_syn_filter(se= lf):
        ""&q= uot;
        Enable receipt= of SYN packets
        ""&q= uot;
        self.verify(se= lf.nic in ["niantic", "kawela_4", "bartonhills&quo= t;, "powerville"], "%s nic not support syn filter" % se= lf.nic)

 

 

If you fell I should update in "test_case_ch= ecklist.json" for cavium device only, please let me know I will do the= same.

 

Regards,=

Phanendra

From: Tu, Lijuan <lijuan.tu@intel.com>
Sent: Monday, January 7, 2019 2:13:59 PM
To: Phanendra Vukkisala; dts@dpdk.or= g
Cc: Vijaya Bhaskar Annayyolla; Faisal Masood
Subject: [EXT] RE: [PATCH] conf/test_case_supportlist.json: Avoid sh= owing fail for not supported NICs

 

External Email

----------------------------------------------------------------------
Hi phanendra,

If test cases are not supported by some NICs, I should be added into test_c= ase_checklist.json.
Only the cases that added in supportlist.json are supported by these specif= ic NICs.

For instance: the syn_filter you added in the support list.
Syn_filter is only supported by Niantic, kawela_r, bartonhills, powerville,= but not supported by Fortville and other NICes.

"syn_filter": [
> +        {
> +           = ; "OS": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "NIC": [
> +           = ;     "niantic",
> +           = ;     "kawela_4",
> +           = ;     "bartonhills",
> +           = ;     "powerville"
> +           = ; ],
> +           = ; "Target": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "Bug ID": "",
> +           = ; "Comments": "This case not support on this NIC"
> +        }
> +    ],


> -----Original Message-----
> From: dts [= mailto:dts-bounces@dpdk.org] On Behalf Of Phanendra Vukkisala
> Sent: Friday, January 4, 2019 5:00 PM
> To: dts@dpdk.org
> Cc: Vijaya Bhaskar Annayyolla <avijay@marvell.com>; Faisal Masood
> <fmasood@marvell.com>= ; Phanendra Vukkisala <pvukkis= ala@marvell.com>
> Subject: [dts] [PATCH] conf/test_case_supportlist.json: Avoid showing = fail
> for not supported NICs
>
> From: pvukkisala <pvukkis= ala@marvell.com>
>
> Result is showing as fail for not supported NICs. Added proper fix to = avoid
> show test result as fail instead of N/A.
>
> Signed-off-by: phanendra,vukkisala <pvukkisala@marvell.com>
> ---
>  conf/test_case_supportlist.json |  201
> ++++++++++++++= +++++++++++++++= ++++++++++
>  1 file changed, 201 insertions(+)
>
> diff --git a/conf/test_case_supportlist.json
> b/conf/test_case_supportlist.json index 571bb5c..c128c95 100644
> --- a/conf/test_case_supportlist.json
> +++ b/conf/test_case_supportlist.json
> @@ -633,5 +633,206 @@
>            = ;  "Bug ID": "",
>            = ;  "Comments": "This case only support on FVL"
>          }
> +    ],
> +    "syn_filter": [
> +        {
> +           = ; "OS": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "NIC": [
> +           = ;     "niantic",
> +           = ;     "kawela_4",
> +           = ;     "bartonhills",
> +           = ;     "powerville"
> +           = ; ],
> +           = ; "Target": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "Bug ID": "",
> +           = ; "Comments": "This case not support on this NIC"
> +        }
> +    ],
> +    "priority_filter": [
> +        {
> +           = ; "OS": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "NIC": [
> +           = ;     "niantic",
> +           = ;     "kawela_4",
> +           = ;     "bartonhills",
> +           = ;     "powerville"
> +           = ; ],
> +           = ; "Target": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "Bug ID": "",
> +           = ; "Comments": "This case not support on this NIC"
> +        }
> +    ],
> +    "five_tuple_filter": [
> +        {
> +           = ; "OS": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "NIC": [
> +           = ;     "niantic",
> +           = ;     "kawela_4"
> +           = ; ],
> +           = ; "Target": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "Bug ID": "",
> +           = ; "Comments": "This case only support only on Niantic and > kawela_4"
> +        }
> +    ],
> +    "ethertype_filter": [
> +        {
> +           = ; "OS": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "NIC": [
> +           = ;     "niantic",
> +           = ;     "kawela_4",
> +           = ;     "bartonhills",
> +           = ;     "powerville",
> +           = ;     "fortville_eagle",
> +           = ;     "fortville_spirit",
> +           = ;     "fortville_spirit_single",
> +           = ;     "fortpark_TLV",
> +           = ;     "fortville_25g"
> +           = ; ],
> +           = ; "Target": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "Bug ID": "",
> +           = ; "Comments": "This case is not supported on this NIC"<= br> > +        }
> +    ],
> +    "multiple_filters_10GB": [
> +        {
> +           = ; "OS": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "NIC": [
> +           = ;     "niantic"
> +           = ; ],
> +           = ; "Target": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "Bug ID": "",
> +           = ; "Comments": "This case only support with Niantic NIC"=
> +        }
> +    ],
> +    "twotuple_filter": [
> +        {
> +           = ; "OS": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "NIC": [
> +           = ;     "powerville",
> +           = ;     "bartonhills"
> +           = ; ],
> +           = ; "Target": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "Bug ID": "",
> +           = ; "Comments": "This case is not supported on this NIC"<= br> > +        }
> +    ],
> +    "flex_filter": [
> +        {
> +           = ; "OS": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "NIC": [
> +           = ;     "powerville",
> +           = ;     "bartonhills"
> +           = ; ],
> +           = ; "Target": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "Bug ID": "",
> +           = ; "Comments": "This case is not supported on this NIC"<= br> > +        }
> +    ],
> +    "multiple_filters_1GB": [
> +        {
> +           = ; "OS": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "NIC": [
> +           = ;     "powerville",
> +           = ;     "kawela_4",
> +           = ;     "bartonhills"
> +           = ; ],
> +           = ; "Target": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "Bug ID": "",
> +           = ; "Comments": "This case is not supported on this NIC"<= br> > +        }
> +    ],
> +    "128_queues": [
> +        {
> +           = ; "OS": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "NIC": [
> +           = ;     "niantic",
> +           = ;     "ironpond",
> +           = ;     "twinpond",
> +           = ;     "twinville",
> +           = ;     "sageville",
> +           = ;     "sagepond",
> +           = ;     "magnolia_park",
> +           = ;     "springfountain"
> +           = ; ],
> +           = ; "Target": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "Bug ID": "",
> +           = ; "Comments": "This case only support with ixgbe driver"= ;
> +        }
> +    ],
> +    "rss_key_size": [
> +        {
> +           = ; "OS": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "NIC": [
> +           = ;     "fortville_eagle",
> +           = ;     "fortville_spirit",
> +           = ;     "fortville_spirit_single",
> +           = ;     "fortville_25g",
> +           = ;     "niantic",
> +           = ;     "redrockcanyou",
> +           = ;     "atwood",
> +           = ;     "boulderrapid",
> +           = ;     "fortpark_TLV"
> +           = ; ],
> +           = ; "Target": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "Bug ID": "",
> +           = ; "Comments": "This case is not supported on this NIC"<= br> > +        }
> +    ],
> +    "vlan_qinq_tpid": [
> +        {
> +           = ; "OS": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "NIC": [
> +           = ;     "fortville_eagle",
> +           = ;     "fortville_spirit",
> +           = ;     "fortville_spirit_single"
> +           = ; ],
> +           = ; "Target": [
> +           = ;     "ALL"
> +           = ; ],
> +           = ; "Bug ID": "",
> +           = ; "Comments": "This case is not supported on this NIC"<= br> > +        }
>      ]
>  }
> --
> 1.7.9.5

--_000_8CE3E05A3F976642AAB0F4675D0AD20E0B9FE200SHSMSX101ccrcor_--