From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 11DBF1B959 for ; Fri, 11 Jan 2019 02:32:33 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jan 2019 17:32:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,463,1539673200"; d="scan'208";a="310886382" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga005.fm.intel.com with ESMTP; 10 Jan 2019 17:32:32 -0800 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 10 Jan 2019 17:32:32 -0800 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 10 Jan 2019 17:32:31 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.196]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.239]) with mapi id 14.03.0415.000; Fri, 11 Jan 2019 09:32:29 +0800 From: "Tu, Lijuan" To: "Zhu, WenhuiX" , "dts@dpdk.org" CC: "Zhu, WenhuiX" Thread-Topic: [dts] [PATCH V2] tests/dual_vlan check if the port is up Thread-Index: AQHUn08HJbUbMGk2jEmb1eGHMy5JoKWpWVxg Date: Fri, 11 Jan 2019 01:32:28 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0B9FFD32@SHSMSX101.ccr.corp.intel.com> References: <1546071645-14591-1-git-send-email-wenhuix.zhu@intel.com> In-Reply-To: <1546071645-14591-1-git-send-email-wenhuix.zhu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzM4YmU2ZWUtMWE1Ni00YWEzLWE2MGQtZGQzMGRmYTg1ZjRiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUGtqWUJweVlqK05IR09OdWlrcUI2WGExUlI1QkR5amlvOCtrRHNWQm5GMU9XQXcwYnBmVERRelpTWDJSakFhZSJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V2] tests/dual_vlan check if the port is up X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jan 2019 01:32:34 -0000 Could you change an accurate name of show_port? The readers can't get your = objective through your function name. Through your function codes, I got you want to verify the link status, so = suggest you call it verify_link_up > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhuwenhui > Sent: Saturday, December 29, 2018 4:21 PM > To: dts@dpdk.org > Cc: Zhu, WenhuiX > Subject: [dts] [PATCH V2] tests/dual_vlan check if the port is up >=20 > The port is down when the packet is sent. After "start", make sure the po= rt is > really open, and then proceed to the next step. >=20 > Signed-off-by: zhuwenhui > --- > tests/TestSuite_dual_vlan.py | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) >=20 > diff --git a/tests/TestSuite_dual_vlan.py b/tests/TestSuite_dual_vlan.py = index > 994ac42..cbb87d4 100644 > --- a/tests/TestSuite_dual_vlan.py > +++ b/tests/TestSuite_dual_vlan.py > @@ -40,6 +40,7 @@ Test the support of Dual VLAN Offload Features by Poll > Mode Drivers. > import utils > import random > import re > +import time >=20 > txvlan =3D 3 > outvlan =3D 1 > @@ -182,6 +183,16 @@ class TestDualVlan(TestCase): > else: > self.verify("%s %s" % (mode, modeName[mode]) in out, "%s= setting > error" % mode) >=20 > + def show_port(self): > + out =3D self.dut.send_expect("show port info all", "testpmd> ") > + global port_time_up > + port_time_up =3D 0 > + while (port_time_up <=3D 10) and ("Link status: down" in out): > + time.sleep(1) > + out =3D self.dut.send_expect("show port info all", "testpmd>= ") > + port_time_up +=3D 1 > + self.verify("Link status: down" not in out, "Port open failed") [Lijuan] Port open and link status are two different concepts, suggest chan= ge to "Port %s Link down, please check your link" % port_id > + > def multimode_test(self, caseIndex): > """ > Setup Strip/Filter/Extend/Insert enable/disable for synthetic te= st. > @@ -200,6 +211,7 @@ class TestDualVlan(TestCase): > self.dut.send_expect('tx_vlan set %s %s' % (dutTxPortId, txv= lan), > "testpmd> ") > self.dut.send_expect('port start all', "testpmd> ") > self.dut.send_expect('start', "testpmd> ") > + self.show_port() >=20 > configMode =3D "Strip %s, filter %s 0x1, extend %s, insert %s" %= (temp[0], > temp[1], temp[2], "on" if (caseDef & txCase) !=3D 0 else "off") >=20 > @@ -218,6 +230,7 @@ class TestDualVlan(TestCase): > self.dut.send_expect('tx_vlan reset %s' % dutTxPortId, "= testpmd> ") > self.dut.send_expect('port start all', "testpmd> ") > self.dut.send_expect('start', "testpmd> ") > + self.show_port() >=20 > else: > self.dut.send_expect('rx_vlan add %s %s' % (invlan, dutRxPor= tId), > "testpmd> ") @@ -230,6 +243,7 @@ class TestDualVlan(TestCase): > self.dut.send_expect('tx_vlan reset %s' % dutTxPortId, "= testpmd> ") > self.dut.send_expect('port start all', "testpmd> ") > self.dut.send_expect('start', "testpmd> ") > + self.show_port() > self.dut.send_expect('rx_vlan rm %s %s' % (invlan, dutRxPort= Id), "testpmd> > ") > self.dut.send_expect('rx_vlan rm %s %s' % (outvlan, dutRxPor= tId), > "testpmd> ") >=20 > @@ -364,6 +378,7 @@ class TestDualVlan(TestCase): > self.dut.send_expect("tx_vlan set %s %s" % (dutTxPortId, txvlan)= , "testpmd> > ") > self.dut.send_expect("port start all", "testpmd> ") > self.dut.send_expect("start", "testpmd> ") > + self.show_port() >=20 > self.vlan_send_packet() > out =3D self.get_tcpdump_package() @@ -374,6 +389,7 @@ class > TestDualVlan(TestCase): > self.dut.send_expect("tx_vlan reset %s" % dutTxPortId, "testpmd>= ") > self.dut.send_expect("port start all", "testpmd> ") > self.dut.send_expect("start", "testpmd> ") > + self.show_port() >=20 > self.vlan_send_packet() > out =3D self.get_tcpdump_package() > -- > 2.17.2