test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: Phanendra Vukkisala <pvukkisala@marvell.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Cc: Vijaya Bhaskar Annayyolla <avijay@marvell.com>,
	Faisal Masood <fmasood@marvell.com>
Subject: Re: [dts] [PATCH] max_lcores: Fix max lcore value consideration for cavium devices
Date: Fri, 11 Jan 2019 02:17:54 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0B9FFEA9@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1547098045-8737-1-git-send-email-pvukkisala@marvell.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Phanendra Vukkisala
> Sent: Thursday, January 10, 2019 1:28 PM
> To: dts@dpdk.org
> Cc: Vijaya Bhaskar Annayyolla <avijay@marvell.com>; Faisal Masood
> <fmasood@marvell.com>; Phanendra Vukkisala <pvukkisala@marvell.com>
> Subject: [dts] [PATCH] max_lcores: Fix max lcore value consideration for cavium
> devices
> 
> From: pvukkisala <pvukkisala@marvell.com>
> 
> Cavium devices have different number of cores on different boards, so lcores
> provided in configuration file may have more number of cores than cores
> available on board. So taking which ever value is minimum to avoid failures.
> 
> Signed-off-by: phanendra,vukkisala <pvukkisala@marvell.com>
> ---
>  tests/TestSuite_coremask.py    |    2 +-
>  tests/TestSuite_hello_world.py |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_coremask.py b/tests/TestSuite_coremask.py index
> 1eb9286..921dc31 100644
> --- a/tests/TestSuite_coremask.py
> +++ b/tests/TestSuite_coremask.py
> @@ -54,7 +54,7 @@ class TestCoremask(TestCase):
>          config_max_lcore =
> self.dut.get_def_rte_config('CONFIG_RTE_MAX_LCORE')
> 
>          if config_max_lcore:
> -            available_max_lcore = int(config_max_lcore)
> +            available_max_lcore = min(int(config_max_lcore),
> + len(self.all_cores) + 1)
>          else:
>              available_max_lcore = len(self.all_cores) + 1
> 
> diff --git a/tests/TestSuite_hello_world.py b/tests/TestSuite_hello_world.py
> index d199177..67095e8 100644
> --- a/tests/TestSuite_hello_world.py
> +++ b/tests/TestSuite_hello_world.py
> @@ -81,7 +81,7 @@ class TestHelloWorld(TestCase):
> 
>          config_max_lcore =
> self.dut.get_def_rte_config('CONFIG_RTE_MAX_LCORE')
>          if config_max_lcore:
> -            available_max_lcore = int(config_max_lcore)
> +            available_max_lcore = min(int(config_max_lcore), len(cores)
> + + 1)
>          else:
>              available_max_lcore = len(cores) + 1
> 
> --
> 1.7.9.5

      reply	other threads:[~2019-01-11  2:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-10  5:27 Phanendra Vukkisala
2019-01-11  2:17 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0B9FFEA9@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=avijay@marvell.com \
    --cc=dts@dpdk.org \
    --cc=fmasood@marvell.com \
    --cc=pvukkisala@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).