test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: Phanendra Vukkisala <pvukkisala@marvell.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Cc: Vijaya Bhaskar Annayyolla <avijay@marvell.com>,
	Faisal Masood <fmasood@marvell.com>
Subject: Re: [dts] [PATCH] tests/TestSuite_l3fwd.py: Fix L3fwd test on cavium	devices
Date: Fri, 11 Jan 2019 02:19:23 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0B9FFEC3@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1547099278-9241-1-git-send-email-pvukkisala@marvell.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Phanendra Vukkisala
> Sent: Thursday, January 10, 2019 1:48 PM
> To: dts@dpdk.org
> Cc: Vijaya Bhaskar Annayyolla <avijay@marvell.com>; Faisal Masood
> <fmasood@marvell.com>; Phanendra Vukkisala <pvukkisala@marvell.com>
> Subject: [dts] [PATCH] tests/TestSuite_l3fwd.py: Fix L3fwd test on cavium
> devices
> 
> From: pvukkisala <pvukkisala@marvell.com>
> 
> On devices where numa is not available, ports socket is identifying as -1.
> But while taking cores to run tests it should use socket 0 cores This test is not
> using 2S/8C/2T, at max using 1S/4C/1T. Updated verification accordingly
> 
> Signed-off-by: phanendra,vukkisala <pvukkisala@marvell.com>
> ---
>  tests/TestSuite_l3fwd.py |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_l3fwd.py b/tests/TestSuite_l3fwd.py index
> 86fc29c..78eaee7 100644
> --- a/tests/TestSuite_l3fwd.py
> +++ b/tests/TestSuite_l3fwd.py
> @@ -137,10 +137,12 @@ class TestL3fwd(TestCase,IxiaPacketGenerator):
>          netdev = self.dut.ports_info[ports[0]]['port']
> 
>          self.port_socket = netdev.socket
> +        if self.port_socket == -1:
> +            self.port_socket = 0
> 
> 
>          # Verify that enough threads are available
> -        cores = self.dut.get_core_list("2S/8C/2T")
> +        cores = self.dut.get_core_list("1S/4C/1T")
>          self.verify(cores is not None, "Insufficient cores for speed testing")
> 
>          global valports
> --
> 1.7.9.5

      reply	other threads:[~2019-01-11  2:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-10  5:48 Phanendra Vukkisala
2019-01-11  2:19 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0B9FFEC3@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=avijay@marvell.com \
    --cc=dts@dpdk.org \
    --cc=fmasood@marvell.com \
    --cc=pvukkisala@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).