test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH] tests/TestSuite_l3fwd.py: Fix L3fwd test on cavium devices
@ 2019-01-10  5:48 Phanendra Vukkisala
  2019-01-11  2:19 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: Phanendra Vukkisala @ 2019-01-10  5:48 UTC (permalink / raw)
  To: dts; +Cc: Vijaya Bhaskar Annayyolla, Faisal Masood, Phanendra Vukkisala

From: pvukkisala <pvukkisala@marvell.com>

On devices where numa is not available, ports socket is identifying as -1.
But while taking cores to run tests it should use socket 0 cores
This test is not using 2S/8C/2T, at max using 1S/4C/1T. Updated verification accordingly

Signed-off-by: phanendra,vukkisala <pvukkisala@marvell.com>
---
 tests/TestSuite_l3fwd.py |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_l3fwd.py b/tests/TestSuite_l3fwd.py
index 86fc29c..78eaee7 100644
--- a/tests/TestSuite_l3fwd.py
+++ b/tests/TestSuite_l3fwd.py
@@ -137,10 +137,12 @@ class TestL3fwd(TestCase,IxiaPacketGenerator):
         netdev = self.dut.ports_info[ports[0]]['port']
         
         self.port_socket = netdev.socket
+        if self.port_socket == -1:
+            self.port_socket = 0
         
 
         # Verify that enough threads are available
-        cores = self.dut.get_core_list("2S/8C/2T")
+        cores = self.dut.get_core_list("1S/4C/1T")
         self.verify(cores is not None, "Insufficient cores for speed testing")
 
         global valports
-- 
1.7.9.5

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH] tests/TestSuite_l3fwd.py: Fix L3fwd test on cavium devices
  2019-01-10  5:48 [dts] [PATCH] tests/TestSuite_l3fwd.py: Fix L3fwd test on cavium devices Phanendra Vukkisala
@ 2019-01-11  2:19 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2019-01-11  2:19 UTC (permalink / raw)
  To: Phanendra Vukkisala, dts; +Cc: Vijaya Bhaskar Annayyolla, Faisal Masood

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Phanendra Vukkisala
> Sent: Thursday, January 10, 2019 1:48 PM
> To: dts@dpdk.org
> Cc: Vijaya Bhaskar Annayyolla <avijay@marvell.com>; Faisal Masood
> <fmasood@marvell.com>; Phanendra Vukkisala <pvukkisala@marvell.com>
> Subject: [dts] [PATCH] tests/TestSuite_l3fwd.py: Fix L3fwd test on cavium
> devices
> 
> From: pvukkisala <pvukkisala@marvell.com>
> 
> On devices where numa is not available, ports socket is identifying as -1.
> But while taking cores to run tests it should use socket 0 cores This test is not
> using 2S/8C/2T, at max using 1S/4C/1T. Updated verification accordingly
> 
> Signed-off-by: phanendra,vukkisala <pvukkisala@marvell.com>
> ---
>  tests/TestSuite_l3fwd.py |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_l3fwd.py b/tests/TestSuite_l3fwd.py index
> 86fc29c..78eaee7 100644
> --- a/tests/TestSuite_l3fwd.py
> +++ b/tests/TestSuite_l3fwd.py
> @@ -137,10 +137,12 @@ class TestL3fwd(TestCase,IxiaPacketGenerator):
>          netdev = self.dut.ports_info[ports[0]]['port']
> 
>          self.port_socket = netdev.socket
> +        if self.port_socket == -1:
> +            self.port_socket = 0
> 
> 
>          # Verify that enough threads are available
> -        cores = self.dut.get_core_list("2S/8C/2T")
> +        cores = self.dut.get_core_list("1S/4C/1T")
>          self.verify(cores is not None, "Insufficient cores for speed testing")
> 
>          global valports
> --
> 1.7.9.5

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-01-11  2:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-10  5:48 [dts] [PATCH] tests/TestSuite_l3fwd.py: Fix L3fwd test on cavium devices Phanendra Vukkisala
2019-01-11  2:19 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).