test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH] tests/ddp_mpls: fix nic support and core reset issues
@ 2019-01-08  6:16 Xueqin Lin
  2019-01-11  7:30 ` Zhao, MeijuanX
  2019-01-11  8:26 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: Xueqin Lin @ 2019-01-08  6:16 UTC (permalink / raw)
  To: dts; +Cc: xueqin.lin

From: "xueqin.lin" <xueqin.lin@intel.com>

1. DDP MPLs could support FVL nic, not only fortville_25g.
2. Restore original profile instead of core reset to avoid exception.

Signed-off-by: Xueqin Lin <xueqin.lin@intel.com>

---
 tests/TestSuite_ddp_mpls.py | 26 ++++++++++++++++----------
 1 file changed, 16 insertions(+), 10 deletions(-)

diff --git a/tests/TestSuite_ddp_mpls.py b/tests/TestSuite_ddp_mpls.py
index 691e958..b002788 100644
--- a/tests/TestSuite_ddp_mpls.py
+++ b/tests/TestSuite_ddp_mpls.py
@@ -18,8 +18,8 @@ VF_MAX_QUEUE = 4
 class Testddp_mpls(TestCase):
 
     def set_up_all(self):
-        self.verify(self.nic in ['fortville_25g'], 
-            'ddp mpls can not support %s nic' % self.nic)
+        self.verify('fortville' in self.nic,
+                    'ddp mpls can not support %s nic' % self.nic)
         self.dut_ports = self.dut.get_ports(self.nic)
         self.verify(len(self.dut_ports) >= 1, "Insufficient ports")
         self.vm0 = None
@@ -123,7 +123,7 @@ class Testddp_mpls(TestCase):
         out = self.dut_testpmd.execute_cmd('ddp get list 0')
         self.verify("Profile number is: 0" in out,
             "Failed to get ddp profile info list!!!") 
-        self.dut_testpmd.execute_cmd('ddp add 0 /tmp/mpls.pkgo')
+        self.dut_testpmd.execute_cmd('ddp add 0 /tmp/mpls.pkgo,/tmp/mpls.bak')
         out = self.dut_testpmd.execute_cmd('ddp get list 0')
         self.verify("Profile number is: 1" in out,
             "Failed to load ddp profile!!!")
@@ -224,13 +224,19 @@ class Testddp_mpls(TestCase):
     
 
     def tear_down(self):
-        if self.vm0_testpmd:
-            self.dut_testpmd.execute_cmd('write reg 0 0xb8190 1')
-            self.dut_testpmd.execute_cmd('write reg 0 0xb8190 2')
-            self.vm0_testpmd.quit()
-            self.dut_testpmd.quit()
-        self.vm0_dut.kill_all()
-        pass
+        self.vm0_testpmd.execute_cmd('stop')
+        self.dut_testpmd.execute_cmd('stop')
+        out = self.dut_testpmd.execute_cmd('ddp get list 0')
+        if "Profile number is: 0" not in out:
+            self.dut_testpmd.execute_cmd('port stop all')
+            time.sleep(1)
+            self.dut_testpmd.execute_cmd('ddp del 0 /tmp/mpls.bak')
+            out = self.dut_testpmd.execute_cmd('ddp get list 0')
+            self.verify("Profile number is: 0" in out,
+                        "Failed to delete mpls profile!!!")
+            self.dut_testpmd.execute_cmd('port start all')
+        self.vm0_testpmd.quit()
+        self.dut_testpmd.quit()
 
 
     def tear_down_all(self):
-- 
2.7.5

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH] tests/ddp_mpls: fix nic support and core reset issues
  2019-01-08  6:16 [dts] [PATCH] tests/ddp_mpls: fix nic support and core reset issues Xueqin Lin
@ 2019-01-11  7:30 ` Zhao, MeijuanX
  2019-01-11  8:26 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Zhao, MeijuanX @ 2019-01-11  7:30 UTC (permalink / raw)
  To: Lin, Xueqin, dts; +Cc: Lin, Xueqin, Zhao, MeijuanX

Tested-by : Zhao, MeijuanX <meijuanx.zhao@intel.com>

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xueqin Lin
Sent: Tuesday, January 8, 2019 2:16 PM
To: dts@dpdk.org
Cc: Lin, Xueqin <xueqin.lin@intel.com>
Subject: [dts] [PATCH] tests/ddp_mpls: fix nic support and core reset issues

From: "xueqin.lin" <xueqin.lin@intel.com>

1. DDP MPLs could support FVL nic, not only fortville_25g.
2. Restore original profile instead of core reset to avoid exception.

Signed-off-by: Xueqin Lin <xueqin.lin@intel.com>

---
 tests/TestSuite_ddp_mpls.py | 26 ++++++++++++++++----------
 1 file changed, 16 insertions(+), 10 deletions(-)

diff --git a/tests/TestSuite_ddp_mpls.py b/tests/TestSuite_ddp_mpls.py index 691e958..b002788 100644
--- a/tests/TestSuite_ddp_mpls.py
+++ b/tests/TestSuite_ddp_mpls.py
@@ -18,8 +18,8 @@ VF_MAX_QUEUE = 4
 class Testddp_mpls(TestCase):
 
     def set_up_all(self):
-        self.verify(self.nic in ['fortville_25g'], 
-            'ddp mpls can not support %s nic' % self.nic)
+        self.verify('fortville' in self.nic,
+                    'ddp mpls can not support %s nic' % self.nic)
         self.dut_ports = self.dut.get_ports(self.nic)
         self.verify(len(self.dut_ports) >= 1, "Insufficient ports")
         self.vm0 = None
@@ -123,7 +123,7 @@ class Testddp_mpls(TestCase):
         out = self.dut_testpmd.execute_cmd('ddp get list 0')
         self.verify("Profile number is: 0" in out,
             "Failed to get ddp profile info list!!!") 
-        self.dut_testpmd.execute_cmd('ddp add 0 /tmp/mpls.pkgo')
+        self.dut_testpmd.execute_cmd('ddp add 0 
+ /tmp/mpls.pkgo,/tmp/mpls.bak')
         out = self.dut_testpmd.execute_cmd('ddp get list 0')
         self.verify("Profile number is: 1" in out,
             "Failed to load ddp profile!!!") @@ -224,13 +224,19 @@ class Testddp_mpls(TestCase):
     
 
     def tear_down(self):
-        if self.vm0_testpmd:
-            self.dut_testpmd.execute_cmd('write reg 0 0xb8190 1')
-            self.dut_testpmd.execute_cmd('write reg 0 0xb8190 2')
-            self.vm0_testpmd.quit()
-            self.dut_testpmd.quit()
-        self.vm0_dut.kill_all()
-        pass
+        self.vm0_testpmd.execute_cmd('stop')
+        self.dut_testpmd.execute_cmd('stop')
+        out = self.dut_testpmd.execute_cmd('ddp get list 0')
+        if "Profile number is: 0" not in out:
+            self.dut_testpmd.execute_cmd('port stop all')
+            time.sleep(1)
+            self.dut_testpmd.execute_cmd('ddp del 0 /tmp/mpls.bak')
+            out = self.dut_testpmd.execute_cmd('ddp get list 0')
+            self.verify("Profile number is: 0" in out,
+                        "Failed to delete mpls profile!!!")
+            self.dut_testpmd.execute_cmd('port start all')
+        self.vm0_testpmd.quit()
+        self.dut_testpmd.quit()
 
 
     def tear_down_all(self):
--
2.7.5

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH] tests/ddp_mpls: fix nic support and core reset issues
  2019-01-08  6:16 [dts] [PATCH] tests/ddp_mpls: fix nic support and core reset issues Xueqin Lin
  2019-01-11  7:30 ` Zhao, MeijuanX
@ 2019-01-11  8:26 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2019-01-11  8:26 UTC (permalink / raw)
  To: Lin, Xueqin, dts; +Cc: Lin, Xueqin

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xueqin Lin
> Sent: Tuesday, January 8, 2019 2:16 PM
> To: dts@dpdk.org
> Cc: Lin, Xueqin <xueqin.lin@intel.com>
> Subject: [dts] [PATCH] tests/ddp_mpls: fix nic support and core reset issues
> 
> From: "xueqin.lin" <xueqin.lin@intel.com>
> 
> 1. DDP MPLs could support FVL nic, not only fortville_25g.
> 2. Restore original profile instead of core reset to avoid exception.
> 
> Signed-off-by: Xueqin Lin <xueqin.lin@intel.com>
> 
> ---
>  tests/TestSuite_ddp_mpls.py | 26 ++++++++++++++++----------
>  1 file changed, 16 insertions(+), 10 deletions(-)
> 
> diff --git a/tests/TestSuite_ddp_mpls.py b/tests/TestSuite_ddp_mpls.py index
> 691e958..b002788 100644
> --- a/tests/TestSuite_ddp_mpls.py
> +++ b/tests/TestSuite_ddp_mpls.py
> @@ -18,8 +18,8 @@ VF_MAX_QUEUE = 4
>  class Testddp_mpls(TestCase):
> 
>      def set_up_all(self):
> -        self.verify(self.nic in ['fortville_25g'],
> -            'ddp mpls can not support %s nic' % self.nic)
> +        self.verify('fortville' in self.nic,
> +                    'ddp mpls can not support %s nic' % self.nic)
>          self.dut_ports = self.dut.get_ports(self.nic)
>          self.verify(len(self.dut_ports) >= 1, "Insufficient ports")
>          self.vm0 = None
> @@ -123,7 +123,7 @@ class Testddp_mpls(TestCase):
>          out = self.dut_testpmd.execute_cmd('ddp get list 0')
>          self.verify("Profile number is: 0" in out,
>              "Failed to get ddp profile info list!!!")
> -        self.dut_testpmd.execute_cmd('ddp add 0 /tmp/mpls.pkgo')
> +        self.dut_testpmd.execute_cmd('ddp add 0
> + /tmp/mpls.pkgo,/tmp/mpls.bak')
>          out = self.dut_testpmd.execute_cmd('ddp get list 0')
>          self.verify("Profile number is: 1" in out,
>              "Failed to load ddp profile!!!") @@ -224,13 +224,19 @@ class
> Testddp_mpls(TestCase):
> 
> 
>      def tear_down(self):
> -        if self.vm0_testpmd:
> -            self.dut_testpmd.execute_cmd('write reg 0 0xb8190 1')
> -            self.dut_testpmd.execute_cmd('write reg 0 0xb8190 2')
> -            self.vm0_testpmd.quit()
> -            self.dut_testpmd.quit()
> -        self.vm0_dut.kill_all()
> -        pass
> +        self.vm0_testpmd.execute_cmd('stop')
> +        self.dut_testpmd.execute_cmd('stop')
> +        out = self.dut_testpmd.execute_cmd('ddp get list 0')
> +        if "Profile number is: 0" not in out:
> +            self.dut_testpmd.execute_cmd('port stop all')
> +            time.sleep(1)
> +            self.dut_testpmd.execute_cmd('ddp del 0 /tmp/mpls.bak')
> +            out = self.dut_testpmd.execute_cmd('ddp get list 0')
> +            self.verify("Profile number is: 0" in out,
> +                        "Failed to delete mpls profile!!!")
> +            self.dut_testpmd.execute_cmd('port start all')
> +        self.vm0_testpmd.quit()
> +        self.dut_testpmd.quit()
> 
> 
>      def tear_down_all(self):
> --
> 2.7.5

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-01-11  8:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-08  6:16 [dts] [PATCH] tests/ddp_mpls: fix nic support and core reset issues Xueqin Lin
2019-01-11  7:30 ` Zhao, MeijuanX
2019-01-11  8:26 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).