test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Li, WenjieX A" <wenjiex.a.li@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Li, WenjieX A" <wenjiex.a.li@intel.com>
Subject: Re: [dts] [PATCH V1] tests/qinq_filter: change testpmd startup timeout	to 30s
Date: Tue, 15 Jan 2019 02:49:08 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BA025BD@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1545286738-36363-1-git-send-email-wenjiex.a.li@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li
> Sent: Thursday, December 20, 2018 2:19 PM
> To: dts@dpdk.org
> Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
> Subject: [dts] [PATCH V1] tests/qinq_filter: change testpmd startup timeout to
> 30s
> 
> On some platforms, testpmd took more than 15s(the default timeout value) to
> startup, so change it to 30s.
> 
> Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
> ---
>  tests/TestSuite_qinq_filter.py | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/tests/TestSuite_qinq_filter.py b/tests/TestSuite_qinq_filter.py index
> d266212..0fdabfe 100644
> --- a/tests/TestSuite_qinq_filter.py
> +++ b/tests/TestSuite_qinq_filter.py
> @@ -148,7 +148,7 @@ class TestQinqFilter(TestCase):
>          self.dut.send_expect(r'./%s/app/testpmd -c %s -n 4 -- -i \
>                                 --portmask=%s --port-topology=loop \
>                                 --rxq=4 --txq=4  --disable-rss' % (self.target, self.coreMask,
> self.portMask),
> -                               "testpmd> ")
> +                               "testpmd> ", 30)
>          self.dut.send_expect("vlan set qinq on %s" % dutRxPortId, "testpmd> ")
>          self.dut.send_expect("vlan set strip on %s" % dutRxPortId, "testpmd> ")
>          self.dut.send_expect("set fwd rxonly", "testpmd> ") @@ -169,7 +169,7 @@
> class TestQinqFilter(TestCase):
>          self.dut.send_expect(r'./%s/app/testpmd -c %s -n 4 -- -i \
>                                 --portmask=%s --port-topology=loop \
>                                 --rxq=4 --txq=4  --disable-rss' % (self.target, self.coreMask,
> self.portMask),
> -                               "testpmd> ")
> +                               "testpmd> ", 30)
>          self.dut.send_expect("vlan set qinq on %s" % dutRxPortId, "testpmd> ")
>          self.dut.send_expect("set fwd rxonly", "testpmd> ")
>          self.dut.send_expect("set verbose 1", "testpmd> ") @@ -206,7 +206,7 @@
> class TestQinqFilter(TestCase):
>                                 --socket-mem=1024,1024 --file-prefix=pf -w %s -- -i --port-
> topology=loop \
>                                 --rxq=4 --txq=4  --disable-rss'
>                                 % (self.target, self.coreMask,
> self.dut.ports_info[dutRxPortId]['pci']),
> -                               "testpmd> ")
> +                               "testpmd> ", 30)
>          self.dut.send_expect("vlan set qinq on %s" % dutRxPortId, "testpmd> ")
>          self.dut.send_expect("set fwd rxonly", "testpmd> ")
>          self.dut.send_expect("set verbose 1", "testpmd> ") @@ -223,13 +223,13
> @@ class TestQinqFilter(TestCase):
>                                 --socket-mem=1024,1024 --file-prefix=vf0 -w %s -- -i --port-
> topology=loop \
>                                 --rxq=4 --txq=4  --disable-rss'
>                                 % (self.target, self.coreMask, vf_list[0]),
> -                               "testpmd> ")
> +                               "testpmd> ", 30)
> 
>          vf1_session.send_expect(r'./%s/app/testpmd -c %s -n 4 \
>                                 --socket-mem=1024,1024 --file-prefix=vf1 -w %s -- -i --port-
> topology=loop \
>                                 --rxq=4 --txq=4  --disable-rss'
>                                 % (self.target, self.coreMask, vf_list[1]),
> -                               "testpmd>")
> +                               "testpmd>", 30)
>          for session_name in [vf0_session, vf1_session]:
>              session_name.send_expect("set fwd rxonly", "testpmd> ")
>              session_name.send_expect("set verbose 1", "testpmd> ") @@ -275,7
> +275,7 @@ class TestQinqFilter(TestCase):
>                                 --socket-mem=1024,1024 --file-prefix=pf -w %s -- -i --port-
> topology=loop \
>                                 --rxq=4 --txq=4  --disable-rss'
>                                 % (self.target, self.coreMask,
> self.dut.ports_info[dutRxPortId]['pci']),
> -                               "testpmd> ")
> +                               "testpmd> ", 30)
>          self.dut.send_expect("vlan set qinq on %s" % dutRxPortId, "testpmd> ")
>          self.dut.send_expect("set fwd rxonly", "testpmd> ")
>          self.dut.send_expect("set verbose 1", "testpmd> ") @@ -295,13 +295,13
> @@ class TestQinqFilter(TestCase):
>                                 --socket-mem=1024,1024 --file-prefix=vf0 -w %s -- -i --port-
> topology=loop \
>                                 --rxq=4 --txq=4  --disable-rss'
>                                 % (self.target, self.coreMask, vf_list[0]),
> -                               "testpmd> ")
> +                               "testpmd> ", 30)
> 
>          vf1_session.send_expect(r'./%s/app/testpmd -c %s -n 4 \
>                                 --socket-mem=1024,1024 --file-prefix=vf1 -w %s -- -i --port-
> topology=loop \
>                                 --rxq=4 --txq=4  --disable-rss'
>                                 % (self.target, self.coreMask, vf_list[1]),
> -                               "testpmd>")
> +                               "testpmd>", 30)
>          for session_name in [vf0_session, vf1_session]:
>              session_name.send_expect("set fwd rxonly", "testpmd> ")
>              session_name.send_expect("set verbose 1", "testpmd> ")
> --
> 2.17.2

      parent reply	other threads:[~2019-01-15  2:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-20  6:18 Wenjie Li
2018-12-20  6:57 ` Yao, BingX Y
2019-01-15  2:49 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BA025BD@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=wenjiex.a.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).