test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V2] tests/userspace_ethtool:remove the Vlan filter offload flag bit.
@ 2019-01-14  2:01 zhu,shuai
  2019-01-14  3:00 ` Wu, ChangqingX
  2019-01-15  5:56 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: zhu,shuai @ 2019-01-14  2:01 UTC (permalink / raw)
  To: dts; +Cc: zhu,shuai

since to changes from 18.02 dpdk, changes about all offload flag in dpdk source code.
‘hw_vlan_filter’ is abandoned  since 18.02.

Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
---
 tests/TestSuite_userspace_ethtool.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspace_ethtool.py
index 8ade421..a7a2a62 100644
--- a/tests/TestSuite_userspace_ethtool.py
+++ b/tests/TestSuite_userspace_ethtool.py
@@ -467,7 +467,7 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
             self.verify(tx_pkts_del == rx_pkts, "Failed to remove Rx vlan filter")
 
         self.dut.send_expect("quit", "# ")
-        self.dut.send_expect("sed -i -e '/hw_vlan_filter=1;$/d' %s" % main_file, "# ")
+        self.dut.send_expect("sed -i -e '/cfg_port.rxmode.offloads|=DEV_RX_OFFLOAD_VLAN_FILTER;$/d' %s" % main_file, "# ")
         # build sample app
         self.build_ethtool()
 
-- 
2.17.2

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V2] tests/userspace_ethtool:remove the Vlan filter offload flag bit.
  2019-01-14  2:01 [dts] [PATCH V2] tests/userspace_ethtool:remove the Vlan filter offload flag bit zhu,shuai
@ 2019-01-14  3:00 ` Wu, ChangqingX
  2019-01-15  5:56 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Wu, ChangqingX @ 2019-01-14  3:00 UTC (permalink / raw)
  To: Zhu, ShuaiX, dts; +Cc: Zhu, ShuaiX

Tested-by: Wu, ChangqingX <changqingx.wu@intel.com>

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhu,shuai
Sent: Monday, January 14, 2019 10:01 AM
To: dts@dpdk.org
Cc: Zhu, ShuaiX <shuaix.zhu@intel.com>
Subject: [dts] [PATCH V2] tests/userspace_ethtool:remove the Vlan filter offload flag bit.

since to changes from 18.02 dpdk, changes about all offload flag in dpdk source code.
‘hw_vlan_filter’ is abandoned  since 18.02.

Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
---
 tests/TestSuite_userspace_ethtool.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspace_ethtool.py
index 8ade421..a7a2a62 100644
--- a/tests/TestSuite_userspace_ethtool.py
+++ b/tests/TestSuite_userspace_ethtool.py
@@ -467,7 +467,7 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
             self.verify(tx_pkts_del == rx_pkts, "Failed to remove Rx vlan filter")
 
         self.dut.send_expect("quit", "# ")
-        self.dut.send_expect("sed -i -e '/hw_vlan_filter=1;$/d' %s" % main_file, "# ")
+        self.dut.send_expect("sed -i -e '/cfg_port.rxmode.offloads|=DEV_RX_OFFLOAD_VLAN_FILTER;$/d' %s" % main_file, "# ")
         # build sample app
         self.build_ethtool()
 
-- 
2.17.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V2] tests/userspace_ethtool:remove the Vlan filter offload flag bit.
  2019-01-14  2:01 [dts] [PATCH V2] tests/userspace_ethtool:remove the Vlan filter offload flag bit zhu,shuai
  2019-01-14  3:00 ` Wu, ChangqingX
@ 2019-01-15  5:56 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2019-01-15  5:56 UTC (permalink / raw)
  To: Zhu, ShuaiX, dts; +Cc: Zhu, ShuaiX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhu,shuai
> Sent: Monday, January 14, 2019 10:01 AM
> To: dts@dpdk.org
> Cc: Zhu, ShuaiX <shuaix.zhu@intel.com>
> Subject: [dts] [PATCH V2] tests/userspace_ethtool:remove the Vlan filter offload
> flag bit.
> 
> since to changes from 18.02 dpdk, changes about all offload flag in dpdk source
> code.
> ‘hw_vlan_filter’ is abandoned  since 18.02.
> 
> Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
> ---
>  tests/TestSuite_userspace_ethtool.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_userspace_ethtool.py
> b/tests/TestSuite_userspace_ethtool.py
> index 8ade421..a7a2a62 100644
> --- a/tests/TestSuite_userspace_ethtool.py
> +++ b/tests/TestSuite_userspace_ethtool.py
> @@ -467,7 +467,7 @@ class TestUserspaceEthtool(TestCase,
> IxiaPacketGenerator):
>              self.verify(tx_pkts_del == rx_pkts, "Failed to remove Rx vlan filter")
> 
>          self.dut.send_expect("quit", "# ")
> -        self.dut.send_expect("sed -i -e '/hw_vlan_filter=1;$/d' %s" % main_file, "# ")
> +        self.dut.send_expect("sed -i -e
> '/cfg_port.rxmode.offloads|=DEV_RX_OFFLOAD_VLAN_FILTER;$/d' %s" %
> main_file, "# ")
>          # build sample app
>          self.build_ethtool()
> 
> --
> 2.17.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-01-15  5:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-14  2:01 [dts] [PATCH V2] tests/userspace_ethtool:remove the Vlan filter offload flag bit zhu,shuai
2019-01-14  3:00 ` Wu, ChangqingX
2019-01-15  5:56 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).