From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id B5449683E for ; Tue, 15 Jan 2019 06:58:58 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jan 2019 21:58:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,480,1539673200"; d="scan'208";a="135874825" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga004.fm.intel.com with ESMTP; 14 Jan 2019 21:58:57 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 14 Jan 2019 21:58:57 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.196]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.160]) with mapi id 14.03.0415.000; Tue, 15 Jan 2019 13:58:55 +0800 From: "Tu, Lijuan" To: "Li, WenjieX A" , "dts@dpdk.org" CC: "Li, WenjieX A" Thread-Topic: [dts] [PATCH V1] fix crc strip only supports 2 ports env issue Thread-Index: AQHUqYFIuZl5jNPZPkOdFEmttnLH56Wv271w Date: Tue, 15 Jan 2019 05:58:54 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BA0299F@SHSMSX101.ccr.corp.intel.com> References: <1547192756-26241-1-git-send-email-wenjiex.a.li@intel.com> In-Reply-To: <1547192756-26241-1-git-send-email-wenjiex.a.li@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjdhMzEzNDktZWVlYS00OGJiLTk5M2ItMTZmZjA0ZmM4ZDEwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibTIwbHJiQnNUUGNYTWFEd3N5XC9zV0J4eEplYldYeE0xUDg1MW1rWnREbFYrM29zN1AzODRFWlhHZm03OGFmZ3gifQ== x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] fix crc strip only supports 2 ports env issue X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jan 2019 05:58:59 -0000 Applied, thanks > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li > Sent: Friday, January 11, 2019 3:46 PM > To: dts@dpdk.org > Cc: Li, WenjieX A > Subject: [dts] [PATCH V1] fix crc strip only supports 2 ports env issue >=20 > Before update, crc_keep and crc_strip only support 2 ports env; now it co= uld > support all ports(not only 2). >=20 > Signed-off-by: Wenjie Li > --- > tests/TestSuite_shutdown_api.py | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) >=20 > diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_a= pi.py > index ba4c6cb..9f3f03f 100644 > --- a/tests/TestSuite_shutdown_api.py > +++ b/tests/TestSuite_shutdown_api.py > @@ -268,7 +268,11 @@ class TestShutdownApi(TestCase): > self.pmdout.start_testpmd("Default", "--portmask=3D%s --port- > topology=3Dloop --disable-crc-strip" % utils.create_mask(self.ports), > socket=3Dself.ports_socket) > out =3D self.dut.send_expect("show config rxtx", "testpmd> ") > Rx_offloads =3D re.compile('Rx offloads=3D(.*?)\s+?').findall(ou= t, re.S) > - crc_keep =3D int(Rx_offloads[0],16) & RX_OFFLOAD_KEEP_CRC and > int(Rx_offloads[1],16) & RX_OFFLOAD_KEEP_CRC > + crc_keep_temp =3D [] > + for i in range(len(self.dut.get_ports())): > + crc_keep_temp.append(int(Rx_offloads[i],16) & > RX_OFFLOAD_KEEP_CRC) > + crc_keep =3D crc_keep_temp[0] > + crc_keep =3D crc_keep and crc_keep_temp[i] > self.verify( > crc_keep =3D=3D RX_OFFLOAD_KEEP_CRC, "CRC keeping not enable= d > properly") >=20 > @@ -278,7 +282,11 @@ class TestShutdownApi(TestCase): > self.dut.send_expect("port start all", "testpmd> ", 100) > out =3D self.dut.send_expect("show config rxtx", "testpmd> ") > Rx_offloads =3D re.compile('Rx offloads=3D(.*?)\s+?').findall(ou= t, re.S) > - crc_strip =3D int(Rx_offloads[0],16) | ~RX_OFFLOAD_KEEP_CRC and > int(Rx_offloads[1],16) | ~RX_OFFLOAD_KEEP_CRC > + crc_strip_temp =3D [] > + for i in range(len(self.dut.get_ports())): > + crc_strip_temp.append(int(Rx_offloads[i],16) | > ~RX_OFFLOAD_KEEP_CRC) > + crc_strip =3D crc_strip_temp[0] > + crc_strip =3D crc_strip and crc_strip_temp[i] > self.verify( > crc_strip =3D=3D ~RX_OFFLOAD_KEEP_CRC, "CRC stripping not en= abled > properly") > self.dut.send_expect("start", "testpmd> ") > -- > 2.17.2