From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 0AB6B683E for ; Tue, 15 Jan 2019 07:10:41 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jan 2019 22:10:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,480,1539673200"; d="scan'208";a="267186575" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga004.jf.intel.com with ESMTP; 14 Jan 2019 22:10:40 -0800 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 14 Jan 2019 22:10:40 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 14 Jan 2019 22:10:39 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.196]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.44]) with mapi id 14.03.0415.000; Tue, 15 Jan 2019 14:10:38 +0800 From: "Tu, Lijuan" To: "Peng, Yuan" , "dts@dpdk.org" CC: "Peng, Yuan" Thread-Topic: [dts] [PATCH] tests: Correct some format errors Thread-Index: AQHUqYgZydNrjXvLFU6T1zBz2viTaaWv3vUA Date: Tue, 15 Jan 2019 06:10:36 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BA02A07@SHSMSX101.ccr.corp.intel.com> References: <1547195681-27164-1-git-send-email-yuan.peng@intel.com> In-Reply-To: <1547195681-27164-1-git-send-email-yuan.peng@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTZjNzM4NGItODBiMC00NzE0LWI3ZDctNjU3ZTAwMjI3M2Y1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSFR6NnhUWHRKbDNxclIxRUdGTVwvUmY5NkVcL0E5dzBQcUVJR3VLK0QydURlU0NEMkE0VDJIdWFja2lkb0Jia3FBIn0= x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH] tests: Correct some format errors X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jan 2019 06:10:42 -0000 Applied, thanks > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Peng Yuan > Sent: Friday, January 11, 2019 4:35 PM > To: dts@dpdk.org > Cc: Peng, Yuan > Subject: [dts] [PATCH] tests: Correct some format errors >=20 > Correct some format errors for TestSuite_jumboframes.py >=20 > Signed-off-by: Peng Yuan >=20 > diff --git a/tests/TestSuite_jumboframes.py b/tests/TestSuite_jumboframes= .py > index b3d53d8..cbb284d 100644 > --- a/tests/TestSuite_jumboframes.py > +++ b/tests/TestSuite_jumboframes.py > @@ -84,7 +84,6 @@ class TestJumboframes(TestCase): > sleep(5) >=20 > tx_pkts, _, tx_bytes =3D [int(_) for _ in self.jumboframes_get_s= tat(self.rx_port, > "tx")] > - # p0tx_pkts, p0tx_err, p0tx_bytes > rx_pkts, rx_err, rx_bytes =3D [int(_) for _ in > self.jumboframes_get_stat(self.tx_port, "rx")] >=20 > tx_pkts -=3D tx_pkts_ori > @@ -99,7 +98,6 @@ class TestJumboframes(TestCase): > and ((rx_bytes + 4) =3D=3D pktsize), > "packet pass assert error") > else: > - #self.verify(p0tx_pkts =3D=3D p1rx_pkts and (p1rx_err =3D=3D= 1 or p1rx_pkts =3D=3D 0), > self.verify(rx_err =3D=3D 1 or tx_pkts =3D=3D 0, "packet dro= p assert error") > return out >=20 > @@ -129,7 +127,6 @@ class TestJumboframes(TestCase): > netobj.enable_jumbo(framesize =3D ETHER_JUMBO_FRAME_MTU) >=20 > self.tester.send_expect("ifconfig %s mtu %s" % > (self.tester.get_interface(self.tester.get_local_port(self.rx_port)), > ETHER_JUMBO_FRAME_MTU + 200), "# ") > -# self.tester.send_expect("ifconfig %s mtu %s" % > (self.tester.get_interface(self.tester.get_local_port(self.tx_port)), > ETHER_JUMBO_FRAME_MTU + 200), "# ") >=20 > self.pmdout =3D PmdOutput(self.dut) >=20 > @@ -181,8 +178,8 @@ class TestJumboframes(TestCase): > self.dut.send_expect("set fwd mac", "testpmd> ") > self.dut.send_expect("start", "testpmd> ") >=20 > - self.jumboframes_send_packet(1517) > - self.jumboframes_send_packet(1518) > + self.jumboframes_send_packet(ETHER_STANDARD_MTU - 1) > + self.jumboframes_send_packet(ETHER_STANDARD_MTU) >=20 > self.dut.send_expect("stop", "testpmd> ") > self.dut.send_expect("quit", "# ", 30) @@ -234,4 +231,3 @@ class > TestJumboframes(TestCase): > clear up. > """ > self.tester.send_expect("ifconfig %s mtu %s" % > (self.tester.get_interface(self.tester.get_local_port(self.rx_port)), > ETHER_STANDARD_MTU), "# ") > - self.tester.send_expect("ifconfig %s mtu %s" % > (self.tester.get_interface(self.tester.get_local_port(self.tx_port)), > ETHER_STANDARD_MTU), "# ") > -- > 2.5.0