The main tactic of get_core_list() is if system core less than your request, it will give you all cores.

Thanks for your feedback, I will go through it ,  and figure out the issue.




From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Rami Rosen
Sent: Thursday, January 24, 2019 9:54 AM
To: Zhu, ShuaiX <shuaix.zhu@intel.com>
Cc: dts@dpdk.org
Subject: Re: [dts] [PATCH V1] tests/ipfrag:Modify the way to get the core.

Hi, Zhu,

> Some platforms have a core number less than a fixed value.

Thanks for this patch. You are right, obviously there are platforms with other combinations than
"2S/2C/2T", and actually I myself run DTS on diifferent platforms than this and had some issues related to it with various DTS test modules.

 I have a question, though,if I may:
On which platform ( i mean which combination of socket/core/thread in that platform) did the solution of using cores = self.dut.get_core_listst("all") instead of the  hard coded "2S/2C/2T" worked  for you for this ipfrag Test Module?

And a general question to DTS developers/maintainer:  all the DTS test suites use hard coded values for the S/C/T combination. And obviously this will fail on certain platforms. Wouldn't it be reasonable to replace all these occurrences with self.dut.get_core_listst("all") ? Will self.dut.get_core_listst("all") always work, for any combination of socket/core/thread ? Will this work for 2S/4C/2T ?

Regards,
Rami Rosen