From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id A796D1B117 for ; Tue, 29 Jan 2019 10:33:19 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jan 2019 01:33:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,536,1539673200"; d="scan'208";a="315767667" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga005.fm.intel.com with ESMTP; 29 Jan 2019 01:33:18 -0800 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 29 Jan 2019 01:33:18 -0800 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 29 Jan 2019 01:33:18 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.110]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.36]) with mapi id 14.03.0415.000; Tue, 29 Jan 2019 17:33:16 +0800 From: "Tu, Lijuan" To: "Zhu, WenhuiX" , "dts@dpdk.org" CC: "Zhu, WenhuiX" Thread-Topic: [dts] [PATCH V3] tests/dual_vlan check if the link is up Thread-Index: AQHUs5DLC9JDhzb2x0iZIoQlmMjVtaXGBCdQ Date: Tue, 29 Jan 2019 09:33:16 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BA1E66C@SHSMSX101.ccr.corp.intel.com> References: <1548298961-26285-1-git-send-email-wenhuix.zhu@intel.com> In-Reply-To: <1548298961-26285-1-git-send-email-wenhuix.zhu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzk0MDI0MjctYjkwNS00YWYwLWE5YTktMDZkYjA1ODBhZTM3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVlhtOXVlR0dBd2RGd3FyQUY4N2tHVW5HUTZGeHFEM20xQ1VGYmtRVzBXTDBZeUs3eEZlUGVXVUVoNkVudTZlQiJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V3] tests/dual_vlan check if the link is up X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Jan 2019 09:33:20 -0000 Applied, thanks > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhuwenhui > Sent: Thursday, January 24, 2019 11:03 AM > To: dts@dpdk.org > Cc: Zhu, WenhuiX > Subject: [dts] [PATCH V3] tests/dual_vlan check if the link is up >=20 > The link maybe up failed after "start", make sure the link is really up, = and then > proceed to the next step. >=20 > Signed-off-by: zhuwenhui > --- > V2: add show_port() >=20 > V3: > 1. update show_port() to check_link_up() 2. in check_link_up(), add the s= olution > to show the port_id which is still down 3. use check_link_up() in test ca= ses >=20 > tests/TestSuite_dual_vlan.py | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) >=20 > diff --git a/tests/TestSuite_dual_vlan.py b/tests/TestSuite_dual_vlan.py = index > 994ac42..d7fba3d 100644 > --- a/tests/TestSuite_dual_vlan.py > +++ b/tests/TestSuite_dual_vlan.py > @@ -40,6 +40,7 @@ Test the support of Dual VLAN Offload Features by Poll > Mode Drivers. > import utils > import random > import re > +import time >=20 > txvlan =3D 3 > outvlan =3D 1 > @@ -182,6 +183,17 @@ class TestDualVlan(TestCase): > else: > self.verify("%s %s" % (mode, modeName[mode]) in out, "%s= setting > error" % mode) >=20 > + def verify_link_up(self): > + ports =3D self.dut.get_ports(self.nic) > + for port_id in range(len(ports)): > + out =3D self.dut.send_expect("show port info %s" % port_id, = "testpmd> ") > + port_time_up =3D 0 > + while (port_time_up <=3D 10) and ("Link status: down" in out= ): > + time.sleep(1) > + out =3D self.dut.send_expect("show port info %s" % port_= id, "testpmd> ") > + port_time_up +=3D 1 > + self.verify("Link status: down" not in out, "Port %s > + Link down, please check your link" % port_id) > + > def multimode_test(self, caseIndex): > """ > Setup Strip/Filter/Extend/Insert enable/disable for synthetic te= st. > @@ -200,6 +212,7 @@ class TestDualVlan(TestCase): > self.dut.send_expect('tx_vlan set %s %s' % (dutTxPortId, txv= lan), > "testpmd> ") > self.dut.send_expect('port start all', "testpmd> ") > self.dut.send_expect('start', "testpmd> ") > + self.verify_link_up() >=20 > configMode =3D "Strip %s, filter %s 0x1, extend %s, insert %s" %= (temp[0], > temp[1], temp[2], "on" if (caseDef & txCase) !=3D 0 else "off") >=20 > @@ -218,6 +231,7 @@ class TestDualVlan(TestCase): > self.dut.send_expect('tx_vlan reset %s' % dutTxPortId, "= testpmd> ") > self.dut.send_expect('port start all', "testpmd> ") > self.dut.send_expect('start', "testpmd> ") > + self.verify_link_up() >=20 > else: > self.dut.send_expect('rx_vlan add %s %s' % (invlan, dutRxPor= tId), > "testpmd> ") @@ -230,6 +244,7 @@ class TestDualVlan(TestCase): > self.dut.send_expect('tx_vlan reset %s' % dutTxPortId, "= testpmd> ") > self.dut.send_expect('port start all', "testpmd> ") > self.dut.send_expect('start', "testpmd> ") > + self.verify_link_up() > self.dut.send_expect('rx_vlan rm %s %s' % (invlan, dutRxPort= Id), "testpmd> > ") > self.dut.send_expect('rx_vlan rm %s %s' % (outvlan, dutRxPor= tId), > "testpmd> ") >=20 > @@ -364,6 +379,7 @@ class TestDualVlan(TestCase): > self.dut.send_expect("tx_vlan set %s %s" % (dutTxPortId, txvlan)= , "testpmd> > ") > self.dut.send_expect("port start all", "testpmd> ") > self.dut.send_expect("start", "testpmd> ") > + self.verify_link_up() >=20 > self.vlan_send_packet() > out =3D self.get_tcpdump_package() @@ -374,6 +390,7 @@ class > TestDualVlan(TestCase): > self.dut.send_expect("tx_vlan reset %s" % dutTxPortId, "testpmd>= ") > self.dut.send_expect("port start all", "testpmd> ") > self.dut.send_expect("start", "testpmd> ") > + self.verify_link_up() >=20 > self.vlan_send_packet() > out =3D self.get_tcpdump_package() > -- > 2.17.2