From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 864616CC1 for ; Wed, 30 Jan 2019 04:18:28 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jan 2019 19:18:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,539,1539673200"; d="scan'208";a="134293512" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga001.jf.intel.com with ESMTP; 29 Jan 2019 19:18:27 -0800 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 29 Jan 2019 19:18:26 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 29 Jan 2019 19:18:26 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.110]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.109]) with mapi id 14.03.0415.000; Wed, 30 Jan 2019 11:18:24 +0800 From: "Tu, Lijuan" To: Phanendra Vukkisala , "dts@dpdk.org" CC: Vijaya Bhaskar Annayyolla , Faisal Masood Thread-Topic: [PATCH] packetgen: Corrected return values and parameters of loss function Thread-Index: AQHUrjXaAv6Q9o3XFEaWYjS7IKvdfaXHOHGQ Date: Wed, 30 Jan 2019 03:18:24 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BA1EC80@SHSMSX101.ccr.corp.intel.com> References: <1547709909-9116-1-git-send-email-pvukkisala@marvell.com> In-Reply-To: <1547709909-9116-1-git-send-email-pvukkisala@marvell.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjQxZDcyZmQtN2U3Yi00NTM2LWEyZTMtOGNlYWFiZDE4ZDkyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoic1hXRkNsV2ZQaEpjSmNXTmltK0JKaHcwRjZBbjM2TUYwdWdlMlFwZFwvT0FpTUFLSlZIblhNcnNIUzZTTno1c0QifQ== x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH] packetgen: Corrected return values and parameters of loss function X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2019 03:18:29 -0000 Applied, thanks > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Phanendra Vukkisala > Sent: Thursday, January 17, 2019 3:26 PM > To: dts@dpdk.org > Cc: Vijaya Bhaskar Annayyolla ; Faisal Masood > ; Phanendra Vukkisala > Subject: [dts] [PATCH] packetgen: Corrected return values and parameters = of > loss function >=20 > From: pvukkisala >=20 > Updated return values of loss function of packetgen to match with IXIA lo= ss > function Removed passing delay argument to packetgen loss as it is not re= quired. >=20 > Signed-off-by: phanendra,vukkisala > --- > framework/etgen.py | 2 +- > framework/tester.py | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/framework/etgen.py b/framework/etgen.py index 2856a28..6c853= 84 > 100644 > --- a/framework/etgen.py > +++ b/framework/etgen.py > @@ -158,7 +158,7 @@ class SoftwarePacketGenerator(): > def loss(self, portList, ratePercent): > (bps_rx, bps_tx, _) =3D self.packet_generator(portList, ratePerc= ent) > assert bps_tx !=3D 0 > - return (float(bps_tx) - float(bps_rx)) / float(bps_tx) > + return (float(bps_tx) - float(bps_rx)) / float(bps_tx), > + float(bps_tx), float(bps_rx) >=20 >=20 > class IxiaPacketGenerator(SSHConnection): > diff --git a/framework/tester.py b/framework/tester.py index > 4e651a1..e1416d8 100755 > --- a/framework/tester.py > +++ b/framework/tester.py > @@ -535,7 +535,7 @@ class Tester(Crb): > elif not self.check_port_list(portList): > self.logger.warning("exception by mixed port types") > return None > - return self.packet_gen.loss(portList, ratePercent, delay) > + return self.packet_gen.loss(portList, ratePercent) >=20 > def traffic_generator_latency(self, portList, ratePercent=3D100, del= ay=3D5): > """ > -- > 1.7.9.5