From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id A23D81B4BC for ; Sat, 2 Feb 2019 10:31:06 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Feb 2019 01:31:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,551,1539673200"; d="scan'208";a="140996399" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga004.fm.intel.com with ESMTP; 02 Feb 2019 01:31:05 -0800 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sat, 2 Feb 2019 01:31:04 -0800 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sat, 2 Feb 2019 01:31:04 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.110]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.232]) with mapi id 14.03.0415.000; Sat, 2 Feb 2019 17:31:02 +0800 From: "Tu, Lijuan" To: "Zhu, WenhuiX" , "dts@dpdk.org" CC: "Zhu, WenhuiX" Thread-Topic: [dts] [PATCH V4] tests/dual_vlan Change the verify outside the loop Thread-Index: AQHUupf0Fwj7aydUuEW3YcVYzjMK26XMPf9w Date: Sat, 2 Feb 2019 09:31:01 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BA2014F@SHSMSX101.ccr.corp.intel.com> References: <1549071693-50577-1-git-send-email-wenhuix.zhu@intel.com> In-Reply-To: <1549071693-50577-1-git-send-email-wenhuix.zhu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZWQ1NjcxNjktOWM2MC00ZWJmLWE5Y2EtMzVhYjk4ZmFlZmI4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidU1TdUN4RXFkMnlYd2pBTURmR2NTc0luRGJRTEFyMjlNeFNvaUh1OWFacXBKVWl6anRjZDQ5RnZxRGVHZFJIaSJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V4] tests/dual_vlan Change the verify outside the loop X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Feb 2019 09:31:07 -0000 Hi wenhui, Do you forget to set a condition to break the loop? I assumed you 'd like t= o break the loop if the Link status is up. > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhuwenhui > Sent: Saturday, February 2, 2019 9:42 AM > To: dts@dpdk.org > Cc: Zhu, WenhuiX > Subject: [dts] [PATCH V4] tests/dual_vlan Change the verify outside the l= oop >=20 > Verification should be outside the loop of the query port >=20 > Signed-off-by: zhuwenhui > --- > tests/TestSuite_dual_vlan.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/tests/TestSuite_dual_vlan.py b/tests/TestSuite_dual_vlan.py = index > d7fba3d..42497ef 100644 > --- a/tests/TestSuite_dual_vlan.py > +++ b/tests/TestSuite_dual_vlan.py > @@ -192,7 +192,7 @@ class TestDualVlan(TestCase): > time.sleep(1) > out =3D self.dut.send_expect("show port info %s" % port_= id, "testpmd> ") > port_time_up +=3D 1 > - self.verify("Link status: down" not in out, "Port %s Lin= k down, please > check your link" % port_id) > + self.verify("Link status: down" not in out, "Port %s Link > + down, please check your link" % port_id) >=20 > def multimode_test(self, caseIndex): > """ > -- > 2.17.2