test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Zhu, WenhuiX" <wenhuix.zhu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Zhu, WenhuiX" <wenhuix.zhu@intel.com>
Subject: Re: [dts] [PATCH V4] tests/dual_vlan Change the verify outside the loop
Date: Mon, 25 Feb 2019 10:13:46 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BA26CA2@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1549071693-50577-1-git-send-email-wenhuix.zhu@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhuwenhui
> Sent: Saturday, February 2, 2019 9:42 AM
> To: dts@dpdk.org
> Cc: Zhu, WenhuiX <wenhuix.zhu@intel.com>
> Subject: [dts] [PATCH V4] tests/dual_vlan Change the verify outside the loop
> 
> Verification should be outside the loop of the query port
> 
> Signed-off-by: zhuwenhui <wenhuix.zhu@intel.com>
> ---
>  tests/TestSuite_dual_vlan.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_dual_vlan.py b/tests/TestSuite_dual_vlan.py index
> d7fba3d..42497ef 100644
> --- a/tests/TestSuite_dual_vlan.py
> +++ b/tests/TestSuite_dual_vlan.py
> @@ -192,7 +192,7 @@ class TestDualVlan(TestCase):
>                  time.sleep(1)
>                  out = self.dut.send_expect("show port info %s" % port_id, "testpmd> ")
>                  port_time_up += 1
> -                self.verify("Link status: down" not in out, "Port %s Link down, please
> check your link" % port_id)
> +            self.verify("Link status: down" not in out, "Port %s Link
> + down, please check your link" % port_id)
> 
>      def multimode_test(self, caseIndex):
>          """
> --
> 2.17.2

      parent reply	other threads:[~2019-02-25 10:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-02  1:41 zhuwenhui
2019-02-02  6:36 ` Yao, BingX Y
2019-02-02  9:31 ` Tu, Lijuan
2019-02-11  1:40   ` Li, WenjieX A
2019-02-25 10:13 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BA26CA2@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=wenhuix.zhu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).