* [dts] [PATCH] tests/ipfrag: add method name in error message
@ 2019-04-22 13:47 Rami Rosen
2019-04-23 20:34 ` Tu, Lijuan
0 siblings, 1 reply; 2+ messages in thread
From: Rami Rosen @ 2019-04-22 13:47 UTC (permalink / raw)
To: dts; +Cc: Rami Rosen
There is no way to know, when getting "failed on forward packet size"
error, whether it is from functional_check_ipv4() or functional_check_ipv6().
This patch adds the method name when in these two method so
we will be able to track it.
Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
tests/TestSuite_ipfrag.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/TestSuite_ipfrag.py b/tests/TestSuite_ipfrag.py
index 9f47a2c..38a27e9 100644
--- a/tests/TestSuite_ipfrag.py
+++ b/tests/TestSuite_ipfrag.py
@@ -170,7 +170,7 @@ l3fwd_ipv4_route_array[] = {\\\n"
# verify normal packet just by number, verify fragment packet by all elements
pkts = self.tester.load_tcpdump_sniff_packets(inst)
- self.verify(len(pkts) == expPkts, "Failed on forward packet size " + str(size))
+ self.verify(len(pkts) == expPkts, "in functional_check_ipv4(): failed on forward packet size " + str(size))
if flag == 'frag':
idx = 1
for pkt in pkts:
@@ -220,7 +220,7 @@ l3fwd_ipv4_route_array[] = {\\\n"
# verify normal packet just by number, verify fragment packet by all elements
pkts = self.tester.load_tcpdump_sniff_packets(inst)
- self.verify(len(pkts) == expPkts, "Failed on forward packet size " + str(size))
+ self.verify(len(pkts) == expPkts, "In functional_check_ipv6(): failed on forward packet size " + str(size))
if flag == 'frag':
idx = 1
for pkt in pkts:
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dts] [PATCH] tests/ipfrag: add method name in error message
2019-04-22 13:47 [dts] [PATCH] tests/ipfrag: add method name in error message Rami Rosen
@ 2019-04-23 20:34 ` Tu, Lijuan
0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2019-04-23 20:34 UTC (permalink / raw)
To: Rami Rosen, dts
Applied, thanks
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Rami Rosen
> Sent: Monday, April 22, 2019 6:48 AM
> To: dts@dpdk.org
> Cc: Rami Rosen <ramirose@gmail.com>
> Subject: [dts] [PATCH] tests/ipfrag: add method name in error message
>
> There is no way to know, when getting "failed on forward packet size"
> error, whether it is from functional_check_ipv4() or functional_check_ipv6().
> This patch adds the method name when in these two method so we will be
> able to track it.
>
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
> ---
> tests/TestSuite_ipfrag.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/TestSuite_ipfrag.py b/tests/TestSuite_ipfrag.py index
> 9f47a2c..38a27e9 100644
> --- a/tests/TestSuite_ipfrag.py
> +++ b/tests/TestSuite_ipfrag.py
> @@ -170,7 +170,7 @@ l3fwd_ipv4_route_array[] = {\\\n"
>
> # verify normal packet just by number, verify fragment packet by all
> elements
> pkts = self.tester.load_tcpdump_sniff_packets(inst)
> - self.verify(len(pkts) == expPkts, "Failed on forward packet size " +
> str(size))
> + self.verify(len(pkts) == expPkts, "in
> + functional_check_ipv4(): failed on forward packet size " + str(size))
> if flag == 'frag':
> idx = 1
> for pkt in pkts:
> @@ -220,7 +220,7 @@ l3fwd_ipv4_route_array[] = {\\\n"
>
> # verify normal packet just by number, verify fragment packet by all
> elements
> pkts = self.tester.load_tcpdump_sniff_packets(inst)
> - self.verify(len(pkts) == expPkts, "Failed on forward packet size " +
> str(size))
> + self.verify(len(pkts) == expPkts, "In
> + functional_check_ipv6(): failed on forward packet size " + str(size))
> if flag == 'frag':
> idx = 1
> for pkt in pkts:
> --
> 1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-23 20:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-22 13:47 [dts] [PATCH] tests/ipfrag: add method name in error message Rami Rosen
2019-04-23 20:34 ` Tu, Lijuan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).