test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "nareddy@marvell.com" <nareddy@marvell.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Cc: "fmasood@marvell.com" <fmasood@marvell.com>,
	"avijay@marvell.com" <avijay@marvell.com>
Subject: Re: [dts] [PATCH] TestSuite_dynamic_config.py : Modified send packet	count to support vector mode
Date: Wed, 12 Jun 2019 02:51:21 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BAB93ED@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1560146951-31322-1-git-send-email-nareddy@marvell.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of
> nareddy@marvell.com
> Sent: Monday, June 10, 2019 2:09 PM
> To: dts@dpdk.org
> Cc: fmasood@marvell.com; avijay@marvell.com; Praneeth Reddy
> <nareddy@marvell.com>
> Subject: [dts] [PATCH] TestSuite_dynamic_config.py : Modified send packet
> count to support vector mode
> 
> From: Praneeth Reddy <nareddy@marvell.com>
> 
> In vector mode 4 packets are required.
> Modified packet count to 4 in all test cases.
> 
> Signed-off-by: Praneeth Reddy <nareddy@marvell.com>
> ---
>  tests/TestSuite_dynamic_config.py | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/tests/TestSuite_dynamic_config.py
> b/tests/TestSuite_dynamic_config.py
> index 012421c..301f5b7 100644
> --- a/tests/TestSuite_dynamic_config.py
> +++ b/tests/TestSuite_dynamic_config.py
> @@ -105,7 +105,7 @@ class TestDynamicConfig(TestCase):
> 
>          self.tester.scapy_foreground()
>          self.tester.scapy_append(
> -            'sendp([Ether(dst="%s", src="52:00:00:00:00:00")/Raw(load="X"*26)],
> iface="%s")' % (destMac, itf))
> +            'sendp([Ether(dst="%s",
> + src="52:00:00:00:00:00")/Raw(load="X"*26)], iface="%s", count=4)' %
> + (destMac, itf))
> 
>          self.tester.scapy_execute()
> 
> @@ -142,7 +142,7 @@ class TestDynamicConfig(TestCase):
> 
>          # check the packet increment
>          self.verify(int(cur_rxpkt) == int(pre_rxpkt)
> -                    + 1, "1st packet increment check error")
> +                    + 4, "1st packet increment check error")
> 
>          # send one packet with the portid MAC address
>          self.dynamic_config_send_packet(portid, self.dest) @@ -153,7 +153,7
> @@ class TestDynamicConfig(TestCase):
> 
>          # check the packet increment
>          self.verify(int(cur_rxpkt) == int(pre_rxpkt)
> -                    + 1, "2nd packet increment check error")
> +                    + 4, "2nd packet increment check error")
> 
>      def test_dynamic_config_disable_promiscuous(self):
>          """
> @@ -180,7 +180,7 @@ class TestDynamicConfig(TestCase):
>                "show port stats %d" % self.dut_ports[1], "testpmd> ")
>          cur_rxpkt = utils.regexp(out, "TX-packets: ([0-9]+)")
>          self.verify(int(cur_rxpkt) == int(
> -              pre_rxpkt) + 1, "2nd packet increment error")
> +              pre_rxpkt) + 4, "2nd packet increment error")
> 
>      def test_dynamic_config_broadcast(self):
>          """
> @@ -198,7 +198,7 @@ class TestDynamicConfig(TestCase):
>          out = self.dut.send_expect("show port stats %d" % self.dut_ports[1],
> "testpmd> ")
> 
>          cur_rxpkt = utils.regexp(out, "TX-packets: ([0-9]+)")
> -        self.verify(int(cur_rxpkt) == 1, "not received broadcast packet")
> +        self.verify(int(cur_rxpkt) == 4, "not received broadcast
> + packet")
> 
>          self.dut.send_expect("clear port stats all", "testpmd> ")
> 
> @@ -224,7 +224,7 @@ class TestDynamicConfig(TestCase):
>          out = self.dut.send_expect("show port stats %d" % self.dut_ports[1],
> "testpmd> ")
> 
>          cur_rxpkt = utils.regexp(out, "TX-packets: ([0-9]+)")
> -        self.verify(int(cur_rxpkt) == 1, "enable allmulti switch, not received
> allmulti packet")
> +        self.verify(int(cur_rxpkt) == 4, "enable allmulti switch, not
> + received allmulti packet")
> 
>          self.dut.send_expect("clear port stats all", "testpmd> ")
>          self.dut.send_expect("set allmulti all off", "testpmd> ") @@ -257,7
> +257,7 @@ class TestDynamicConfig(TestCase):
> 
>          # check the packet increment
>          self.verify(int(cur_rxpkt) == int(pre_rxpkt)
> -                    + 1, "1st packet increment error")
> +                    + 4, "1st packet increment error")
> 
>          # send one packet with the portid MAC address
>          self.dynamic_config_send_packet(portid, self.dest) @@ -268,7 +268,7
> @@ class TestDynamicConfig(TestCase):
> 
>          # check the packet increment
>          self.verify(int(cur_rxpkt) == int(pre_rxpkt)
> -                    + 1, "2nd packet increment error")
> +                    + 4, "2nd packet increment error")
> 
>          #self.dut.send_expect("quit", "# ", 30)
> 
> --
> 1.8.3.1


      reply	other threads:[~2019-06-12  2:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-10  6:09 nareddy
2019-06-12  2:51 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BAB93ED@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=avijay@marvell.com \
    --cc=dts@dpdk.org \
    --cc=fmasood@marvell.com \
    --cc=nareddy@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).